mirror of
https://github.com/hardkernel/linux.git
synced 2026-05-31 08:16:39 +09:00
staging: comedi: usbduxsigma: move urb unlink into usbduxsigma_detach()
For aesthetics, move the final force unlink of the urbs from usbduxsigma_free_usb_buffers() to usbduxsigma_detach(). Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
1c379e94b3
commit
71d7e1ee2c
@@ -1621,11 +1621,6 @@ static void usbduxsigma_free_usb_buffers(struct comedi_device *dev)
|
||||
struct urb *urb;
|
||||
int i;
|
||||
|
||||
/* force unlink all urbs */
|
||||
usbduxsigma_ai_stop(dev, 1);
|
||||
usbduxsigma_ao_stop(dev, 1);
|
||||
usbduxsigma_pwm_stop(dev, 1);
|
||||
|
||||
urb = devpriv->pwm_urb;
|
||||
if (urb) {
|
||||
kfree(urb->transfer_buffer);
|
||||
@@ -1714,7 +1709,14 @@ static void usbduxsigma_detach(struct comedi_device *dev)
|
||||
usb_set_intfdata(intf, NULL);
|
||||
|
||||
down(&devpriv->sem);
|
||||
|
||||
/* force unlink all urbs */
|
||||
usbduxsigma_ai_stop(dev, 1);
|
||||
usbduxsigma_ao_stop(dev, 1);
|
||||
usbduxsigma_pwm_stop(dev, 1);
|
||||
|
||||
usbduxsigma_free_usb_buffers(dev);
|
||||
|
||||
up(&devpriv->sem);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user