shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-07 03:15:31 +09:00
Code Issues Packages Projects Releases Wiki Activity

media: imx: imx8mq-mipi-csi2: remove wrong irq config write operation

Browse Source 
[ Upstream commit 59c2b6d518 ]

The place where this register writel() that masks one interrupt is placed
does not guarantee that the device is powered so that's not allowed.
Moreover imx8mq_mipi_csi_start_stream() masks the interrupt anyway so the
write is not even needed. Remove it as this is a mistake that slipped in
with the driver.

Fixes: f33fd8d77d ("media: imx: add a driver for i.MX8MQ mipi csi rx phy and controller")
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Martin Kepplinger
2021-12-16 10:03:35 +01:00
committed by Greg Kroah-Hartman
parent 0022dc8caf
commit 72d79cd3c3
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/media/imx/imx8mq-mipi-csi2.c
View File

@@ -398,9 +398,6 @@ static int imx8mq_mipi_csi_s_stream(struct v4l2_subdev *sd, int enable)
struct csi_state *state = mipi_sd_to_csi2_state(sd);
int ret = 0;
imx8mq_mipi_csi_write(state, CSI2RX_IRQ_MASK,
CSI2RX_IRQ_MASK_ULPS_STATUS_CHANGE);
if (enable) {
ret = pm_runtime_resume_and_get(state->dev);
if (ret < 0)