shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-02 01:06:46 +09:00
Code Issues Packages Projects Releases Wiki Activity

staging: comedi: rti800: cleanup dev->board_name usage

Browse Source 
The comedi core initializes the dev->board_name before calling the
driver (*attach) function. There is not reason to reinitialize it
in the driver.

Use the dev->board_name when doing the request_{region,irq}() instead
of the open-coded string.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten
2013-04-08 18:15:46 -07:00
committed by Greg Kroah-Hartman
parent 62d4d5613d
commit 7b2234df5e
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/comedi/drivers/rti800.c
View File

@@ -309,7 +309,7 @@ static int rti800_attach(struct comedi_device *dev, struct comedi_devconfig *it)
struct comedi_subdevice *s;
iobase = it->options[0];
if (!request_region(iobase, RTI800_SIZE, "rti800"))
if (!request_region(iobase, RTI800_SIZE, dev->board_name))
return -EIO;
dev->iobase = iobase;
@@ -319,14 +319,13 @@ static int rti800_attach(struct comedi_device *dev, struct comedi_devconfig *it)
irq = it->options[1];
if (irq) {
ret = request_irq(irq, rti800_interrupt, 0, "rti800", dev);
ret = request_irq(irq, rti800_interrupt, 0, dev->board_name,
dev);
if (ret < 0)
return ret;
dev->irq = irq;
}
dev->board_name = board->name;
ret = comedi_alloc_subdevices(dev, 4);
if (ret)
return ret;