Revert "ANDROID: KVM: arm64: iommu: Optimize snapshot_host_stage2"

This reverts commit 8b304ef274.

Bug: 233587962
Signed-off-by: Will Deacon <willdeacon@google.com>
Change-Id: I986e5e99986ba18ac24b54bb94ebeda781b55d8f
This commit is contained in:
Will Deacon
2022-07-07 15:48:52 +01:00
parent 52273e667f
commit 7e017331f5
2 changed files with 4 additions and 6 deletions

View File

@@ -15,8 +15,6 @@ struct pkvm_iommu_ops {
* Driver-specific arguments are passed in a buffer shared by the host.
* The buffer memory has been pinned in EL2 but host retains R/W access.
* Extra care must be taken when reading from it to avoid TOCTOU bugs.
* If the driver maintains its own page tables, it is expected to
* initialize them to all memory owned by the host.
* Driver initialization lock held during callback.
*/
int (*init)(void *data, size_t size);

View File

@@ -181,16 +181,16 @@ static int __snapshot_host_stage2(u64 start, u64 pa_max, u32 level,
{
struct pkvm_iommu_driver * const drv = arg;
u64 end = start + kvm_granule_size(level);
enum kvm_pgtable_prot prot;
kvm_pte_t pte = *ptep;
/*
* Valid stage-2 entries are created lazily, invalid ones eagerly.
* Note: In the future we may need to check if [start,end) is MMIO.
* Note: Drivers initialize their PTs to all memory owned by the host,
* so we only call the driver on regions where that is not the case.
*/
if (pte && !kvm_pte_valid(pte))
drv->ops->host_stage2_idmap_prepare(start, end, /*prot*/ 0);
prot = (!pte || kvm_pte_valid(pte)) ? PKVM_HOST_MEM_PROT : 0;
drv->ops->host_stage2_idmap_prepare(start, end, prot);
return 0;
}