mirror of
https://github.com/hardkernel/linux.git
synced 2026-03-24 19:40:21 +09:00
remoteproc: fix error path of handle_vdev
BugLink: http://bugs.launchpad.net/bugs/1168506
commit cde42e076c upstream.
Remove the vdev entry from the list before freeing it,
otherwise rproc->vdevs will explode.
Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
Acked-by: Ido Yariv <ido@wizery.com>
[edit subject, minor commit log edit, cc stable]
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
This commit is contained in:
committed by
Tim Gardner
parent
ccbe23e2ab
commit
7e1d89a1cc
@@ -370,10 +370,12 @@ static int rproc_handle_vdev(struct rproc *rproc, struct fw_rsc_vdev *rsc,
|
||||
/* it is now safe to add the virtio device */
|
||||
ret = rproc_add_virtio_dev(rvdev, rsc->id);
|
||||
if (ret)
|
||||
goto free_rvdev;
|
||||
goto remove_rvdev;
|
||||
|
||||
return 0;
|
||||
|
||||
remove_rvdev:
|
||||
list_del(&rvdev->node);
|
||||
free_rvdev:
|
||||
kfree(rvdev);
|
||||
return ret;
|
||||
|
||||
Reference in New Issue
Block a user