mirror of
https://github.com/hardkernel/linux.git
synced 2026-04-21 13:00:44 +09:00
Staging: asus_oled: fix up some sysfs attribute permissions
commit 590b0b9754 upstream.
They should not be writable by any user
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jakub Schmidtke <sjakub@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
@@ -620,13 +620,13 @@ static ssize_t class_set_picture(struct device *device,
|
||||
|
||||
#define ASUS_OLED_DEVICE_ATTR(_file) dev_attr_asus_oled_##_file
|
||||
|
||||
static DEVICE_ATTR(asus_oled_enabled, S_IWUGO | S_IRUGO,
|
||||
static DEVICE_ATTR(asus_oled_enabled, S_IRUSR | S_IRUGO,
|
||||
get_enabled, set_enabled);
|
||||
static DEVICE_ATTR(asus_oled_picture, S_IWUGO , NULL, set_picture);
|
||||
static DEVICE_ATTR(asus_oled_picture, S_IRUSR , NULL, set_picture);
|
||||
|
||||
static DEVICE_ATTR(enabled, S_IWUGO | S_IRUGO,
|
||||
static DEVICE_ATTR(enabled, S_IRUSR | S_IRUGO,
|
||||
class_get_enabled, class_set_enabled);
|
||||
static DEVICE_ATTR(picture, S_IWUGO, NULL, class_set_picture);
|
||||
static DEVICE_ATTR(picture, S_IRUSR, NULL, class_set_picture);
|
||||
|
||||
static int asus_oled_probe(struct usb_interface *interface,
|
||||
const struct usb_device_id *id)
|
||||
|
||||
Reference in New Issue
Block a user