shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-08 20:07:46 +09:00
Code Issues Packages Projects Releases Wiki Activity

cifsd: Remove smb2_put_name()

Browse Source 
smb2_put_name() is called twice, and both call sites do the IS_ERR() check
before.

Signed-off-by: Marios Makassikis <mmakassikis@freebox.fr>
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
Marios Makassikis
2021-04-13 13:25:57 +09:00
committed by Steve French
parent 24b626967d
commit 915f570a97
1 changed files with 2 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
fs/cifsd/smb2pdu.c
View File

@@ -666,16 +666,6 @@ smb2_get_name(struct ksmbd_share_config *share, const char *src,
return unixname;
}
/**
* smb2_put_name() - free memory allocated for filename
* @name: filename pointer to be freed
*/
static void smb2_put_name(void *name)
{
if (!IS_ERR(name))
kfree(name);
}
int setup_async_work(struct ksmbd_work *work, void (*fn)(void **), void **arg)
{
struct smb2_hdr *rsp_hdr;
@@ -5418,7 +5408,7 @@ static int smb2_rename(struct ksmbd_work *work, struct ksmbd_file *fp,
out:
kfree(pathname);
if (!IS_ERR(new_name))
smb2_put_name(new_name);
kfree(new_name);
return rc;
}
@@ -5483,7 +5473,7 @@ static int smb2_create_link(struct ksmbd_work *work,
rc = -EINVAL;
out:
if (!IS_ERR(link_name))
smb2_put_name(link_name);
kfree(link_name);
kfree(pathname);
return rc;
}