mirror of
https://github.com/hardkernel/linux.git
synced 2026-06-05 18:41:58 +09:00
ALSA: vxpocket: Fix resource leak in vxpocket_probe error path
[ Upstream commit 2a03b40deacbd293ac9aed0f9b11197dad54fe5f ]
When vxpocket_config() fails, vxpocket_probe() returns the error code
directly without freeing the sound card resources allocated by
snd_card_new(), which leads to a memory leak.
Add proper error handling to free the sound card and clear the
allocation bit when vxpocket_config() fails.
Fixes: 15b99ac172 ("[PATCH] pcmcia: add return value to _config() functions")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20251215042652.695-1-vulab@iscas.ac.cn
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
8f289fa129
commit
930acded6b
@@ -295,7 +295,13 @@ static int vxpocket_probe(struct pcmcia_device *p_dev)
|
||||
|
||||
vxp->p_dev = p_dev;
|
||||
|
||||
return vxpocket_config(p_dev);
|
||||
err = vxpocket_config(p_dev);
|
||||
if (err < 0) {
|
||||
card_alloc &= ~(1 << i);
|
||||
snd_card_free(card);
|
||||
return err;
|
||||
}
|
||||
return 0;
|
||||
}
|
||||
|
||||
static void vxpocket_detach(struct pcmcia_device *link)
|
||||
|
||||
Reference in New Issue
Block a user