shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-04-23 05:51:27 +09:00
Code Issues Packages Projects Releases Wiki Activity

irda: Fix parameter extraction stack overflow

Browse Source 
commit efc463eb50 upstream.

Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com>
Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Samuel Ortiz
2010-10-11 01:17:56 +02:00
committed by Greg Kroah-Hartman
parent 84ddc52c95
commit 9d74ebe51d
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
net/irda/parameters.c
View File

@@ -298,6 +298,8 @@ static int irda_extract_string(void *self, __u8 *buf, int len, __u8 pi,
p.pi = pi; /* In case handler needs to know */
p.pl = buf[1]; /* Extract length of value */
if (p.pl > 32)
p.pl = 32;
IRDA_DEBUG(2, "%s(), pi=%#x, pl=%d\n", __func__,
p.pi, p.pl);
@@ -318,7 +320,7 @@ static int irda_extract_string(void *self, __u8 *buf, int len, __u8 pi,
(__u8) str[0], (__u8) str[1]);
/* Null terminate string */
str[p.pl+1] = '\0';
str[p.pl] = '\0';
p.pv.c = str; /* Handler will need to take a copy */