shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-04 18:19:28 +09:00
Code Issues Packages Projects Releases Wiki Activity

media: atomisp-ov2680: Fix ov2680_write_reg() always writing 0 to 16 bit registers

Browse Source 
The shift << 16 of the value in the code path for 16 bit values is
bogus, put_unaligned_be16() takes the lower 16 bits which will not
always be 0.

This was causing __ov2680_set_exposure() to always set the
OV2680_AGC and OV2680_TIMING_VTS registers to 0.

Link: https://lore.kernel.org/linux-media/20211107171549.267583-10-hdegoede@redhat.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Hans de Goede
2021-11-07 17:15:47 +00:00
committed by Mauro Carvalho Chehab
parent bc53e5bdbc
commit 9f7b638637
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
View File

@@ -86,7 +86,7 @@ static int ov2680_write_reg(struct i2c_client *client, unsigned int len,
int ret;
if (len == 2)
put_unaligned_be16(val << (8 * (4 - len)), buf + 2);
put_unaligned_be16(val, buf + 2);
else if (len == 1)
buf[2] = val;
else