shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-07 19:30:30 +09:00
Code Issues Packages Projects Releases Wiki Activity

drivers: rkflash: Fix mtd mark bad strategy

Browse Source 
1.Fix wrong return value
2.Results are subject to back reading verification

Change-Id: Ifd3965423261617bdaeecc10fd4da28cb703b2aa
Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
This commit is contained in:
Jon Lin
2020-04-17 17:02:47 +08:00
parent 6662e6c683
commit 9ff22ce691
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/rkflash/sfc_nand_mtd.c
View File

@@ -188,19 +188,27 @@ static int sfc_markbad_mtd(struct mtd_info *mtd, loff_t ofs)
/* Erase block before marking it bad. */
ret = sfc_nand_erase_block(0, ofs >> mtd->writesize_shift);
if (ret)
goto out;
rkflash_print_error("%s erase fail ofs 0x%llx ret=%d\n",
__func__, ofs, ret);
/* Mark bad. */
ret = sfc_nand_mark_bad_block(0, ofs >> mtd->writesize_shift);
if (ret)
goto out;
rkflash_print_error("%s mark fail ofs 0x%llx ret=%d\n",
__func__, ofs, ret);
out:
mutex_unlock(p_dev->lock);
if (!ret) {
/* Mark bad recheck */
if (sfc_nand_check_bad_block(0, ofs >> mtd->writesize_shift)) {
mtd->ecc_stats.badblocks++;
ret = 0;
} else {
rkflash_print_error("%s recheck fail ofs 0x%llx ret=%d\n",
__func__, ofs, ret);
ret = -EIO;
}
mutex_unlock(p_dev->lock);
return ret;
}