shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-06 10:58:48 +09:00
Code Issues Packages Projects Releases Wiki Activity

drm/rockchip: vop2: Improved performance of pixel shift

Browse Source 
The original version would hold the DRM lock and immediately do a
drm_atomic_commit(), which may result in significant loss of
performance.

This patch postpones the commit timing. When the DRM commit has
taken effect, no additional commits will be made.

Change-Id: I04843e5ff490152fb53a967ed3fbd2e010d84ed6
Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
This commit is contained in:
Chaoyi Chen
2024-01-24 14:06:11 +08:00
committed by Tao Huang
parent a335f80dff
commit a4cd535799
1 changed files with 27 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
View File

@@ -259,6 +259,10 @@ enum vop2_layer_phy_id {
};
struct pixel_shift_data {
u64 last_crtc_update_count;
u64 crtc_update_count;
struct drm_crtc *crtc;
struct delayed_work pixel_shift_work;
bool enable;
};
@@ -7301,6 +7305,20 @@ static void rockchip_drm_vop2_pixel_shift_commit(struct drm_device *dev, struct
}
}
static void pixel_shift_work(struct work_struct *work)
{
struct pixel_shift_data *data;
struct drm_crtc *crtc;
struct drm_device *drm_dev;
data = container_of(to_delayed_work(work), struct pixel_shift_data, pixel_shift_work);
crtc = data->crtc;
drm_dev = crtc->dev;
if (data->crtc_update_count == data->last_crtc_update_count)
rockchip_drm_vop2_pixel_shift_commit(drm_dev, crtc);
}
static ssize_t pixel_shift_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
{
@@ -7323,7 +7341,10 @@ static ssize_t pixel_shift_store(struct device *dev, struct device_attribute *at
vcstate->shift_x = shift_x;
vcstate->shift_y = shift_y;
rockchip_drm_vop2_pixel_shift_commit(drm_dev, crtc);
if (!delayed_work_pending(&vp->pixel_shift.pixel_shift_work)) {
vp->pixel_shift.last_crtc_update_count = vp->pixel_shift.crtc_update_count;
schedule_delayed_work(&vp->pixel_shift.pixel_shift_work, msecs_to_jiffies(100));
}
return count;
}
@@ -7361,6 +7382,9 @@ static int vop2_pixel_shift_sysfs_init(struct device *dev, struct drm_crtc *crtc
goto disable;
}
vp->pixel_shift.crtc = crtc;
INIT_DELAYED_WORK(&vp->pixel_shift.pixel_shift_work, pixel_shift_work);
return 0;
disable:
@@ -11591,6 +11615,8 @@ static void vop2_crtc_atomic_flush(struct drm_crtc *crtc, struct drm_atomic_stat
drm_flip_work_queue(&vp->fb_unref_work, old_pstate->fb);
set_bit(VOP_PENDING_FB_UNREF, &vp->pending);
}
vp->pixel_shift.crtc_update_count++;
}
static const struct drm_crtc_helper_funcs vop2_crtc_helper_funcs = {