shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-10 12:57:06 +09:00
Code Issues Packages Projects Releases Wiki Activity

of/device: Fix platform_device.name point to an freed memory after

Browse Source 
dev_set_name()

When we use of_device_add() to create platform_device and add it to device
hierarchy, the platform_device.name and device's name will point to the same
memory.

Later we use dev_set_name() to change the device's name, it will alloc new
memory to store name and free old device's name. After it, the
platform_device.name will point to an freed memory, access platform_device.name
 maybe lead to unpredictable exceptions.

So, we alloc new memory for platform_device.name in of_device_add()

Change-Id: I59bf0941ee4e094053971d41d386206e47fddcaa
Signed-off-by: Meiyou Chen <cmy@rock-chips.com>
This commit is contained in:
Meiyou Chen
2015-09-11 10:30:54 +08:00
parent 8be554a502
commit a51927d3ac
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/of/device.c
View File

@@ -54,7 +54,11 @@ int of_device_add(struct platform_device *ofdev)
/* name and id have to be set so that the platform bus doesn't get
* confused on matching */
#ifdef CONFIG_ARCH_ROCKCHIP
ofdev->name = kasprintf(GFP_KERNEL, "%s", dev_name(&ofdev->dev));
#else
ofdev->name = dev_name(&ofdev->dev);
#endif
ofdev->id = -1;
/* device_add will assume that this device is on the same node as