mirror of
https://github.com/hardkernel/linux.git
synced 2026-06-08 20:07:46 +09:00
ir: fix allocation of memory without size check issue [1/1]
PD#SWPL-11248 Problem: When handling the set attribute IOCTL REMOTE_IOC_SET_KEY_NUMBER, the driver does not limit the size of allocation with kzalloc. Solution: Limit the size of alllcation range, if given a value out of range, set update flag to false and do nothing in kzalloc stage. Verify: W400 Change-Id: I6a4150f5615557c372738c918aad86120d149340 Signed-off-by: Qianggui Song <qianggui.song@amlogic.com>
This commit is contained in:
@@ -71,6 +71,13 @@ static long remote_ioctl(struct file *file, unsigned int cmd,
|
||||
retval = -EFAULT;
|
||||
goto err;
|
||||
}
|
||||
|
||||
if (value < 1 || value > MAX_KEYMAP_SIZE) {
|
||||
chip->key_num.update_flag = false;
|
||||
retval = -EINVAL;
|
||||
goto err;
|
||||
}
|
||||
|
||||
chip->key_num.update_flag = true;
|
||||
chip->key_num.value = value;
|
||||
break;
|
||||
|
||||
Reference in New Issue
Block a user