mirror of
https://github.com/hardkernel/linux.git
synced 2026-06-06 10:58:48 +09:00
USB: gadget: bcm63xx_udc: fix memory leak with using debugfs_lookup()
[ Upstream commit a91c99b1fe ]
When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time. To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.
Cc: Kevin Cernekee <cernekee@gmail.com>
Link: https://lore.kernel.org/r/20230202153235.2412790-9-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
@@ -2259,7 +2259,7 @@ static void bcm63xx_udc_init_debugfs(struct bcm63xx_udc *udc)
|
||||
*/
|
||||
static void bcm63xx_udc_cleanup_debugfs(struct bcm63xx_udc *udc)
|
||||
{
|
||||
debugfs_remove(debugfs_lookup(udc->gadget.name, usb_debug_root));
|
||||
debugfs_lookup_and_remove(udc->gadget.name, usb_debug_root);
|
||||
}
|
||||
|
||||
/***********************************************************************
|
||||
|
||||
Reference in New Issue
Block a user