shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-08 11:50:43 +09:00
Code Issues Packages Projects Releases Wiki Activity

usb: dwc3: rockchip: remove unused NULL pointer handle otg_work

Browse Source 
We make sure that get drvdata dwc before register extcon
notifier and schedule otg_work, so we can remove the dwc
NULL pointer handle safely.

Also, change the WARN_ON to dev_warn, and avoid log noise.

Change-Id: Icececf3bb5ad510b91d2c3a50e2126225673605e
Signed-off-by: William wu <wulf@rock-chips.com>
This commit is contained in:
William wu
2016-10-10 12:37:51 +08:00
committed by Huang, Tao
parent 0d9cd7338b
commit b67d7743ec
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/usb/dwc3/dwc3-rockchip.c
View File

@@ -86,9 +86,6 @@ static void dwc3_rockchip_otg_extcon_evt_work(struct work_struct *work)
int ret;
u32 reg;
if (!dwc)
return;
mutex_lock(&rockchip->lock);
if (extcon_get_cable_state_(edev, EXTCON_USB) > 0) {
@@ -99,8 +96,10 @@ static void dwc3_rockchip_otg_extcon_evt_work(struct work_struct *work)
* If dr_mode is host only, never to set
* the mode to the peripheral mode.
*/
if (WARN_ON(dwc->dr_mode == USB_DR_MODE_HOST))
if (dwc->dr_mode == USB_DR_MODE_HOST) {
dev_warn(rockchip->dev, "USB peripheral not support!\n");
goto out;
}
/*
* Assert otg reset can put the dwc in P2 state, it's
@@ -133,8 +132,10 @@ static void dwc3_rockchip_otg_extcon_evt_work(struct work_struct *work)
* If dr_mode is device only, never to
* set the mode to the host mode.
*/
if (WARN_ON(dwc->dr_mode == USB_DR_MODE_PERIPHERAL))
if (dwc->dr_mode == USB_DR_MODE_PERIPHERAL) {
dev_warn(rockchip->dev, "USB HOST not support!\n");
goto out;
}
/*
* Assert otg reset can put the dwc in P2 state, it's