mirror of
https://github.com/hardkernel/linux.git
synced 2026-06-07 19:30:30 +09:00
btrfs: drop block from cache on error in relocation
commit 8e19c9732a upstream.
If we have an error while building the backref tree in relocation we'll
process all the pending edges and then free the node. However if we
integrated some edges into the cache we'll lose our link to those edges
by simply freeing this node, which means we'll leak memory and
references to any roots that we've found.
Instead we need to use remove_backref_node(), which walks through all of
the edges that are still linked to this node and free's them up and
drops any root references we may be holding.
CC: stable@vger.kernel.org # 4.9+
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
b2f7d0adc1
commit
c7b7daf956
@@ -1185,7 +1185,7 @@ out:
|
||||
free_backref_node(cache, lower);
|
||||
}
|
||||
|
||||
free_backref_node(cache, node);
|
||||
remove_backref_node(cache, node);
|
||||
return ERR_PTR(err);
|
||||
}
|
||||
ASSERT(!node || !node->detached);
|
||||
|
||||
Reference in New Issue
Block a user