shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-07 19:30:30 +09:00
Code Issues Packages Projects Releases Wiki Activity

osd: fix ge2d coverity error [1/1]

Browse Source 
PD#SWPL-2798

Problem:
fix ge2d coverity error

Solution:
add return val timeout for waiting completion

Verify:
verified on P212

Change-Id: Iaacf3f5b30721eb5d72d3c355f0404f4848969b5
Signed-off-by: Jian Cao <jian.cao@amlogic.com>
This commit is contained in:
Jian Cao
2018-12-07 17:52:12 +08:00
committed by Dongjin Kim
parent 75320ab24e
commit c924880485
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/amlogic/media/common/ge2d/ge2d_wq.c
View File

@@ -1858,7 +1858,7 @@ int destroy_ge2d_work_queue(struct ge2d_context_s *ge2d_work_queue)
{
struct ge2d_queue_item_s *pitem, *tmp;
struct list_head *head;
int empty;
int empty, timeout = 0;
if (ge2d_work_queue) {
/* first detatch it from the process queue,then delete it . */
@@ -1870,9 +1870,11 @@ int destroy_ge2d_work_queue(struct ge2d_context_s *ge2d_work_queue)
if ((ge2d_manager.current_wq == ge2d_work_queue) &&
(ge2d_manager.ge2d_state == GE2D_STATE_RUNNING)) {
ge2d_work_queue->ge2d_request_exit = 1;
wait_for_completion_timeout(
&ge2d_manager.event.process_complete,
msecs_to_jiffies(500));
timeout = wait_for_completion_timeout(
&ge2d_manager.event.process_complete,
msecs_to_jiffies(500));
if (!timeout)
ge2d_log_err("wait timeout\n");
/* condition so complex ,simplify it . */
ge2d_manager.last_wq = NULL;
} /* else we can delete it safely. */