crypto: mediatek - Fix wrong return value in mtk_desc_ring_alloc()

[ Upstream commit 8cbde6c6a6 ]

In case of memory allocation failure, a negative error code should
be returned.

Fixes: 785e5c616c ("crypto: mediatek - Add crypto driver support for some MediaTek chips")
Cc: Ryder Lee <ryder.lee@mediatek.com>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Tianjia Zhang
2020-08-02 19:15:32 +08:00
committed by Greg Kroah-Hartman
parent b0112ecef7
commit d7b164f4d6

View File

@@ -446,7 +446,7 @@ static void mtk_desc_dma_free(struct mtk_cryp *cryp)
static int mtk_desc_ring_alloc(struct mtk_cryp *cryp)
{
struct mtk_ring **ring = cryp->ring;
int i, err = ENOMEM;
int i;
for (i = 0; i < MTK_RING_MAX; i++) {
ring[i] = kzalloc(sizeof(**ring), GFP_KERNEL);
@@ -480,7 +480,7 @@ err_cleanup:
ring[i]->cmd_base, ring[i]->cmd_dma);
kfree(ring[i]);
}
return err;
return -ENOMEM;
}
static int mtk_crypto_probe(struct platform_device *pdev)