shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-09 04:10:18 +09:00
Code Issues Packages Projects Releases Wiki Activity

phy/rockchip: inno-video-phy: Fix phy poweron failed in TTL mode

Browse Source 
Don't enable PLL in TTL mode, it's only validated for LVDS mode.

[    4.193355] inno-video-phy ff96c000.video-phy: PLL is not lock
[    4.193380] phy phy-ff96c000.video-phy.3: phy poweron failed --> -110

Change-Id: I353aebcaee5c53d675f9052c29c9e3c205c4ff4a
Signed-off-by: Wyon Bi <bivvy.bi@rock-chips.com>
This commit is contained in:
Wyon Bi
2019-06-04 15:46:21 +08:00
committed by Tao Huang
parent c9443140c6
commit d982bbe9bb
1 changed files with 30 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
drivers/phy/rockchip/phy-rockchip-inno-video-phy.c
View File

@@ -80,34 +80,20 @@ static const struct reg_sequence lvds_mode_dual_channel[] = {
{ 0x0180, 0x44 },
};
static int inno_video_phy_power_on(struct phy *phy)
static int inno_video_phy_lvds_mode_enable(struct inno_video_phy *inno,
bool dual_channel)
{
struct inno_video_phy *inno = phy_get_drvdata(phy);
const struct reg_sequence *wseq;
bool dual_channel = phy_get_bus_width(phy) == 2 ? true : false;
int nregs;
u32 status;
int ret;
clk_prepare_enable(inno->pclk);
pm_runtime_get_sync(inno->dev);
switch (inno->mode) {
case PHY_MODE_VIDEO_LVDS:
if (dual_channel) {
wseq = lvds_mode_dual_channel;
nregs = ARRAY_SIZE(lvds_mode_dual_channel);
} else {
wseq = lvds_mode_single_channel;
nregs = ARRAY_SIZE(lvds_mode_single_channel);
}
break;
case PHY_MODE_VIDEO_TTL:
wseq = ttl_mode;
nregs = ARRAY_SIZE(ttl_mode);
break;
default:
return -EINVAL;
if (dual_channel) {
wseq = lvds_mode_dual_channel;
nregs = ARRAY_SIZE(lvds_mode_dual_channel);
} else {
wseq = lvds_mode_single_channel;
nregs = ARRAY_SIZE(lvds_mode_single_channel);
}
regmap_multi_reg_write(inno->regmap, wseq, nregs);
@@ -125,6 +111,28 @@ static int inno_video_phy_power_on(struct phy *phy)
return 0;
}
static int inno_video_phy_power_on(struct phy *phy)
{
struct inno_video_phy *inno = phy_get_drvdata(phy);
clk_prepare_enable(inno->pclk);
pm_runtime_get_sync(inno->dev);
switch (inno->mode) {
case PHY_MODE_VIDEO_LVDS:
return inno_video_phy_lvds_mode_enable(inno,
phy_get_bus_width(phy) == 2 ? true : false);
case PHY_MODE_VIDEO_TTL:
regmap_multi_reg_write(inno->regmap, ttl_mode,
ARRAY_SIZE(ttl_mode));
break;
default:
return -EINVAL;
}
return 0;
}
static int inno_video_phy_power_off(struct phy *phy)
{
struct inno_video_phy *inno = phy_get_drvdata(phy);