shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-07 19:30:30 +09:00
Code Issues Packages Projects Releases Wiki Activity

time: fix fail to read generic timer's counter value correctly [1/1]

Browse Source 
PD#SWPL-6837

Problem:
The return value of arch_counter_get_cntvct is always abnormal
when it is in irq stack. In this case, arch_counter_get_cntvct
trys to access a variable in 8Bytes via a 4Bytes aligned addr-
ess, which vialates the rule: The address that is accessed
should be aligned to the size of the data element being
accessed

Solution:
after switching to irq stack, force the base sp value to be
16Bytes aligned. Since the address of variable in irq stack is
based on the base sp and arranged automatically, all the data
accessing in irq stack will be aligned.

Verify:
Ampere

Change-Id: I3b30a56491dd0720d1c885bfaf2ca98d1b103fdd
Signed-off-by: Jiamin Ma <jiamin.ma@amlogic.com>
(cherry picked from commit 043ae971bf)
This commit is contained in:
Jiamin Ma
2019-04-08 17:06:27 +08:00
committed by Luan Yuan
parent 230e822ef5
commit e3e9cf23ba
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
arch/arm/kernel/unwind.c
View File

@@ -544,7 +544,7 @@ void unwind_backtrace(struct pt_regs *regs, struct task_struct *tsk)
sp_irq = (unsigned long)irq_stack[cpu];
addr = *((unsigned long *)(sp_irq +
THREAD_INFO_OFFSET - 8 -
sizeof(addr)));
sizeof(addr) - 12));
pt_regs = (struct pt_regs *)addr;
frame.fp = pt_regs->ARM_fp;
frame.sp = pt_regs->ARM_sp;

3
drivers/amlogic/memory_ext/vmap_stack.c
View File

@@ -163,8 +163,9 @@ unsigned long notrace irq_stack_entry(unsigned long sp)
sp_irq = (unsigned long)dst - 8;
/*
* save start addr of the interrupted task's context
* minus an extra 12 to force base sp 16Bytes aligned
*/
sp_irq = sp_irq - sizeof(sp);
sp_irq = sp_irq - sizeof(sp) - 12;
*((unsigned long *)sp_irq) = sp;
return sp_irq;
}