shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-08 03:40:35 +09:00
Code Issues Packages Projects Releases Wiki Activity

video/rockchip: mpp: rkvdec fix smatch warning

Browse Source 
[smatch] drivers/video/rockchip/mpp/mpp_rkvdec.c:1239 rkvdec_devfreq_init() warn: passing zero to 'PTR_ERR'

Change-Id: Ie3777be55262034274beaa377c25febb36e83e64
Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
This commit is contained in:
Jianqun Xu
2020-03-06 09:18:10 +08:00
parent 73da7c8a6b
commit e55b428d85
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/video/rockchip/mpp/mpp_rkvdec.c
View File

@@ -1236,11 +1236,10 @@ static int rkvdec_devfreq_init(struct mpp_dev *mpp)
dec->parent_devfreq = devfreq_get_devfreq_by_phandle(mpp->dev, 0);
if (IS_ERR_OR_NULL(dec->parent_devfreq)) {
ret = PTR_ERR(dec->parent_devfreq);
if (ret == -EPROBE_DEFER) {
if (PTR_ERR(dec->parent_devfreq) == -EPROBE_DEFER) {
dev_warn(mpp->dev, "parent devfreq is not ready, retry\n");
return ret;
return -EPROBE_DEFER;
}
} else {
dec->devfreq_nb.notifier_call = devfreq_notifier_call;
@@ -1252,11 +1251,10 @@ static int rkvdec_devfreq_init(struct mpp_dev *mpp)
dec->vdd = devm_regulator_get_optional(mpp->dev, "vcodec");
if (IS_ERR_OR_NULL(dec->vdd)) {
ret = PTR_ERR(dec->vdd);
if (ret == -EPROBE_DEFER) {
if (PTR_ERR(dec->vdd) == -EPROBE_DEFER) {
dev_warn(mpp->dev, "vcodec regulator not ready, retry\n");
return ret;
return -EPROBE_DEFER;
}
dev_warn(mpp->dev, "no regulator for vcodec\n");