shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-04 02:02:28 +09:00
Code Issues Packages Projects Releases Wiki Activity

iscsi-target: fix extract_param to handle buffer length corner case

Browse Source 
commit 369653e4fb upstream.

extract_param() is called with max_length set to the total size of the
output buffer.  It's not safe to allow a parameter length equal to the
buffer size as the terminating null would be written one byte past the
end of the output buffer.

Signed-off-by: Eric Seppanen <eric@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Eric Seppanen
2013-11-20 14:19:51 -08:00
committed by Greg Kroah-Hartman
parent cf516effc7
commit e97f132f0e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/target/iscsi/iscsi_target_nego.c
View File

@@ -90,7 +90,7 @@ int extract_param(
if (len < 0)
return -1;
if (len > max_length) {
if (len >= max_length) {
pr_err("Length of input: %d exceeds max_length:"
" %d\n", len, max_length);
return -1;