shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-02 17:26:42 +09:00
Code Issues Packages Projects Releases Wiki Activity

greybus: firmware: log the name of the firmware being requested

Browse Source 
People are getting confused as to what the firmware file name is for
their module, so log it to make it easier to find modules with "blank"
vid/pid values and let people know what to name their firmware files.

Because we are now logging this, turn the debug message after the
firmware request into an error message if something fails.

Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Reviewed-by: Michael Scott <michael.scott@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Greg Kroah-Hartman
2016-01-20 09:27:05 -08:00
parent ebe99d6181
commit eb8fafdfb9
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/staging/greybus/firmware.c
View File

@@ -88,10 +88,19 @@ static int download_firmware(struct gb_firmware *firmware, u8 stage)
intf->ddbl1_manufacturer_id, intf->ddbl1_product_id,
firmware->vendor_id, firmware->product_id, stage);
// FIXME:
// Turn to dev_dbg later after everyone has valid bootloaders with good
// ids, but leave this as dev_info for now to make it easier to track
// down "empty" vid/pid modules.
dev_info(&connection->bundle->dev, "Firmware file '%s' requested\n",
firmware_name);
rc = request_firmware(&firmware->fw, firmware_name,
&connection->bundle->dev);
dev_dbg(&connection->bundle->dev, "Searched for TFTF %s: %d\n",
firmware_name, rc);
if (rc)
dev_err(&connection->bundle->dev,
"Firware request for %s has failed : %d",
firmware_name, rc);
return rc;
}