shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-03-31 10:13:04 +09:00
Code Issues Packages Projects Releases Wiki Activity

NFSD: detect mismatch of file handle and delegation stateid in OPEN op

Browse Source 
commit 9c65001c57164033ad08b654c8b5ae35512ddf4a upstream.

When the client sends an OPEN with claim type CLAIM_DELEG_CUR_FH or
CLAIM_DELEGATION_CUR, the delegation stateid and the file handle
must belong to the same file, otherwise return NFS4ERR_INVAL.

Note that RFC8881, section 8.2.4, mandates the server to return
NFS4ERR_BAD_STATEID if the selected table entry does not match the
current filehandle. However returning NFS4ERR_BAD_STATEID in the
OPEN causes the client to retry the operation and therefor get the
client into a loop. To avoid this situation we return NFS4ERR_INVAL
instead.

Reported-by: Petro Pavlov <petro.pavlov@vastdata.com>
Fixes: c44c5eeb2c ("[PATCH] nfsd4: add open state code for CLAIM_DELEGATE_CUR")
Cc: stable@vger.kernel.org
Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dai Ngo
2025-06-10 08:35:28 -07:00
committed by Greg Kroah-Hartman
parent d71abd1ae4
commit f0b89916d2
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
fs/nfsd/nfs4state.c
View File

@@ -5775,6 +5775,20 @@ nfsd4_process_open2(struct svc_rqst *rqstp, struct svc_fh *current_fh, struct nf
status = nfs4_check_deleg(cl, open, &dp);
if (status)
goto out;
if (dp && nfsd4_is_deleg_cur(open) &&
(dp->dl_stid.sc_file != fp)) {
/*
* RFC8881 section 8.2.4 mandates the server to return
* NFS4ERR_BAD_STATEID if the selected table entry does
* not match the current filehandle. However returning
* NFS4ERR_BAD_STATEID in the OPEN can cause the client
* to repeatedly retry the operation with the same
* stateid, since the stateid itself is valid. To avoid
* this situation NFSD returns NFS4ERR_INVAL instead.
*/
status = nfserr_inval;
goto out;
}
stp = nfsd4_find_and_lock_existing_open(fp, open);
} else {
open->op_file = NULL;