shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-10 21:07:02 +09:00
Code Issues Packages Projects Releases Wiki Activity

net: stmmac: The netif_device_attach() should be called after napi_enable()

Browse Source 
If the netif_device_attach() is called earlier, the state of dev_queue is
waked, txtimer might be modified, and the txtimer is added at same time.
It might make run_timer_softirq crashed, because the timer is be detached
twice together.

Change-Id: I31dde4e940bddcc36372ca1f4a8313c0389d4e6b
Signed-off-by: David Wu <david.wu@rock-chips.com>
This commit is contained in:
David Wu
2017-04-28 17:41:43 +08:00
committed by Tao Huang
parent a493c7f14f
commit fa3b8e0c40
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
View File

@@ -4566,8 +4566,6 @@ int stmmac_resume(struct device *dev)
stmmac_mdio_reset(priv->mii);
}
netif_device_attach(ndev);
mutex_lock(&priv->lock);
stmmac_reset_queues_param(priv);
@@ -4582,6 +4580,8 @@ int stmmac_resume(struct device *dev)
stmmac_start_all_queues(priv);
netif_device_attach(ndev);
mutex_unlock(&priv->lock);
if (ndev->phydev)