shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-07 11:26:02 +09:00
Code Issues Packages Projects Releases Wiki Activity

nand: fix the free-node leak in rsv manager [1/1]

Browse Source 
PD#SWPL-2776

Problem:
did not release the free node of rsv information

Solution:
release free node and set bit mask in right way

Verify:
S400

Change-Id: I781f2374b91ca1e7cd1a66e75fc554318737c377
Signed-off-by: Yi Zeng <yi.zeng@amlogic.com>
This commit is contained in:
Yi Zeng
2018-12-10 15:57:18 +08:00
committed by Dongjin Kim
parent 99b4eeac49
commit fbd010d178
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/amlogic/mtd/rsv_manage.c
View File

@@ -42,16 +42,14 @@ static struct free_node_t *get_free_node(struct mtd_info *mtd)
pr_info("%s %d: bitmap=%llx\n", __func__, __LINE__,
aml_chip->freeNodeBitmask);
index = find_first_zero_bit((void *)&aml_chip->freeNodeBitmask, 64);
index = find_first_zero_bit((void *)&aml_chip->freeNodeBitmask,
RESERVED_BLOCK_NUM);
if (index > RESERVED_BLOCK_NUM) {
pr_info("%s %d: index is greater than max! error",
__func__, __LINE__);
return NULL;
}
if (test_and_set_bit(index, (void *)&aml_chip->freeNodeBitmask)) {
pr_info("%s %d: error!!!\n", __func__, __LINE__);
return NULL;
}
WARN_ON(test_and_set_bit(index, (void *)&aml_chip->freeNodeBitmask));
pr_info("%s %d: bitmap=%llx\n", __func__, __LINE__,
aml_chip->freeNodeBitmask);
@@ -73,9 +71,8 @@ static void release_free_node(struct mtd_info *mtd,
pr_info("%s %d: index=%d is greater than max! error",
__func__, __LINE__, free_node->index);
if (test_and_clear_bit(free_node->index,
(void *)&aml_chip->freeNodeBitmask))
return;
WARN_ON(!test_and_clear_bit(free_node->index,
(void *)&aml_chip->freeNodeBitmask));
/*memset zero to protect from dead-loop*/
memset(free_node, 0, sizeof(struct free_node_t));