shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-07 19:30:30 +09:00
Code Issues Packages Projects Releases Wiki Activity

smartcard: fix defects for coverity [1/1]

Browse Source 
PD#166793

Problem:
conditional statement not is valid.

Solution:
change type u32 to type int.

Verify:
module owner confirmed.

Change-Id: I9fdfa444b29104c7afc9b7a380748ebe82ed390b
Signed-off-by: Jianxiong Pan <jianxiong.pan@amlogic.com>
This commit is contained in:
Jianxiong Pan
2018-11-09 17:02:52 +08:00
committed by Dongjin Kim
parent 2174cc7fc3
commit fdde80878f
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/amlogic/smartcard/smartcard.c
View File

@@ -339,7 +339,7 @@ struct smc_dev {
#define SMC_ENABLE_5V3V_PIN_NAME "smc:5V3V"
int enable_5v3v_level;
int (*reset)(void*, int);
u32 irq_num;
int irq_num;
int reset_level;
u32 pin_clk_pinmux_reg;
@@ -1847,8 +1847,12 @@ static int smc_dev_init(struct smc_dev *smc, int id)
if (IS_ERR(smc->pinctrl))
return -1;
of_property_read_string(smc->pdev->dev.of_node,
ret = of_property_read_string(smc->pdev->dev.of_node,
"smc_need_enable_pin", &dts_str);
if (ret < 0) {
pr_error("failed to get smartcard node.\n");
return -EINVAL;
}
if (strcmp(dts_str, "yes") == 0)
smc->use_enable_pin = 1;
else