shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-06 19:08:57 +09:00
Code Issues Packages Projects Releases Wiki Activity

fiq_debugger: fix bt bug when EL0_SP is 0xffffff8000000000

Browse Source 
Bt command think if EL0_SP is less than 0xffffffcxxxxxxxxx
 it is user mode, but EL0_SP may be 0xffffff8xxxxxxxxx.
According to ARM-V8, the virtual address bit63 determine
TTBR0 OR TTBR1. So if EL0_SP is less than 0x8000000000000000,
it is user mode.

Signed-off-by: Huibin Hong <huibin.hong@rock-chips.com>
Change-Id: Ib97b405df6e669e3806161c97801847e2f5d247a
This commit is contained in:
Huibin Hong
2021-11-15 03:09:59 +00:00
committed by Tao Huang
parent bd5f70e66c
commit fef814f8c8
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/staging/android/fiq_debugger/fiq_debugger.c
View File

@@ -632,13 +632,7 @@ static bool fiq_debugger_fiq_exec(struct fiq_debugger_state *state,
void *svc_sp)
{
bool signal_helper = false;
unsigned long va_start;
#ifdef CONFIG_ARM64
va_start = PAGE_END;
#else
va_start = PAGE_OFFSET;
#endif
if (!strcmp(cmd, "help") || !strcmp(cmd, "?")) {
fiq_debugger_help(state);
} else if (!strcmp(cmd, "pc")) {
@@ -649,9 +643,14 @@ static bool fiq_debugger_fiq_exec(struct fiq_debugger_state *state,
fiq_debugger_dump_allregs(&state->output, regs);
#ifndef CONFIG_FIQ_DEBUGGER_MODULE
} else if (!strcmp(cmd, "bt")) {
/*
* ARM64:
* Cpu is at ELx(1 or 2), but EL0_SP(svc_sp) may be user space.
* If EL0_SP.63 is 0, use TTBR0.
*/
if (user_mode((struct pt_regs *)regs) ||
((unsigned long)svc_sp < va_start) ||
((unsigned long)svc_sp > -256UL))
(IS_ENABLED(CONFIG_ARM64) && (((unsigned long)svc_sp & 0x8000000000000000) == 0)) ||
(IS_ENABLED(CONFIG_ARM) && (((unsigned long)svc_sp < PAGE_OFFSET) || ((unsigned long)svc_sp > -256UL))))
fiq_debugger_printf(&state->output, "User mode\n");
else
fiq_debugger_dump_stacktrace(&state->output, regs,