Nishka Dasgupta
02433a24fe
staging: rtl8712: r8712_free_drv_sw(): Change return type
...
Change return type of r8712_free_drv_sw from u8 to void and remove its
return statement as it always returns the same value (_SUCCESS) and even
this value is never stored, checked or otherwise used.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190808064012.12661-8-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-08 19:58:15 +02:00
Nishka Dasgupta
690407fdc9
staging: rtl8712: init_drv_sw(): Change return values
...
Change return values of init_drv_sw from _SUCCESS and _FAIL to 0 and
-ENOMEM. Change return type from u8 to int to allow this.
Add a return variable to streamline return of error codes of called
functions.
Modify call site to check for non-zero return value instead of _FAIL.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190808064012.12661-7-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-08 19:58:15 +02:00
Nishka Dasgupta
30d83c801d
staging: rtl8712: init_default_value(): Change return type
...
Change return type of init_default_value from u8 to void as it always
returns _SUCCESS. Remove now-unnecessary return statement.
Modify call site to simply call the function.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190808064012.12661-6-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-08 19:58:14 +02:00
Nishka Dasgupta
9dca5e687f
staging: rtl8712: recvbuf2recvframe(): Change return type
...
Change return type of recvbuf2recvframe from int to void as its return
value is never used. Modify or remove return statements accordingly.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190808064012.12661-5-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-08 19:58:14 +02:00
Nishka Dasgupta
af556d30d3
staging: rtl8712: r8712_recv_entry(): Change return type
...
Change return type of r8712_recv_entry from s32 to void as its return
value is never used. Modify or remove return statements accordingly.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190808064012.12661-4-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-08 19:58:14 +02:00
Nishka Dasgupta
1bdcb3666a
staging: rtl8712: r8712_wlanhdr_to_ethhdr(): Change return values
...
Change return values of r8712_wlanhdr_to_ethhdr from _SUCCESS/_FAIL to
0/-ENOMEM. Modify the function containing a call site of
r8712_wlanhdr_to_ethhdr so that it compares the return value to
0/-ENOMEM instead of _SUCCESS/_FAIL.
Change the return type of r8712_wlanhdr_to_ethhdr from sint to int to
match its prototype in corresponding .h file.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190808064012.12661-3-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-08 19:58:14 +02:00
Nishka Dasgupta
4dbadfaf6a
staging: rtl8712: recv_indicatepkt_reorder(): Change return values
...
Change return values of recv_indicatepkt_reorder from _SUCCESS/_FAIL to
0/-ENOMEM and -EINVAL.
Within recv_indicatepkt_reorder, modify comparison to true and use the
respective value directly.
Modify call site of recv_indicatepkt_reorder to check for the new return
values.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190808064012.12661-2-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-08 19:58:14 +02:00
Nishka Dasgupta
fc898688aa
staging: rtl8712: amsdu_to_msdu(): Change return type
...
Change return type of amsdu_to_msdu from int to void as it always
returns _SUCCESS. Remove return statement as well.
As this return value was never anything other than _SUCCESS, remove the
if-branch that depends on the return value not being _SUCCESS.
Remove local variable that was only used in the now-removed if-branch
Modify call site to call the function amsdu_to_msdu without expecting
a return value.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190808064012.12661-1-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-08 19:58:14 +02:00
Jose Carlos Cazarin Filho
a9ca0c5951
staging: rtl8723bs: fix brace position in enum declaration
...
Fix two checkpath errors of type:
"open brace '{' following enum go on the same line"
Signed-off-by: Jose Carlos Cazarin Filho <joseespiriki@gmail.com >
Link: https://lore.kernel.org/r/20190806234539.7513-1-joseespiriki@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-08 18:59:19 +02:00
Giridhar Prasath R
5222a8fe6b
staging: isdn: hysdn_procconf_init() remove parantheses from return value
...
ERROR: return is not a function, parentheses are not required
FILE: git/kernels/staging/drivers/staging/isdn/hysdn/hysdn_procconf.c:385
+ return (0);
Signed-off-by: Giridhar Prasath R <cristianoprasath@gmail.com >
Link: https://lore.kernel.org/r/20190807020331.19729-1-cristianoprasath@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-08 18:59:19 +02:00
Merwin Trever Ferrao
4f4139e021
Staging: rtl8188eu: core: rtw_security: tidy up crc32_init()
...
This code generates checkpatch warning:
WARNING: else is not generally useful after a break or return
Moving the declaration to the top of the function we can pull the
code back one tab and it makes it more readable.
Signed-off-by: Merwin Trever Ferrao <merwintf@gmail.com >
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Link: https://lore.kernel.org/r/20190806122849.GA25628@IoT-COE
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-08 18:59:18 +02:00
Ajay Singh
b0d525a007
staging: wilc1000: use helper API to pack data for firmware
...
As discussed in [1] use put_unaligned_le16() & put_unaligned_le32()
helper to pack the data before sending to firmware.
[1]. https://lore.kernel.org/linux-wireless/86bc79ccd379497d56bade79ec8f717603110ef7.camel@sipsolutions.net/
Signed-off-by: Ajay Singh <ajay.kathat@microchip.com >
Link: https://lore.kernel.org/r/20190806103325.14063-1-ajay.kathat@microchip.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-08 18:59:18 +02:00
Hariprasad Kelam
36d042bd68
staging: rtl8192e: Make use kmemdup
...
As kmemdup API does kmalloc + memcpy . We can make use of it instead of
calling kmalloc and memcpy independetly.
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com >
Link: https://lore.kernel.org/r/20190804024832.GA14352@hari-Inspiron-1545
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-05 17:11:33 +02:00
Saurav Girepunje
d8ba499d53
staging: rtl8723bs: core: add spaces around '-', '+', '&','|' and '?'
...
Add spaces around '-', '+', '&','|' and '?' to improve readability
and follow kernel coding style in rtw_ap.c
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com >
Link: https://lore.kernel.org/r/20190803192551.GA24041@saurav
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-05 17:09:49 +02:00
Saurav Girepunje
67ca96bbd0
staging: rtl8723bs: core: Remove Unnecessary parentheses
...
Remove Unnecessary parentheses around padapter->mlmepriv,
pmlmeext->mlmext_info and pmlmeinfo->network in rtw_ap.c
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com >
Link: https://lore.kernel.org/r/20190803184750.GA23507@saurav
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-05 17:09:49 +02:00
Saurav Girepunje
783f9a6a2d
staging: rtl8723bs: core: correct spelling mistake in rtw_ap.c
...
Correct spelling mistake in rtw_ap.c
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com >
Link: https://lore.kernel.org/r/20190803183051.GA23151@saurav
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-05 17:09:49 +02:00
Saurav Girepunje
fe4e6e0368
staging: rtl8188eu: core: add spaces around '-', '+', '>>','<<' and '*' in rtw_efuse.c
...
Add spaces around '-', '+', '>>','<<' and '*' to improve readability
and follow kernel coding style.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com >
Link: https://lore.kernel.org/r/20190803131839.GA14077@saurav
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-05 17:09:48 +02:00
Marco Villegas
9fd827c699
staging: rtl8712: Add spaces around <<
...
Fix checkpatch error "CHECK: spaces preferred around that '<<'".
Signed-off-by: Marco Villegas <git@marvil07.net >
Link: https://lore.kernel.org/r/20190802194737.12252-1-git@marvil07.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-03 09:08:00 +02:00
Thiago Bonotto
7cbf010824
staging: isdn: remove unnecessary parentheses
...
Fix the following checkpatch error:
ERROR: return is not a function, parentheses are not required
FILE: drivers/staging/isdn/hysdn/hysdn_net.c:289:
+ return (0); /* and return success */
Signed-off-by: Thiago Bonotto <thbonotto@gmail.com >
Link: https://lore.kernel.org/r/20190802202323.27117-1-thbonotto@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-03 09:08:00 +02:00
Saurav Girepunje
8ca9d8ad30
staging: rtl8188eu: core: rtw_recv.c: Remove Unnecessary parentheses
...
Remove Unnecessary parentheses around precvframe->list,
pmlmeext->mlmext_info and precvpriv->free_recv_queue
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com >
Link: https://lore.kernel.org/r/20190803064408.GA30111@saurav
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-03 09:08:00 +02:00
Nishka Dasgupta
b35105a3a3
staging: rtl8712: r8712_aes_decrypt(): Change return type
...
Change return type of r8712_aes_decrypt from u8 to void as its return
value is never checked. Modify return statements accordingly.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190802064212.30476-9-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 14:00:57 +02:00
Nishka Dasgupta
eb43590f50
staging: rtl8712: aes_decipher(): Change return type
...
Change return type of aes_decipher from sint to void as it always
returns _SUCCESS and this value is never used.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190802064212.30476-8-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 14:00:57 +02:00
Nishka Dasgupta
e48a3add05
staging: rtl8712: aes_cipher(): Change return type
...
Change return type of aes_cipher from sint to void as it always returns
_SUCCESS and its return value is never used.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190802064212.30476-7-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 14:00:56 +02:00
Nishka Dasgupta
f8dbe3f0ac
staging: rtl8712: r8712_tkip_decrypt(): Change return type
...
Change return type of r8712_tkip_decrypt from u8 to void as the
return value is never used. Modify or remove return statements
accordingly.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190802064212.30476-6-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 14:00:56 +02:00
Nishka Dasgupta
dcca75a495
staging: rtl8712: r8712_os_recvbuf_resource_free(): Change return type
...
Change return type of r8712_os_recvbuf_resource_free from int to void as
it always returns _SUCCESS and this return value is never stored,
checked or otherwise used. Remove return statement accordingly.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190802064212.30476-5-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 14:00:56 +02:00
Nishka Dasgupta
14b4302ff0
staging: rtl8712: r8712_os_recvbuf_resource_alloc(): Change return values
...
Change return values of r8712_os_recvbuf_resource_alloc from
_SUCCESS/_FAIL to 0/-ENOMEM respectively.
Modify check at call site to check for non-zero return value instead of
_FAIL. Thereafter remove variable at call site that stored the return
value and perform the check directly.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190802064212.30476-4-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 14:00:56 +02:00
Nishka Dasgupta
0bf36e6052
staging: rtl8712: r8712_init_recv_priv(): Change return type
...
Change return type of r8712_init_recv_priv from int to void as its
return value is never used. Remove return statements accordingly.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190802064212.30476-3-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 14:00:56 +02:00
Nishka Dasgupta
1ce0212ab8
staging: rtl8712: _r8712_init_recv_priv(): Change return type
...
Change return type of _r8712_init_recv_priv as its return value is never
checked or used. Modify return statements accordingly.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190802064212.30476-2-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 14:00:56 +02:00
Nishka Dasgupta
a0afad481b
staging: rtl8712: r8712_os_recv_resource_alloc(): Change return type
...
Change return type of function r8712_os_recv_resource_alloc from int to
void as its return value is never used.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190802064212.30476-1-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 14:00:55 +02:00
Nishka Dasgupta
6250a57e6c
staging: rtl8723bs: Replace hal_btcoex_Initialize()
...
Remove hal_btcoex_Initialize as all it does is perform a memset and call
EXhalbtcoutsrc_InitlizeVariables.
Rename EXhalbtcoutsrc_InitlizeVariables to hal_btcoex_Initialize and add
the memset of hal_btcoex_Initialize in order to maintain compatibility
with call sites of the latter (EXhalbtcoutsrc is not called anywhere
else except in now-removed old hal_btcoex_Initialize).
Change return type of new hal_btcoex_Initialize from u8 to void and
remove its return statement as the return value of hal_btcoex_Initialize
is never used.
Change the type of function argument at call site to match the function
parameter of new hal_btcoex_Initialize.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190802062444.30384-4-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:59:53 +02:00
Nishka Dasgupta
365231fcd6
staging: rtl8723bs: Change return type of hal_btcoex_IsLpsOn()
...
Change return type of hal_btcoex_IsLpsOn from u8 to bool as the
function only returns boolean values.
Modify a comparison of a boolean value to false to instead check that
boolean value directly.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190802062444.30384-3-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:59:53 +02:00
Nishka Dasgupta
84881dd37b
staging: rtl8723bs: Change return type of hal_btcoex_IsBtControlLps()
...
Change return type of hal_btcoex_IsBtControlLps from u8 to bool as it
only returns boolean values.
Change comparison to false within this function; check the boolean
variable directly instead.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190802062444.30384-2-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:59:52 +02:00
Nishka Dasgupta
42755adcce
staging: rtl8723bs: Change return type of hal_btcoex_IsBtExist()
...
Change return type of hal_btcoex_IsBtExist from u8 to bool as its only
possible return values are true and false.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190802062444.30384-1-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:59:52 +02:00
Adham Abozaeid
9104688c32
staging: wilc1000: remove unused function
...
function wilc_resolve_disconnect_aberration isn't referenced, so
removing it
Signed-off-by: Adham Abozaeid <adham.abozaeid@microchip.com >
Link: https://lore.kernel.org/r/20190801200909.12605-3-adham.abozaeid@microchip.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:58:11 +02:00
Adham Abozaeid
4b1b8b08ab
staging: wilc1000: merge drv_handle and operation_mode wids
...
wilc_set_wfi_drv_handler and wilc_set_operation_mode sends the same
parameters to the FW, so it's better to combine them together.
Kept wilc_set_wfi_drv_handler implementation since it sends all the
required parameters, and renamed it to wilc_set_operation_mode to be
more descriptive.
Signed-off-by: Adham Abozaeid <adham.abozaeid@microchip.com >
Link: https://lore.kernel.org/r/20190801200909.12605-2-adham.abozaeid@microchip.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:56:59 +02:00
Nishka Dasgupta
b7a40c32f1
staging: wlan-ng: Remove function prism2mib_excludeunencrypted()
...
Remove function prism2mib_excludeunencrypted as all it does is call
prism2mib_flag.
Modify call sites accordingly.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com >
Link: https://lore.kernel.org/r/20190802060913.30241-1-nishkadg.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:55:38 +02:00
Geert Uytterhoeven
129d0561a3
staging: bcm2835-camera: Spelling s/conencted/connected/
...
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be >
Link: https://lore.kernel.org/r/20190731134207.18549-1-geert+renesas@glider.be
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:55:38 +02:00
Wei Yongjun
a5589269e6
staging: fsl-dpaa2/ethsw: Remove useless set memory to zero use memset()
...
The memory return by kzalloc() has already be set to zero, so remove
useless memset(0).
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com >
Link: https://lore.kernel.org/r/20190802013149.80952-1-weiyongjun1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:55:38 +02:00
Gao Xiang
0b800f3dba
staging: erofs: update Kconfig
...
Keep in line with erofs-outofstaging patchset:
- turn on CONFIG_EROFS_FS_ZIP by default;
- turn on CONFIG_EROFS_FS_SECURITY by default suggested by David;
- update Kconfig description.
Reviewed-by: Chao Yu <yuchao0@huawei.com >
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com >
Link: https://lore.kernel.org/r/20190731155752.210602-23-gaoxiang25@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:52:08 +02:00
Gao Xiang
bc33d9f35d
staging: erofs: update super.c
...
Keep in line with erofs-outofstaging patchset:
- "Chao Yu" is most commonly used in Linux community;
- quoted string split across lines.
Reviewed-by: Chao Yu <yuchao0@huawei.com >
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com >
Link: https://lore.kernel.org/r/20190731155752.210602-22-gaoxiang25@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:52:08 +02:00
Gao Xiang
2bb90cc275
staging: erofs: tidy up utils.c
...
Keep in line with erofs-outofstaging patchset:
- Update comments in erofs_try_to_release_workgroup;
- code style cleanup.
Reviewed-by: Chao Yu <yuchao0@huawei.com >
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com >
Link: https://lore.kernel.org/r/20190731155752.210602-21-gaoxiang25@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:52:08 +02:00
Gao Xiang
4279f3f988
staging: erofs: turn cache strategies into mount options
...
Kill all kconfig cache strategies and turn them into mount options
"cache_strategy={disable|readahead|readaround}".
As the first step, cached pages can still be usable after cache
is disabled by remounting, and these pages will be fallen out
over time, which can be refined in the later version if some
requirement is needed. Update related document as well.
Suggested-by: Theodore Ts'o <tytso@mit.edu >
Reviewed-by: Chao Yu <yuchao0@huawei.com >
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com >
Link: https://lore.kernel.org/r/20190731155752.210602-20-gaoxiang25@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:52:07 +02:00
Gao Xiang
eace994a11
staging: erofs: remove clusterbits in sbi
...
clustersize can now be set on per-file basis
rather than per-filesystem basis.
Reviewed-by: Chao Yu <yuchao0@huawei.com >
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com >
Link: https://lore.kernel.org/r/20190731155752.210602-19-gaoxiang25@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:52:07 +02:00
Gao Xiang
97e86a858b
staging: erofs: tidy up decompression frontend
...
Although this patch has an amount of changes, it is hard to
separate into smaller patches.
Most changes are due to structure renaming for better understand
and straightforward,
z_erofs_vle_workgroup to z_erofs_pcluster
since it represents a physical cluster;
z_erofs_vle_work to z_erofs_collection
since it represents a collection of logical pages;
z_erofs_vle_work_builder to z_erofs_collector
since it's used to fill z_erofs_{pcluster,collection}.
struct z_erofs_vle_work_finder has no extra use compared with
struct z_erofs_collector, delete it.
FULL_LENGTH bit is integrated into .length of pcluster so that it
can be updated with the corresponding length change in atomic.
Minor, add comments for better description.
Reviewed-by: Chao Yu <yuchao0@huawei.com >
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com >
Link: https://lore.kernel.org/r/20190731155752.210602-18-gaoxiang25@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:52:07 +02:00
Gao Xiang
febde7b3ac
staging: erofs: remove redundant braces in inode.c
...
Remove redundant braces in inode.c
since these are all single statements.
Reviewed-by: Chao Yu <yuchao0@huawei.com >
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com >
Link: https://lore.kernel.org/r/20190731155752.210602-17-gaoxiang25@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:52:07 +02:00
Gao Xiang
046d64e118
staging: erofs: tidy up zpvec.h
...
- use shorter function names:
z_erofs_pagevec_enqueue and z_erofs_pagevec_dequeue;
- minor code cleanup.
In order to keep in line with erofs-outofstaging patchset.
Reviewed-by: Chao Yu <yuchao0@huawei.com >
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com >
Link: https://lore.kernel.org/r/20190731155752.210602-16-gaoxiang25@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:52:06 +02:00
Gao Xiang
46c2d14943
staging: erofs: kill CONFIG_EROFS_FS_USE_VM_MAP_RAM
...
Turn into a module parameter ("use_vmap") as it
can be set at runtime.
Suggested-by: David Sterba <dsterba@suse.cz >
Reviewed-by: Chao Yu <yuchao0@huawei.com >
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com >
Link: https://lore.kernel.org/r/20190731155752.210602-15-gaoxiang25@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:52:06 +02:00
Gao Xiang
b25a15191c
staging: erofs: refine erofs_allocpage()
...
remove duplicated code in decompressor by introducing
failable erofs_allocpage().
Reviewed-by: Chao Yu <yuchao0@huawei.com >
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com >
Link: https://lore.kernel.org/r/20190731155752.210602-14-gaoxiang25@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:52:06 +02:00
Gao Xiang
8494c29ffe
staging: erofs: drop __GFP_NOFAIL for managed inode
...
For historical reasons, __GFP_NOFAIL was set for managed inode.
It's no need using that since EROFS can handle it properly.
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com >
Reviewed-by: Chao Yu <yuchao0@huawei.com >
Link: https://lore.kernel.org/r/20190731155752.210602-13-gaoxiang25@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:52:06 +02:00
Gao Xiang
8f7acdae2c
staging: erofs: kill all failure handling in fill_super()
...
.kill_sb() will do that instead in order to remove duplicated code.
Note that the initialzation of managed_cache is now moved
after s_root is assigned since it's more preferred to iput()
in .put_super() and all inodes should be evicted before
the end of generic_shutdown_super(sb).
Suggested-by: Al Viro <viro@zeniv.linux.org.uk >
Reviewed-by: Chao Yu <yuchao0@huawei.com >
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com >
Link: https://lore.kernel.org/r/20190731155752.210602-12-gaoxiang25@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2019-08-02 13:52:05 +02:00