Tian Tao
07ff20cf17
staging: fieldbus: simplify devm_anybuss_host_common_probe
...
Use devm_add_action_or_reset() instead of devres_alloc() and
devres_add(), which works the same. This will simplify the
code. There is no functional changes.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com >
Link: https://lore.kernel.org/r/1618275183-56792-1-git-send-email-tiantao6@hisilicon.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-13 09:53:41 +02:00
Mitali Borkar
cc444aa522
staging: rtl8192e: remove unnecessary ftrace-like logging
...
Removed unncessary ftrace-like logging by simply deleting that statement
as we have other modes of logging like ftrace.
Reported by checkpatch.
Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com >
Link: https://lore.kernel.org/r/460ba9cdd256bf1064c4e3a694caa046171cb60e.1618283232.git.mitaliborkar810@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-13 09:52:26 +02:00
Bryan Brattlof
59bc0e634b
staging: rtl8723bs: remove unnecessary adapter
...
The if2 adapter is defined in rtw_dvr_init() and in the dvobj_priv
structure but never used anywhere in the driver. This will remove all
definitions of if2
Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com >
Link: https://lore.kernel.org/r/20210412172147.43509-1-hello@bryanbrattlof.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-13 09:49:48 +02:00
Beatriz Martins de Carvalho
1ec0ee058d
staging: rtl8723bs: hal: Correct indentation
...
Correct random indentation to improve readability. This problem
was observed when working on other checkpatch reports in the
file Hal8723BReg.h
Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com >
Link: https://lore.kernel.org/r/68e91c54a3be0b57607101fa8b284c00bb7dff1a.1618243073.git.martinsdecarvalhobeatriz@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-13 09:49:33 +02:00
Beatriz Martins de Carvalho
8b7d276ea8
staging: rtl8723bs: hal: Remove extra blank line
...
Remove multiple blank lines to conform Linux kernel coding style.
Reported by checkpatch in file Hal8723BReg.h
Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com >
Link: https://lore.kernel.org/r/7f48b48d92b54c1f5db29f0d23c8c1c666236c43.1618243073.git.martinsdecarvalhobeatriz@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-13 09:49:33 +02:00
Beatriz Martins de Carvalho
ac23a3cbcd
staging: rtl8723bs: hal: remove space before tabs
...
Remove unnecessary space before tabs to conform with Linux kernel
coding style.
Reported by checkpatch in file Hal8723BReg.h
Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com >
Link: https://lore.kernel.org/r/9694aafb614bdcbb15fdea614502c1b31a534871.1618243073.git.martinsdecarvalhobeatriz@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-13 09:49:33 +02:00
Mitali Borkar
c9d134a13b
staging: vc04_services: TODO: rectify spelling mistake
...
Corrected the misspelled word.
Reported by checkpatch.
Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com >
Link: https://lore.kernel.org/r/967c328610909bc010b0bb82a1f89b71a57fa7a3.1618223171.git.mitaliborkar810@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-13 09:47:55 +02:00
Mitali Borkar
70bdf4cc49
staging: vc04_services: TODO: remove trailing whitespace
...
Removed trailing whitespace to adhere to linux kernel coding style.
Reported by checkpatch.
Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com >
Link: https://lore.kernel.org/r/5a54a06bae846f1f037165c0c7ba7ffe5a55a4a8.1618223171.git.mitaliborkar810@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-13 09:47:50 +02:00
Stefan Wahren
f2f560e1bd
staging: vchiq_core: split exit conditions
...
Some exit conditions are rather complex. So better split them up.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com >
Link: https://lore.kernel.org/r/1618164700-21150-11-git-send-email-stefan.wahren@i2se.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:41:22 +02:00
Stefan Wahren
fa80183c55
staging: vchiq_core: fix if alignments
...
This fixes the alignment of some if statements.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com >
Link: https://lore.kernel.org/r/1618164700-21150-10-git-send-email-stefan.wahren@i2se.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:41:22 +02:00
Stefan Wahren
a8def5034a
staging: vchiq_core: introduce SLOT_QUEUE_INDEX_FROM_POS_MASKED
...
Define a macro which already masked the result of SLOT_QUEUE_INDEX_FROM_POS.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com >
Link: https://lore.kernel.org/r/1618164700-21150-9-git-send-email-stefan.wahren@i2se.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:41:22 +02:00
Stefan Wahren
7a4da84ce8
staging: vchiq_core: use BITSET_WORD macro
...
Use this macro to make the index retrieval less opaque.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com >
Link: https://lore.kernel.org/r/1618164700-21150-8-git-send-email-stefan.wahren@i2se.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:41:22 +02:00
Stefan Wahren
0e345d9773
staging: vchiq_core: improve readability of request_poll
...
Storing the index for poll services in a local var will increase the
readability of the second loop. Also we get the rid off the checkpatch
issue about the line ending with a square bracket.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com >
Link: https://lore.kernel.org/r/1618164700-21150-7-git-send-email-stefan.wahren@i2se.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:41:22 +02:00
Stefan Wahren
63276d45ba
staging: vchiq_core: introduce service skip
...
In case there is no service pointer provided, we can skip these polling.
Use a goto to reduce the indentation, which is necessary for the following
patches. Btw fix the brace alignment of the loops.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com >
Link: https://lore.kernel.org/r/1618164700-21150-6-git-send-email-stefan.wahren@i2se.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:41:22 +02:00
Stefan Wahren
b3582ed426
staging: vchiq_core: Exit early in 2 functions
...
Exit early allow us to reduce the indention in vchiq_open_service_internal()
and vchiq_set_service_option(). Btw we can avoid the multi-line assignments
of quota.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com >
Link: https://lore.kernel.org/r/1618164700-21150-5-git-send-email-stefan.wahren@i2se.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:41:22 +02:00
Stefan Wahren
32129ec093
staging: vchiq_core: Get the rid off curly braces around cases
...
Additional curly braces around cases are a bit harder to read. So
change the scope of service quota to get the rid off those braces.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com >
Link: https://lore.kernel.org/r/1618164700-21150-4-git-send-email-stefan.wahren@i2se.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:41:21 +02:00
Stefan Wahren
e04e900830
staging: vchiq_core: Shorten var name for service quota
...
Readibility and following clean-ups will benefit from the shorter name.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com >
Link: https://lore.kernel.org/r/1618164700-21150-3-git-send-email-stefan.wahren@i2se.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:41:21 +02:00
Stefan Wahren
acdb1d908f
staging: vchiq_core: Simplify vchiq_send_remote_use*
...
There is no need for variable status. So drop it and improve readability.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com >
Link: https://lore.kernel.org/r/1618164700-21150-2-git-send-email-stefan.wahren@i2se.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:41:21 +02:00
Mitali Borkar
8333e5a958
staging: rts5208: remove unnecessary ftrace-like logging
...
Removed unnecessary ftrace-like logging by simply deleting that statement
as we have other modes of logging like ftrace.
Reported by checkpatch.
Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com >
Link: https://lore.kernel.org/r/YHMy457UGosfeaC0@kali
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:40:13 +02:00
Fabio Aiuto
5a04ad1d1d
staging: rtl8723bs: remove unused variable 'start' in hal/sdio_halinit.c
...
fix following W=1 compiler issue:
drivers/staging/rtl8723bs/hal/sdio_halinit.c:
In function '_ReadAdapterInfo8723BS':
drivers/staging/rtl8723bs/hal/sdio_halinit.c:1156:16:
warning: variable 'start' set but not used [-Wunused-but-set-variable]
1156 | unsigned long start;
| ^~~~~
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/ce1faa15052b519738656e11658dee93f9e91c29.1618145345.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:39:20 +02:00
Bryan Brattlof
a2e2a05d5d
staging: rtl8723bs: remove unnecessary goto jumps
...
The next instruction for both 'goto exit' jump statements is to
execute the exit jump instructions regardless. We can safely
remove all jump statements from __init rtw_drv_entry()
Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com >
Link: https://lore.kernel.org/r/20210411133625.38195-1-hello@bryanbrattlof.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:38:00 +02:00
Dmitrii Wolf
9e74999b1a
Staging: rtl8192u: ieee80211: remove odd backslash.
...
This backslash should be deleted - looks like leftover and not needed.
Signed-off-by: Dmitrii Wolf <dev.dragon@bk.ru >
Link: https://lore.kernel.org/r/20210411120301.6549-1-dev.dragon@bk.ru
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:37:47 +02:00
Fabio M. De Francesco
16ae2044e9
staging: rtl8723bs: Change controlling expressions
...
Change controlling expressions within 'if' statements: don't compare
with 'true'.
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com >
Link: https://lore.kernel.org/r/20210411110458.15955-5-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:37:15 +02:00
Fabio M. De Francesco
13c57439fe
staging: rtl8723bs: include: Change the type of a variable
...
Change the type of fw_current_in_ps_mode from u8 to bool, because
it is used everywhere as a bool and, accordingly, it should be
declared as a bool.
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com >
Link: https://lore.kernel.org/r/20210411110458.15955-4-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:37:15 +02:00
Fabio M. De Francesco
97f136ec59
staging: rtl8723bs: include: Fix misspelled words in comments
...
Correct misspelled words in comments of several files. Issue (largely)
detected by checkpatch.pl.
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com >
Link: https://lore.kernel.org/r/20210411110458.15955-3-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:37:15 +02:00
Fabio M. De Francesco
90b69822a5
staging: rtl8723bs: Remove camelcase in several files
...
Remove camelcase in bFwCurrentInPSMode, a variable used by code
of several subdirectories/files of the driver. Issue detected by
checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from
the beginning of the name.
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com >
Link: https://lore.kernel.org/r/20210411110458.15955-2-fmdefrancesco@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-12 11:37:15 +02:00
Fabio Aiuto
1b9e18de8d
staging: rtl8723bs: remove more empty if blocks after DBG_8192C deletion
...
remove more empty if-blocks after DBG_8192C deletion.
Reported-by: kernel test robot <lkp@intel.com >
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/99b111d2bac822b9dc7ff6e1cfd3d3efc62ef836.1618064275.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:03 +02:00
Fabio Aiuto
d6b08255f8
staging: rtl8723bs: remove more unnecessary parentheses
...
remove more unnecessary parentheses after
DBG_8192C deletion.
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/c730d2719cb2ed385dd55811d6e205c6c31f2355.1618064275.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:03 +02:00
Fabio Aiuto
1e95e1e49a
staging: rtl8723bs: fix comparison to true issue
...
fix following post-commit hook checkpatch issue:
CHECK: Using comparison to true is error prone
136: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:
2497:
+ if (psta->dot8021xalg != 1 ||
psta->bpairwise_key_installed == true) {
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/680d86950d760003a694f8880c0a912a9d815a5e.1618064275.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:03 +02:00
Fabio Aiuto
05c19e212a
staging: rtl8723bs: remove empty else block in os_dep/ioctl_cfg80211.c
...
remove empty else-block
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/1bee993834410c2c11a6799e1868589efc1334f6.1618064275.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:03 +02:00
Fabio Aiuto
279fa77760
staging: rtl8723bs: remove unnecessary parentheses in os_dep/ioctl_cfg80211.c
...
fix following post-commit hook checkpatch issue:
WARNING: braces {} are not necessary for single statement blocks
94: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:1225:
+ if (pwdev_priv->scan_request->wiphy == pwdev_priv->rtw_wdev->wiphy)
{
cfg80211_scan_done(pwdev_priv->scan_request, &info);
}
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/fabc590b9f74f687cc0f7ea978577f0357df2974.1618064275.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:03 +02:00
Fabio Aiuto
5bb62a191b
staging: rtl8723bs: put constant on the right side of a test in os_dep/ioctl_cfg80211.c
...
fix following post-commit hook checkpatch issue:
CHECK: Comparison to NULL could be written "psta"
72: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:854:
+ if (psta != NULL) {
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/5ac547f3a4bd228f372da7057bbfb3cac1535857.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:03 +02:00
Fabio Aiuto
da742b02a1
staging: rtl8723bs: remove empty if and else blocks
...
remove if and else blocks after DBG_8192C removal
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/2d2e09d5033bda1ceb77576e582ecf1dcfccf428.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:03 +02:00
Fabio Aiuto
d290bb31a7
staging: rtl8723bs: put constant on the right side of the test
...
fix following post-commit hook checpatch issues:
WARNING: Comparisons should place the constant on the right side of the test
287: FILE: drivers/staging/rtl8723bs/hal/sdio_halinit.c:738:
+ if (_SUCCESS != ret)
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/e19cff736413714dea4265c17b512882d051a311.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:03 +02:00
Fabio Aiuto
4ca39cd745
staging: rtl8723bs: split long line
...
fix following post-commit hook checkpatch issue:
WARNING: line length of 103 exceeds 100 columns
168: FILE: drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:1086:
+ if (efuse_OneByteRead(padapter, efuse_addr, &efuse_data, bPseudoTest) == false)
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/28c078c685059c9b883b563f2c08cfb1d49cb82c.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:03 +02:00
Fabio Aiuto
9d5ed87234
staging: rtl8723bs: put spaces around operators
...
fix following post-commit hook checkpatch issues:
CHECK: spaces preferred around that '+' (ctx:VxV)
87: FILE: drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:746:
+ if ((_offset+_size_byte) > EFUSE_MAX_MAP_LEN)
--
CHECK: spaces preferred around that '+' (ctx:VxV)
105: FILE: drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:847:
+ if ((_offset+_size_byte) > EFUSE_BT_MAP_LEN)
--
CHECK: spaces preferred around that '-' (ctx:VxV)
133: FILE: drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:906:
+ if ((eFuse_Addr-1) < total)
--
CHECK: spaces preferred around that '|' (ctx:VxV)
392: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2485:
+ if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE)) != true)
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/65b7cf4b1ae3cea25a316f3c9f56c697ee7be8af.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:03 +02:00
Fabio Aiuto
71839eac6b
staging: rtl8723bs: fix comparison to null
...
fix following post-commit hook checkpatch issues:
CHECK: Comparison to NULL could be written "!pmlmepriv->wps_probe_req_ie"
348: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:1319:
+ if (pmlmepriv->wps_probe_req_ie == NULL)
CHECK: Comparison to NULL could be written "!dvobj"
459: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:184:
+ if (dvobj == NULL)
CHECK: Comparison to NULL could be written "!padapter"
470: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:231:
+ if (padapter == NULL)
CHECK: Comparison to NULL could be written "!padapter"
481: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:240:
+ if (padapter == NULL)
CHECK: Comparison to NULL could be written "!padapter"
492: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:256:
+ if (padapter == NULL)
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/2c7557a465aeda7fb6989df30c6250f9ec56ebe1.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:03 +02:00
Fabio Aiuto
04c35396c5
staging: rtl8723bs: remove unnecessary bracks
...
remove unnecessary bracks in if-else blocks
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/812e5e0dcb78e49568276237b68dc6f9632c198d.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:02 +02:00
Fabio Aiuto
8f32a6c89c
staging: rtl8723bs: remove commented out DEBUG_CFG80211 symbol definition
...
remove commented out DEBUG_CFG80211 symbol definition.
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/b884ecb5c83c222f0b48839f89e53c45f4489e06.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:02 +02:00
Fabio Aiuto
5ffbfcf38b
staging: rtl8723bs: remove empty ifdef blocks conditioned to DEBUG_CFG80211 definition
...
remove empty ifdef blocks conditioned to DEBUG_CFG80211
definition.
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/7c4485a9d02e8c553c1d81f8b98c8479f481e54c.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:02 +02:00
Fabio Aiuto
8a095d44d8
staging: rtl8723bs: remove commented out SDIO_DEBUG_IO symbol definition
...
remove commented out SDIO_DEBUG_IO symbol definition.
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/7a45b1419bcf4eb2abc25d661acae77018432e46.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:02 +02:00
Fabio Aiuto
add69c59eb
staging: rtl8723bs: remove code block guarded by undefined SDIO_DEBUG_IO
...
remove code block guarded by SDIO_DEBUG_IO symbol.
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/ee77c4b4e6fbba8e0182e9558f793c88cf398cb5.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:02 +02:00
Fabio Aiuto
96efb46098
staging: rtl8723bs: remove empty code block guarded by DBG_CCX
...
remove code block guarded by DBG_CCX symbol, left empty
after DBG_8192C removal.
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/b9ff4d7f14decf33064c30b307c3b20494aecbb2.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:02 +02:00
Fabio Aiuto
0268c26750
staging: rtl8723bs: remove code blocks guarded by DEBUG symbol
...
remove code blocks guarded by DEBUG symbol
remove undefinition of DEBUG
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/381da3f0c1ddf825b2aa7cbfd074ee2bf42aac4f.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:02 +02:00
Fabio Aiuto
aaf2a07724
staging: rtl8723bs: remove commented out DEBUG_RTL871X definition
...
remove commented out DEBUG_RTL871X definition
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/9d04ab2b645e242e35d31abbb1a301e2ad8c4401.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:02 +02:00
Fabio Aiuto
0a62cc7a5a
staging: rtl8723bs: remove unused code blocks guarded by DEBUG_RTL871X
...
remove unused code blocks guarded by never set DEBUG_RTL871X
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/c7b590b7ae7fad08cd913462ab385db9230ede4d.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:02 +02:00
Fabio Aiuto
fa50dda745
staging: rtl8723bs: put spaces around operators
...
fix following post-commit hook checkpatch issue:
CHECK: spaces preferred around that '+' (ctx:VxV)
89: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2431:
+ rtw_get_wps_ie(pbuf+_FIXED_IE_LENGTH_, ;
^
len-_FIXED_IE_LENGTH_, NULL, &wps_ielen)
CHECK: spaces preferred around that '-' (ctx:VxV)
89: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2431:
+ rtw_get_wps_ie(pbuf+_FIXED_IE_LENGTH_, len-_FIXED_IE_LENGTH_,
^
NULL, &wps_ielen);
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/35c6c5efa2661c6fd9d40c3a681eb8470c5015e6.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:02 +02:00
Fabio Aiuto
edf3967a8d
staging: rtl8723bs: remove all if-blocks left empty by DBG_8192C-remove coccinelle script
...
remove all empty if blocks left empty by coccinelle
script for DBG_8192C macro removal.
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/1676083964fe176e996c2c05dfdcb723b49febb6.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:02 +02:00
Fabio Aiuto
7519f4f896
staging: rtl8723bs: remove DBG_8192C macro definitions
...
remove all DBG_8192C macro definitions.
Macro DBG_8192C belongs to a family of verbose
private tracing macros.
The default behaviour is _do nothing_, to activate
it one should define DEBUG symbol by hand.
So just remove it
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/e7259eeb5927d48a2920548b92dc507befa5e6af.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:02 +02:00
Fabio Aiuto
334ef6ab8f
staging: rtl8723bs: remove all commented out DBG_8192C logs
...
remove all commented out DBG_8192C logs.
Macro DBG_8192C belongs to a family of verbose
private tracing macros.
The default behaviour is _do nothing_, to activate
it one should define DEBUG symbol by hand.
So just remove it
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com >
Link: https://lore.kernel.org/r/d954fbde0ae689cd053a57f57f954f14b5d013cb.1618064274.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-04-11 08:45:01 +02:00