Malcolm Priestley
1390b02a2f
staging: vt6656: rename PIPEnsControlOut/CONTROLnsRequestOut to vnt_control_out
...
Rename all CONTROLnsRequestOut and remove macro from control.h
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-26 10:36:49 -07:00
Malcolm Priestley
88a8926fba
staging: vt6656: mac.c remove DBG_PRT debug message.
...
Replace with dev_dbg
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-26 10:36:49 -07:00
Malcolm Priestley
39dd526e51
staging: vt6656: MACvSetKeyEntry remove camel case.
...
camel case changes
pDevice -> priv
wKeyCtl -> key_ctl
uEntryIdx -> entry_idx
uKeyIdx -> key_idx
pbyAddr -> addr
wOffset -> offset
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-26 10:36:48 -07:00
Malcolm Priestley
954e8142a5
staging: vt6656: MACvSetKeyEntry change u32 pdwKey to u8 pointer
...
Change pdwKey u32 pointer to key u8 pointer.
Callers are already u8 remove u32 pointer cast.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-26 10:36:48 -07:00
Joel Porquet
c1ad28a399
staging: silicom/bypasslib/bp_ioctl.h: Fix erroneous global variable definitions
...
Originally, this header was defining two new typedefs, CMND_TYPE and
CMND_TYPE_SD, following this type of declaration:
typedef enum {
...
} CMND_TYPE;
A previous commit (785086556a ) tried to
fix warnings that were pointed out by checkpatch.pl, concerning not
adding new typedefs. But this commit only removed the 'typedef' keyword,
thus transforming both the typedefs into two the definition of global
variables. For example:
enum {
...
} CMND_TYPE;
As noticed by the Sparse tool, this patch removes those erroneous global
variable definitions, and just leaves anonymous enum type definitions:
enum {
...
};
Signed-off-by: Joel Porquet <joel@porquet.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-26 10:36:07 -07:00
Daeseok Youn
a66369a590
staging: dgap: move tty_port_init() for serial_ports.
...
If printer_ports which is allocated after serial_ports is failed
to allocate, tty_port_init for serial_ports doesn't need anymore.
So move this after allocating memory for printer_ports.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-26 10:35:25 -07:00
Daeseok Youn
0ade4a34fd
staging: dgap: remove unneeded kfree() in dgap_tty_register_ports()
...
When it failed to allocate for printer_ports, serial_ports
can be freed in dgap_tty_uninit().
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-26 10:35:24 -07:00
Daeseok Youn
462310f3f3
staging: dgap: remove unneeded kfree() for ttys in tty_driver
...
In destruct_tty_driver() from put_tty_driver() will free the
ttys in tty_driver.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-26 10:35:24 -07:00
Tobias Klauser
ddafd514b1
staging/lustre/llite: Remove unnecessary check for NULL before iput()
...
iput() already checks for the inode being NULL, thus it's unnecessary to
check before calling.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-26 10:33:49 -07:00
Peter Senna Tschudin
4764ca981b
drivers/staging: Remove useless return variables
...
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-26 10:32:15 -07:00
Chaitanya Hazarey
9c73b46af4
Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines
...
Added a blank line after declarations in many places to fix
the following warning issued by checkpatch.pl:
WARNING: Missing a blank line after declarations
Signed-off-by: Chaitanya Hazarey <c@24.io >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-26 10:30:23 -07:00
Jes Sorensen
ef71c9b86d
staging: rtl8723au: _InitQueueReservedPage(): Remove pointless brackets
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:46 -07:00
Jes Sorensen
13aa75858b
staging: rtl8723au: Remove unused struct btdata_info
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:46 -07:00
Jes Sorensen
1d599de6b9
staging: rtl8723au: Rename BTDM_FwC2hBtInfo8723A() to rtl8723a_fw_c2h_BT_info()
...
In addition get rid of some pointless code obfuscating wrappers
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:45 -07:00
Jes Sorensen
d5a1427b5d
staging: rtl8723au: rtl8723a_bt-coexist.c: Remove unnecessary #ifdef CONFIG_8723AU_BT_COEXIST
...
This file is only compiled if CONFIG_8723AU_BT_COEXIST=y
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:45 -07:00
Jes Sorensen
9b2d4aeaa8
staging: rtl8723au: Rename HALBT_InitBTVars8723A() rtl8723a_BT_init_hal_vars()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:45 -07:00
Jes Sorensen
ec6d687134
staging: rtl8723au: Make rtl8723a_set_BTCoex_AP_mode_FwRsvdPkt_cmd() a no-op when no co-exist enabled
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:45 -07:00
Jes Sorensen
c814d4d6df
staging: rtl8723au: Rename BT_WifiAssociateNotify() rtl8723a_BT_wifiassociate_notify()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:45 -07:00
Jes Sorensen
900a3260fb
staging: rtl8723au: rtl8732au_hal_init.c: Use rtl8723au_BT_coexist() to pick firmware image
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:45 -07:00
Jes Sorensen
1305565cfa
staging: rtl8723au: usb_halinit.c: Remove no-op HAL_INIT_PROFILE_TAG()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:44 -07:00
Jes Sorensen
00e8b24aee
staging: rtl8723au: Rename HALBT_InitHwConfig() rtl8723a_BT_init_hwconfig()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:44 -07:00
Jes Sorensen
dadc54b8eb
staging: rtl8723au: Move rtl8723a_dual_antenna_detection() to rtl8723a_bt-coexist.c
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:44 -07:00
Jes Sorensen
dddeff3f20
staging: rtl8723au: odm.c: Rename BTDM_DisableEDCATurbo() to rtl8723a_BT_disable_EDCA_turbo()
...
Make it return bool since it only returns true/false, and get rid of
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:44 -07:00
Jes Sorensen
d0fc14642f
staging: rtl8723au: rtw_mlme_ext.c: Sanitize calls to alloc_mgtxmitframe23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:44 -07:00
Jes Sorensen
92825e6e36
staging: rtl8723au: rtw_mlme_ext.c: Remove CONFIG_8723AU_BT_COEXIST #ifdefs
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:43 -07:00
Jes Sorensen
280e7a0bfa
staging: rtl8723au: rtw_pwrctrl.c: Eliminate CONFIG_8723AU_BT_COEXIST #ifdefs
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:43 -07:00
Jes Sorensen
e631bae363
staging: rtl8723au: rtw_pwrctrl.c: Remove an unnecessary COEXIST #ifdef
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:43 -07:00
Jes Sorensen
09d8879195
staging: rtl8723au: rtw_cmd.c: Remove last #ifdef CONFIG_8723AU_BT_COEXIST usage
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:43 -07:00
Jes Sorensen
a862d5d307
staging: rtl8723au: Rename BT_LpsLeave() rtl8723a_BT_lps_leave()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:43 -07:00
Jes Sorensen
f83e9e2a13
staging: rtl8723au: Rename BTDM_ForDhcp() to rtl8723a_BT_specialpacket_notify()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:43 -07:00
Jes Sorensen
43de030409
staging: rtl8723au: Rename BT_WifiMediaStatusNotify() rtl8723a_BT_mediastatus_notify()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:42 -07:00
Jes Sorensen
d952e4c4af
staging: rtl8723au: Rename BT_WifiScanNotify() rtl8723a_BT_wifiscan_notify()
...
Providing a dummy wrapper also allows removing some more
CONFIG_8723AU_BT_COEXIST clutter
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:42 -07:00
Jes Sorensen
febf30876e
staging: rtl8723au: Rename BTDM_Coexist() to rtl8723a_BT_do_coexist()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:42 -07:00
Jes Sorensen
ef95e276a8
staging: rtl8723au: Remove some CONFIG_8723AU_BT_COEXIST clutter
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:42 -07:00
Jes Sorensen
1af4072b44
staging: rtl8723au: Introduce rtl8723a_BT_coexist() - and use it!
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:42 -07:00
Jes Sorensen
bf2a7b9951
staging: rtl8723au: Convert BT_IsBtDisabled() into rtl8723a_BT_enabled()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:42 -07:00
Jes Sorensen
3a159d9acc
staging: rtl8723au: Create rtl8723au_bt_intf.h
...
Use this header for declaring functions that are currently #ifdef'ed
out in the general code.
Start by moving BTDM_1Ant8723A() there and renaming it appropriately.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:41 -07:00
Jes Sorensen
983ebef5c9
staging: rtl8723au: PS_RDY_CHECK() return bools in 'bool'
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:41 -07:00
Jes Sorensen
9160518e25
staging: rtl8723au: _rtw_pwr_wakeup23a(): Do not mix _FAIL/false as return value
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:41 -07:00
Jes Sorensen
32dfcb1bf2
staging: rtl8723au: bInternalAutoSuspend is always false
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:41 -07:00
Jes Sorensen
e6d880db3c
staging: rtl8723au: Remove unused prototype rtw_cfg80211_issue_p2p_provision_request23a()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:41 -07:00
Jes Sorensen
d165e4efbc
staging: rtl8723au: rtw_wdev_alloc(): Don't register wiphy before kmalloc() completed
...
There is no point starting to register the wiphy and then having to
unregister it again if the followon kmalloc() fails.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:40 -07:00
Jes Sorensen
56b0bd91e0
staging: rtl8723au: Remove some pointless cfg80211_* wrapper macros
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:40 -07:00
Jes Sorensen
661f70698b
staging: rtl8723au: struct rtw_wdev_priv: Remove some never 'true' variables
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:40 -07:00
Jes Sorensen
015e425e06
staging: rtl8723au: Get rid of unused struct rtw_wdev_invit_info
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:40 -07:00
Jes Sorensen
de62f67a00
staging: rtl8723au: _cfg80211_rtw_mgmt_tx() clean up checking function return values
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:40 -07:00
Jes Sorensen
58af40a9a4
staging: rtl8723au: Delete unused rtw_cfg80211_set_mgnt_wpsp2pie()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:40 -07:00
Jes Sorensen
cc2db7cb8d
staging: rtl8723au: ioctl_cfg80211.c: Use ether_addr_equal()
...
... and in one case use is_zero_ether_addr()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:39 -07:00
Jes Sorensen
888df442ef
staging: rtl8723au: ioctl_cfg80211.c: Use ether_addr_copy()
...
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:39 -07:00
Jes Sorensen
8b506ef181
staging: rtl8723au: Do not call netdev_open23a() from cfg80211_rtw_change_iface()
...
Calling open on the device when changing the interface type is wrong.
Let the stack call open at the right time.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2014-05-25 15:14:39 -07:00