K. Y. Srinivasan
3880914aa6
Staging: hv: Get rid of the function blkvsc_revalidate_disk()
...
The block driver in Hyper-V does not support removable media, get rid of the
blkvsc_revalidate_disk().
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:22:53 -07:00
K. Y. Srinivasan
aac7af6db1
Staging: hv: Get rid of the state media_not_present
...
The block driver in Hyper-V does not handle removable media, get rid of the
media_not_present state.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:22:52 -07:00
K. Y. Srinivasan
26a1973962
Staging: hv: Get rid of the function blkvsc_do_flush()
...
Get rid of the function blkvsc_do_flush() and instead use the common function
to force a device flush.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:22:52 -07:00
K. Y. Srinivasan
6c65da7659
Staging: hv: Get rid of blkvsc_do_read_capacity16()
...
Get rid of blkvsc_do_read_capacity16() and instead use the common function
for retrieving capacity.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:22:51 -07:00
K. Y. Srinivasan
2038e21486
Staging: hv: Get rid of blkvsc_do_read_capacity()
...
Now that we have a common function for some of the operations on the device,
use that and get rid of the function blkvsc_do_read_capacity().
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:22:51 -07:00
K. Y. Srinivasan
2ede209f5b
Staging: hv: Introduce a common function for issuing commands to the device
...
There are multiple functions to either get info about the device
(INQUIRY, CAPACITY etc) or to FLUSH the device cache. The majority of the
code for these functions is identical. Introduce a common function for
doing all these operations.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:22:50 -07:00
K. Y. Srinivasan
ea50245ffa
Staging: hv: Simplify the code for blkvsc_getgeo()
...
We are making up the geometry anyway, keep it simple.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:22:49 -07:00
K. Y. Srinivasan
7b04cd089e
Staging: hv: Enable blkvsc_ioctl()
...
We can support HDIO_GET_IDENTITY ioctl, enable blkvsc_ioctl().
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:22:49 -07:00
K. Y. Srinivasan
8c3ab81c4e
Staging: hv: Get rid of some dead code in blkvsc_drv.c
...
Get rid of some dead code in blkvsc_drv.c.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:49 -07:00
K. Y. Srinivasan
369cb5ce69
Staging: hv: Move module parameter to earlier in the file
...
Move module parameter to be earlier in the file.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:49 -07:00
K. Y. Srinivasan
f84044d30e
Staging: hv: Move some definitions/declarations to be earlier in the file
...
Move some definitions/declarations to be earlier in the file.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:48 -07:00
K. Y. Srinivasan
1efe70583f
Staging: hv: Get rid of the forward declaration for blkvsc_request()
...
Get rid of the forward declaration for blkvsc_request() by moving the code
around.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:48 -07:00
K. Y. Srinivasan
76abfaa351
Staging: hv: Get rid of the forward declaration for blkvsc_do_pending_reqs()
...
Get rid of the forward declaration for blkvsc_do_pending_reqs() by moving
the code around.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:47 -07:00
K. Y. Srinivasan
8f8e57ab9a
Staging: hv: Get rid of the forward declaration for blkvsc_do_request()
...
Get rid of the forward declaration for blkvsc_do_request() by moving the
code around.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:47 -07:00
K. Y. Srinivasan
2c77407ac3
Staging: hv: Get rid of the forward declaration for blkvsc_do_inquiry()
...
Get rid of the forward declaration for blkvsc_do_inquiry() by moving the code
around.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:46 -07:00
K. Y. Srinivasan
349b38e8df
Staging: hv: Get rid of the forward declaration of blkvsc_revalidate_disk()
...
Get rid of the forward declaration of blkvsc_revalidate_disk() by moving
the code around.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:46 -07:00
K. Y. Srinivasan
583c367fdf
Staging: hv: Get rid of the forward declaration of blkvsc_do_read_capacity16()
...
Get rid of the forward declaration of blkvsc_do_read_capacity16() by moving
the code around.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:45 -07:00
K. Y. Srinivasan
87b31c2244
Staging: hv: Get rid of the forward declaration for blkvsc_do_read_capacity()
...
Get rid of the forward declaration for blkvsc_do_read_capacity() by moving
the code around.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:45 -07:00
K. Y. Srinivasan
8138bd95a6
Staging: hv: Get rid of the forward declaration for blkvsc_release()
...
Get rid of the forward declaration for blkvsc_release() by moving the code
around.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:45 -07:00
K. Y. Srinivasan
e82066b20b
Staging: hv: Get rid of the forward declaration of blkvsc_shutdown()
...
Get rid of the forward declaration of blkvsc_shutdown() by moving the
code around.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:45 -07:00
K. Y. Srinivasan
8c09004468
Staging: hv: Get rid of the forward declaration of blkvsc_remove()
...
Get rid of the forward declaration of blkvsc_remove() by moving the code around.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:44 -07:00
K. Y. Srinivasan
f60f2138a9
Staging: hv: Get rid of the forward declaration of blkvsc_cancel_pending_reqs()
...
Get rid of the forward declaration of blkvsc_cancel_pending_reqs() by moving
the code around.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:44 -07:00
K. Y. Srinivasan
9d64582071
Staging: hv: Get rid of the forward declaration of blkvsc_do_flush()
...
Get rid of the forward declaration of blkvsc_do_flush() by moving the code
around.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:43 -07:00
K. Y. Srinivasan
795d30bb38
Staging: hv: Get rid of the forward declaration of blkvsc_cmd_completion()
...
Get rid of the forward declaration of blkvsc_cmd_completion() by moving the
code around.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:43 -07:00
K. Y. Srinivasan
7955344f60
Staging: hv: Get rid of the forward declaration of blkvsc_ioctl()
...
Get rid of the forward declaration of blkvsc_ioctl() by moving the code around.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:42 -07:00
K. Y. Srinivasan
b7be09cc91
Staging: hv: Get rid of the forward declaration of blkvsc_init_rw()
...
Get rid of the forward declaration of blkvsc_init_rw() by moving the
code around.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com >
Signed-off-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:20:41 -07:00
Haiyang Zhang
648dc59899
staging: hv: convert function name NetVscDisconnectFromVsp to lower case
...
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:13:28 -07:00
Haiyang Zhang
72e80cb793
staging: hv: clean up unused forward declarations
...
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:13:28 -07:00
Haiyang Zhang
b637e02348
staging: hv: move netvsc_device_add() to clean up forward declaration
...
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:13:27 -07:00
Haiyang Zhang
0021e71e9f
staging: hv: move netvsc_destroy_send_buf() to clean up forward declaration
...
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:13:27 -07:00
Haiyang Zhang
ec91cd09b1
staging: hv: move netvsc_destroy_recv_buf() to clean up forward declaration
...
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:13:26 -07:00
Haiyang Zhang
5fa9d3c51d
staging: hv: move netvsc_send_recv_completion() to clean up forward declaration
...
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:13:26 -07:00
Haiyang Zhang
57991156b9
staging: hv: move netvsc_receive_completion() to clean up forward declaration
...
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:13:26 -07:00
Haiyang Zhang
af24ce42c5
staging: hv: move netvsc_initialize() to clean up forward declaration
...
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-25 16:13:25 -07:00
Tomas Winkler
57903f29cd
staging/easycap: easycap_probe: drop unuzed variables
...
Cc: Mike Thomas <rmthomas@sciolus.org >
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-20 18:08:08 -07:00
Tomas Winkler
ad30d7af14
staging/easycap: easycap_probe: take out duplicated code from ifdef - else
...
Cc: Mike Thomas <rmthomas@sciolus.org >
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-20 18:08:07 -07:00
Tomas Winkler
11ff12feb4
staging/easycap: easycap_probe : rename usb variables to common names
...
1. rename usb variables to more common names
struct usb_device *pusb_device -> usbdev
struct usb_host_interface *pusb_host_interface -> alt
struct usb_endpoint_descriptor *pepd ->
struct usb_interface_descriptor *pusb_interface_descriptor -> interface;
2. use usb_altnum_to_altsetting to access alternative settings
Cc: Mike Thomas <rmthomas@sciolus.org >
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-20 18:08:07 -07:00
Michael Hennerich
24742ac692
IIO: GYRO: IIO driver for Analog Devices Digital Output Gyroscope ADXRS450
...
From: Cliff Cai <cliff.cai@analog.com >
Add new IIO driver for Analog Devices digital output gyroscope ADXRS450
Signed-off-by: Cliff Cai <cliff.cai@analog.com >
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com >
Acked-by: Jonathan Cameron <jic23@cam.ac.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-20 14:20:46 -07:00
Michael Hennerich
d48946357b
IIO: Documentation: Add ABI documentatio for gyro quadrature correction
...
From: Cliff Cai <cliff.cai@analog.com >
Add ABI documentation for gyro quadrature correction.
Signed-off-by: Cliff Cai <cliff.cai@analog.com >
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com >
Acked-by: Jonathan Cameron <jic23@cam.ac.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-20 14:20:46 -07:00
Michael Hennerich
860a4e9d9f
IIO: GYRO: Add MACRO for gyro quadrature correction
...
From: Cliff Cai <cliff.cai@analog.com >
Add gyro_z_quadrature_correction_raw define.
Signed-off-by: Cliff Cai <cliff.cai@analog.com >
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com >
Acked-by: Jonathan Cameron <jic23@cam.ac.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-20 14:20:45 -07:00
Uwe Kleine-König
7aead6d77a
staging/comedi: remove German in-file changelog
...
My script that finds typos always wants to do s/Funktion/Function/.
Instead of adding some whilelist logic to my script just delete the
changelog that is useless in general and still more in this case as most
kernel developers don't understand it.
Cc: Greg Kroah-Hartman <gregkh@suse.de >
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-20 14:18:56 -07:00
Alan Cox
01fbb4781f
Staging: iio: oaktrail AK8975 support via IIO
...
Actually this is generic 'I have no GPIO' support for the AK8975, instead
we have to go bus polling.
Huang Liang produced an initial patch which worked by removing the support
for GPIO pins. This patch instead makes GPIO support optional and Huang then
fixed some bugs in it.
Signed-off-by: Alan Cox <alan@linux.intel.com >
Acked-by: Jonathan Cameron <jic23@cam.ac.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-20 14:18:55 -07:00
Roland Vossen
acf0b9e819
staging: brcm80211: removed static ASSERTs
...
Code cleanup. ASSERTs that check static (compile time) conditions
have been removed.
Signed-off-by: Roland Vossen <rvossen@broadcom.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-20 14:18:55 -07:00
Larry Finger
57d745ea6b
staging: brcm80211: Remove symbol CONFIG_BRCM80211
...
Since the staging driver brcm80211 was renamed to brcmsmac, CONFIG_BRCM80211
is not really needed. In addition, a two-entry list hardly needs a separate
config menu.
The only awkward place in the revised code is the double addition of the
brcm80211 Makefile.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-20 14:13:32 -07:00
Javier M. Mellid
2657c30e23
staging: rtl8712: fixed coding style issues
...
Fixed some style and format issues with code.
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-20 14:13:31 -07:00
Javier M. Mellid
0593758e4b
staging: rtl8712: fixed coding style issues
...
Fixed some style and format issues with headers.
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-20 14:13:31 -07:00
Roland Vossen
790c3093c0
staging: brcm80211: ASSERT cleanup in phy
...
Code cleanup. Driver contains too many ASSERTs. Removed all ASSERTs
in the PHY that did not directly relate to a value being read from
hardware.
Signed-off-by: Roland Vossen <rvossen@broadcom.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-20 14:12:38 -07:00
Julia Lawall
e2ce504977
drivers/staging/cx25821/cx25821-video.c: introduce missing kfree
...
Error handling code following a kmalloc should free the allocated data.
The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/ )
// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
when != if (...) { <+...x...+> }
(
x->f1 = E
|
(x->f1 == NULL || ...)
|
f(...,x->f1,...)
)
...>
(
return \(0\|<+...x...+>\|ptr\);
|
return@p2 ...;
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-20 14:11:47 -07:00
Julia Lawall
48c59f4b91
drivers/staging/intel_sst/intel_sst_app_interface.c: introduce missing kfree
...
Stream_bufs is initialized at the beginning of the function, and then the
#ifdef code declares a new variable with the same name and initializes
that. If the if in the ifdef is taken, the then branch returns, implying
that the first stream_bufs is never used and is leaked. The first
initialization is thus moved down after the ifdef.
The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/ )
// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
when != if (...) { <+...x...+> }
(
x->f1 = E
|
(x->f1 == NULL || ...)
|
f(...,x->f1,...)
)
...>
(
return \(0\|<+...x...+>\|ptr\);
|
return@p2 ...;
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-20 14:11:45 -07:00
Julia Lawall
60d5c9f5b6
drivers/staging/brcm80211/brcmfmac/wl_iw.c: introduce missing kfree
...
Error handling code following a kmalloc should free the allocated data.
The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/ )
// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
when != if (...) { <+...x...+> }
(
x->f1 = E
|
(x->f1 == NULL || ...)
|
f(...,x->f1,...)
)
...>
(
return \(0\|<+...x...+>\|ptr\);
|
return@p2 ...;
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-04-20 14:11:43 -07:00