Liu Junqi
4e4437d09c
staging: unisys: visornic: reindent to avoid '(' at the end of line
...
A change to make the code more like typical coding style.
Signed-off-by: Liu Junqi <liujunqi@pku.edu.cn >
Link: https://lore.kernel.org/r/20211125044729.594727-2-liujunqi@pku.edu.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-25 17:38:53 +01:00
Liu Junqi
a70fc7d0d1
staging: unisys: visornic: fixed a typo cant -> can't
...
Fixed a typo: cant -> can't in visornic_main.c.
Signed-off-by: Liu Junqi <liujunqi@pku.edu.cn >
Link: https://lore.kernel.org/r/20211125044729.594727-1-liujunqi@pku.edu.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-25 17:38:53 +01:00
Liu Junqi
515f497024
staging: unisys: visorhba: use tab to indent instead of whitespace
...
changed the whitespace to tab to comply with kernel coding style.
Signed-off-by: Liu Junqi <liujunqi@pku.edu.cn >
Link: https://lore.kernel.org/r/20211118033737.576775-1-liujunqi@pku.edu.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-25 17:38:34 +01:00
Zameer Manji
1189d2fb15
staging: r8188eu: delete unused header
...
The iee80211_ext.h header is unused and can be removed.
Signed-off-by: Zameer Manji <zmanji@gmail.com >
Link: https://lore.kernel.org/r/20211116193557.1188939-1-zmanji@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-17 13:57:09 +01:00
Michael Straube
06e6885d6a
staging: r8188eu: code indent should use tabs
...
Replace spaces with tab to clear the following checkpatch issues.
usb_intf.c:38: ERROR: code indent should use tabs where possible
usb_intf.c:38: WARNING: please, no spaces at the start of a line
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Link: https://lore.kernel.org/r/20211117072007.19924-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-17 13:57:00 +01:00
Zameer Manji
8495a34094
staging: r8188eu: remove unused defines in wifi.h
...
None of these defines in wifi.h are used so they
can be safely removed.
Reviewed-by: Pavel Skripkin <paskripkin@gmail.com >
Signed-off-by: Zameer Manji <zmanji@gmail.com >
Link: https://lore.kernel.org/r/20211116011451.896714-1-zmanji@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-17 13:56:10 +01:00
Guo Zhengkui
fce0490dcb
staging: r8188eu: fix array_size.cocci warning
...
Fix following array_size.cocci warning:
./drivers/staging/r8188eu/core/rtw_rf.c:38:48-49: WARNING: Use ARRAY_SIZE.
ARRAY_SIZE() defined in <linux/kernel.h> is safer because it uses
__must_be_array().
Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com >
Link: https://lore.kernel.org/r/20211116064124.8833-2-guozhengkui@vivo.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-17 13:55:52 +01:00
Karolina Drobnik
944f0f697a
staging: vt6655: Delete bogus check for init_count in AL7230
...
Remove an unnecessary check in `rf_write_wake_prog_syn` in `RF_AIROHA7230`
switch case. This `if` conditional will never be true as `init_count` is
equal to 18 and can't be bigger than `MISCFIFO_SYNDATASIZE - 0`, which
is equal to 21.
Suggested-by: Mike Rapoport <mike.rapoport@gmail.com >
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com >
Link: https://lore.kernel.org/r/e10d2278975116e03a699260f2259f9ab87501a5.1636729147.git.karolinadrobnik@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-17 13:55:32 +01:00
Karolina Drobnik
8026ee384a
staging: vt6655: Delete bogus check for init_count in AL2230
...
Remove an unnecessary check in `rf_write_wake_prog_syn` in `RF_AL2230S`
switch case. This `if` conditional will never be true as `init_count` is
equal to 17 and can't be bigger than `MISCFIFO_SYNDATASIZE - 0`, which
is equal to 21.
Suggested-by: Mike Rapoport <mike.rapoport@gmail.com >
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com >
Link: https://lore.kernel.org/r/29c758ba58b10bc1da7e864b3a4f377147fc4428.1636729147.git.karolinadrobnik@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-17 13:55:32 +01:00
Karolina Drobnik
6a141baa80
staging: vt6655: Update comment for rf_write_wake_prog_syn
...
Change the function description to include the actual parameters.
Update the comment on the return type.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com >
Link: https://lore.kernel.org/r/be06c8f0df043598f3280a15397ad66aabefeaf4.1636729147.git.karolinadrobnik@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-17 13:55:32 +01:00
Karolina Drobnik
1d17faf5c9
staging: vt6655: Rename RFvWriteWakeProgSyn function
...
To align with the kernel coding style, remove the type from
the function name and do not use CamelCase.
Fix issue detected by checkpatch.pl:
CHECK: Avoid CamelCase: <RFvWriteWakeProgSyn>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com >
Link: https://lore.kernel.org/r/29899f738b4f381a2b3f01fd0748e9b96f835239.1636729147.git.karolinadrobnik@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-17 13:55:32 +01:00
Karolina Drobnik
9064cb02ee
staging: vt6655: Rewrite conditional in AL7320 initialization
...
Use conditional operator to determine which table for AL7320
initialization should be used. Introduce `init_table` variable
to store this value.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com >
Link: https://lore.kernel.org/r/28169210bc26d5fcc1080ed18dc8e043bc3ef30b.1636729147.git.karolinadrobnik@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-17 13:55:32 +01:00
Karolina Drobnik
460228f19b
staging: vt6655: Use incrementation in idx
...
Increment `idx` in a loop instead of adding the loop counter
`i` to do so. Delete increments of `i` that were rendered
unnecessary by this change.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com >
Link: https://lore.kernel.org/r/9affeaf40ddb31e03b21db9acd099db4d80da179.1636729147.git.karolinadrobnik@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-17 13:55:32 +01:00
Karolina Drobnik
cfbfa0d3c3
staging: vt6655: Introduce idx variable
...
Add a local variable to store `MISCFIFO_SYNDATA_IDX` offset.
This change helps in shortening the lines in `rf.c` that
are deemed too long by checkpatch.pl.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com >
Link: https://lore.kernel.org/r/596ae9bc980379860b5b1785b3ecc88e18121103.1636729147.git.karolinadrobnik@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-17 13:55:32 +01:00
Karolina Drobnik
6a143ec198
staging: vt6655: Remove unnecessary type casts
...
Remove casts to unsigned short in `RFvWriteWakeProgSyn` function as they are
not needed.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com >
Link: https://lore.kernel.org/r/c9a5718479deda078b582cbc42a4e7b2f3a6cb39.1636729147.git.karolinadrobnik@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-17 13:55:32 +01:00
Martin Kaiser
272958bf8e
staging: r8188eu: remove the efuse_hal structure
...
struct efuse_hal is not used and can be removed.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211113185518.23941-16-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:32:36 +01:00
Martin Kaiser
232ee4d19e
staging: r8188eu: remove fake efuse variables
...
We removed the pseudo read code. This patch removes the fake efuse arrays
that were used by pseudo reads.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211113185518.23941-15-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:32:36 +01:00
Martin Kaiser
70919f64ea
staging: r8188eu: remove bt efuse definitions
...
This driver does not use bt efuses. Remove global variables and
definitions related to bt efuses.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211113185518.23941-14-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:32:35 +01:00
Martin Kaiser
d53ad62518
staging: r8188eu: efuse_OneByteWrite is unused
...
Remove the efuse_OneByteWrite function, which is no longer used.
Remove resulting dead code as well.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211113185518.23941-13-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:32:35 +01:00
Martin Kaiser
0f4504dc5d
staging: r8188eu: efuse_OneByteRead is unused
...
Remove the efuse_OneByteRead function, which is no longer used.
Remove resulting dead code as well.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211113185518.23941-12-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:32:35 +01:00
Martin Kaiser
dd65763932
staging: r8188eu: remove defines for efuse type
...
We've removed all code to handle efuse types. The last step is to
remove the defines for bt and wifi efuse types.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211113185518.23941-11-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:32:35 +01:00
Martin Kaiser
a98e3bd77e
staging: r8188eu: rtl8188e_EFUSE_GetEfuseDefinition is unused
...
Now that we use the map length directly, rtl8188e_EFUSE_GetEfuseDefinition
is no longer needed and can be removed.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211113185518.23941-10-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:32:35 +01:00
Martin Kaiser
36c6b1eb57
staging: r8188eu: use efuse map length define directly
...
The length of the efuse data section is constant. We can use the
corresponding define directly, there's no need to get the length
from rtl8188e_EFUSE_GetEfuseDefinition.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211113185518.23941-9-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:32:35 +01:00
Martin Kaiser
a15aed6633
staging: r8188eu: merge Efuse_ReadAllMap into EFUSE_ShadowMapUpdate
...
Efuse_ReadAllMap is small, it's called only by EFUSE_ShadowMapUpdate.
This patch merges the two functions.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211113185518.23941-8-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:32:35 +01:00
Martin Kaiser
304c825316
staging: r8188eu: rtl8188e_Efuse_PgPacketRead is now unused
...
After we removed efuse write support, rtl8188e_Efuse_PgPacketRead is no
longer needed. Remove this function and its internal helpers.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211113185518.23941-7-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:32:35 +01:00
Martin Kaiser
ec00db06a1
staging: r8188eu: rtl8188e_EfuseGetCurrentSize is now unused
...
After we removed efuse write support, rtl8188e_EfuseGetCurrentSize is no
longer needed. Remove this function and its internal helpers.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211113185518.23941-6-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:32:35 +01:00
Martin Kaiser
2267ac0162
staging: r8188eu: merge small adapter info helpers
...
ReadAdapterInfo8188EU calls Hal_InitPGData88E and readAdapterInfo_8188EU,
both of which are small and have no other callers. Merge the two latter
functions into ReadAdapterInfo8188EU.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211113185518.23941-5-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:32:35 +01:00
Martin Kaiser
6f520d1f50
staging: r8188eu: remove test code for efuse shadow map
...
The EFUSE_ShadowMapUpdate function has a parameter to replace the
actual read operations with test reads. The only caller of
EFUSE_ShadowMapUpdate does not use this test mode.
Remove the read test code from EFUSE_ShadowMapUpdate and the low-level
functions that it calls.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211113185518.23941-4-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:32:35 +01:00
Martin Kaiser
3a6a68888b
staging: r8188eu: remove efuse type from read functions
...
Efuse_ReadAllMap, ReadEFuseByIC and ReadEFuse_Pseudo do not use their
efuseType parameter. Remove the parameter from these functions and
from their callers.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211113185518.23941-3-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:32:35 +01:00
Martin Kaiser
8e16234258
staging: r8188eu: remove efuse type from definition functions
...
Hal_EFUSEGetEfuseDefinition88E and Hal_EFUSEGetEfuseDefinition_Pseudo88E
do not use their efuseType parameter.
Remove the parameter from these functions and from their callers.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211113185518.23941-2-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:32:35 +01:00
Sergio Paracuellos
53a2f33caa
staging: mt7621-dts: remove 'gdma' and 'hsdma' nodes
...
Drivers related with 'gdma' and 'hsdma' nodes are not in-tree. Remove them
from the device tree file.
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com >
Link: https://lore.kernel.org/r/20211113192045.32153-4-sergio.paracuellos@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:29:12 +01:00
Sergio Paracuellos
87dd67f496
staging: mt7621-dma: remove driver from tree
...
This driver was a added a time ago and there is no special effort or work
to clean it and any progress at all to mainline it. Also, there is already
a driver from Mediatek in 'drivers/dma/mediatek/mtk-hsdma.c' which looks
pretty similar to this. So the way of supporting HSDMA for mt7621 would be
to modify that driver instead.
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com >
Link: https://lore.kernel.org/r/20211113192045.32153-3-sergio.paracuellos@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:29:12 +01:00
Sergio Paracuellos
5bfc10690c
staging: ralink-gdma: remove driver from tree
...
This driver was a added a time ago and there is no special effort or work
to clean it and any progress at all to mainline it. Also, the main user of
this dma controller seems to be 'i2s' in mt7621 SoCs. There is no in-tree
driver at all for the 'i2s' and its related device tree node has also been
deleted from main device tree file. Hence, remove this driver also for
completeness.
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com >
Link: https://lore.kernel.org/r/20211113192045.32153-2-sergio.paracuellos@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:29:12 +01:00
Gabriel Goller
ac0c9be91a
staging: wlan-ng: Removed unused comments
...
Removed commented-out code pieces that are unnecessary.
Signed-off-by: Gabriel Goller <gabrielgoller123@gmail.com >
Link: https://lore.kernel.org/r/YY7QKNB7egKuTC36@desktop
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:02:05 +01:00
Tommaso Merciai
fca00dc456
staging: vt6655: fix camelcase in bRadioOff
...
Replace camel case variable bRadioOff with snake case
variable radio_off.
Drop Hungarian notation prefix in `bRadioOff` variable.
Change it to use snake case.
Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com >
Link: https://lore.kernel.org/r/20211113102126.82904-1-tomm.merciai@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:02:04 +01:00
Martin Kaiser
74b1dc3630
staging: r8188eu: simplify two boolean assignments
...
There's no need to use the ? operator and to set true and
false explicitly.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211111212644.9011-7-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:02:04 +01:00
Martin Kaiser
80d21b0a5d
staging: r8188eu: merge three small functions
...
ReadAdapterInfo8188EU calls _ReadAdapterInfo8188EU.
_ReadAdapterInfo8188EU calls _ReadPROMContent.
Each of these functions is small and has only one caller. Move all
their code into ReadAdapterInfo8188EU.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211111212644.9011-6-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:02:04 +01:00
Martin Kaiser
216506a986
staging: r8188eu: rf_chip is constant
...
For this driver, rf_chip is always RF_6052. Remove the rf_chip component
from struct hal_data_8188e and resulting dead code.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211111212644.9011-5-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:02:04 +01:00
Martin Kaiser
9f784c8214
staging: r8188eu: remove autoload check
...
In Hal_InitPGData88E, the same code is run, regardless of
bautoload_fail_flag.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211111212644.9011-4-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:02:04 +01:00
Martin Kaiser
c4120aaefb
staging: r8188eu: remove haldata's EEPROMSubCustomerID
...
It is used only in a (disabled) debug print.
We can now remove two functions that parsed eeprom info and populated
haldata components.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211111212644.9011-3-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:02:04 +01:00
Martin Kaiser
704a47655e
staging: r8188eu: remove haldata's EEPROMCustomerID
...
It is used only in a (disabled) debug print.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211111212644.9011-2-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:02:04 +01:00
Martin Kaiser
49ee664299
staging: r8188eu: remove haldata's EEPROMVID / PID
...
They are used only in a (disabled) debug print.
In practice, lsusb can be used to read the actual vid and pid.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211111212644.9011-1-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:02:04 +01:00
Saurav Girepunje
d8a5b29b3d
staging: rtl8192u: remove the if condition without effect
...
In function rtl8192_adapter_start priv->pFirmware->firmware_status
is assign to FW_STATUS_0_INIT just after assignment variable is
again get check for same value. Therefore if condition will be
always be true. So remove the if condition ,else if section and
else section which will never get execute.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com >
Link: https://lore.kernel.org/r/YYijapuGOmObwM3S@Sauravs-MacBook-Air.local
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:02:04 +01:00
Saurav Girepunje
01d80b6ed2
staging: rtl8723bs: core: avoid unnecessary if condition
...
In function rtw_lps_change_dtim_hdl remove the if condition check
to compare the pwrpriv->dtim to dtim . If both are not equal dtim
is getting assign to pwrpriv->dtim. But if both are equal assigning
dtim to pwrpriv->dtim will not make any difference on value. So remove
the unnecessary if condition check.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com >
Link: https://lore.kernel.org/r/YYgWHt+PpyqOv40R@Sauravs-MacBook-Air.local
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:02:04 +01:00
Saurav Girepunje
d79c386174
staging: r8188eu: os_dep: Change the return type of function
...
Change the return type of rtw_init_default_value function
from u8 to void. This function always return success. This
is called from rtw_init_drv_sw where the return value from
this function is assign to local variable but the local variable
value is never checked. After change the return type to void
remove the local variable ret8 in rtw_init_drv_sw function.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com >
Link: https://lore.kernel.org/r/YYgCHkVXFQ4r9dVp@Sauravs-MacBook-Air.local
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:02:03 +01:00
Martin Kaiser
4b99dd7d21
staging: r8188eu: remove efuse write functions
...
The r8188eu driver in its current state does not need write access
to the efuses. Only read access is required to get the chip id, the
mac address and other settings.
This patch removes a lot of unused code for writing the efuses.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211107161624.9452-3-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:02:03 +01:00
Martin Kaiser
7e90e57307
staging: r8188eu: remove write support from rtl8188e_EfusePowerSwitch
...
The rtl8188e_EfusePowerSwitch function has a write parameter that is
set to false by its callers.
Remove the parameter and resulting dead code.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211107161624.9452-2-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:02:03 +01:00
Martin Kaiser
1a7b609415
staging: r8188eu: clean up _PHY_PathADDAOn
...
The only caller sets isPathAOn = true and is2t = false. Remove the
parameters and resulting dead code.
Make the function static, it's used only inside HalPhyRf_8188e.c.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211107143100.9047-5-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:02:03 +01:00
Martin Kaiser
ddf8a08643
staging: r8188eu: remove constant phy_IQCalibrate_8188E parameter
...
The only caller of phy_IQCalibrate_8188E sets the is2t parameter
to false.
Remove the parameter and resulting dead code. This includes the
phy_PathB_IQK_8188E and _PHY_PathAStandBy functions.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211107143100.9047-4-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:02:03 +01:00
Martin Kaiser
057957d998
staging: r8188eu: remove unused phy_PathA_RxIQK parameter
...
phy_PathA_RxIQK does not use its configPathB parameter.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20211107143100.9047-3-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-11-15 10:02:03 +01:00