Greg Kroah-Hartman
697d600d8f
Staging: brcm80211: sys: wlc_ampdu: fix some comparison warnings
...
Use min_t() instead of min() in some places to make the comparison
explicit and resolve some compiler warnings.
Cc: Brett Rudley <brudley@broadcom.com >
Cc: Henry Ptasinski <henryp@broadcom.com >
Cc: Nohee Ko <noheek@broadcom.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 12:25:23 -07:00
Greg Kroah-Hartman
e9e6727fcc
Staging: brcm80211: phy: wlc_phy_n: fix some comparison warnings
...
Use min_t() instead of min() in some places to make the comparison
explicit and resolve some compiler warnings.
Cc: Brett Rudley <brudley@broadcom.com >
Cc: Henry Ptasinski <henryp@broadcom.com >
Cc: Nohee Ko <noheek@broadcom.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.d
2010-10-08 12:16:08 -07:00
Greg Kroah-Hartman
c09cc58692
Staging: brcm80211: hnddma.c: fix compiler warning
...
Change the field types of dma_info_t to make comparing values easier
(and correct.) No need to keep rxbufsize as a u16, it can be an
unsigned int to make things easier.
Cc: Brett Rudley <brudley@broadcom.com >
Cc: Henry Ptasinski <henryp@broadcom.com >
Cc: Nohee Ko <noheek@broadcom.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 12:07:33 -07:00
Greg Kroah-Hartman
96e76e6941
Staging: brcm80211: remove VALID_MASK macro
...
No one is using it.
Cc: Brett Rudley <brudley@broadcom.com >
Cc: Henry Ptasinski <henryp@broadcom.com >
Cc: Nohee Ko <noheek@broadcom.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 12:01:30 -07:00
Greg Kroah-Hartman
e18d5313c6
Staging: brcm80211: remove ROUNDUP macro
...
And use the kernel provided 'roundup' instead.
Cc: Brett Rudley <brudley@broadcom.com >
Cc: Henry Ptasinski <henryp@broadcom.com >
Cc: Nohee Ko <noheek@broadcom.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 11:59:06 -07:00
Greg Kroah-Hartman
36c63ff6af
Staging: brcm80211: remove ISALIGNED macro
...
And use the kernel provided IS_ALIGNED one instead.
Cc: Brett Rudley <brudley@broadcom.com >
Cc: Henry Ptasinski <henryp@broadcom.com >
Cc: Nohee Ko <noheek@broadcom.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 11:55:40 -07:00
Greg Kroah-Hartman
d2733c97fa
Staging: brcm80211: remove unused ALIGN_ADDR() macro
...
It's not used (and there's a kernel provided one if it's ever needed in
the future), so remove it.
Cc: Brett Rudley <brudley@broadcom.com >
Cc: Henry Ptasinski <henryp@broadcom.com >
Cc: Nohee Ko <noheek@broadcom.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 11:52:16 -07:00
Greg Kroah-Hartman
8d3d6a6945
Staging: brcm80211: remove ARRAYSIZE macro
...
Use the real 'ARRAY_SIZE' definition instead.
Cc: Brett Rudley <brudley@broadcom.com >
Cc: Henry Ptasinski <henryp@broadcom.com >
Cc: Nohee Ko <noheek@broadcom.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 11:47:11 -07:00
Greg Kroah-Hartman
ce0f1b8cd1
Staging: brcm80211: remove OFFSETOF macro
...
Use the real 'offsetof' definition instead.
Cc: Brett Rudley <brudley@broadcom.com >
Cc: Henry Ptasinski <henryp@broadcom.com >
Cc: Nohee Ko <noheek@broadcom.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 11:44:45 -07:00
Greg Kroah-Hartman
3ea2f4d640
Staging: brcm80211: remove broken MAX() implementation
...
Use the kernel-provided version, this one is broken.
Note, there are more compiler warnings now, that's due to different
types being compared, which shows how the original macro was wrong in at
least one way. They need to be fixed up.
Cc: Brett Rudley <brudley@broadcom.com >
Cc: Henry Ptasinski <henryp@broadcom.com >
Cc: Nohee Ko <noheek@broadcom.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 11:39:43 -07:00
Greg Kroah-Hartman
7068c2f139
Staging: brcm80211: remove broken MIN() implementation
...
Use the kernel-provided version, this one is broken.
Note, there are more compiler warnings now, that's due to different
types being compared, which shows how the original macro was wrong in at
least one way. They need to be fixed up.
Cc: Brett Rudley <brudley@broadcom.com >
Cc: Henry Ptasinski <henryp@broadcom.com >
Cc: Nohee Ko <noheek@broadcom.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 11:34:59 -07:00
Greg Kroah-Hartman
c03b63c198
Staging: brcm80211: util: remove unneeded usage of uintptr
...
Double casting is pretty pointless, don't do that.
Cc: Brett Rudley <brudley@broadcom.com >
Cc: Henry Ptasinski <henryp@broadcom.com >
Cc: Nohee Ko <noheek@broadcom.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 11:20:01 -07:00
Greg Kroah-Hartman
f1d0fe0abc
Staging: brcm80211: remove unused typedefs in typedefs.h
...
uint is already defined somewhere else, so just remove this version
of it.
Cc: Brett Rudley <brudley@broadcom.com >
Cc: Henry Ptasinski <henryp@broadcom.com >
Cc: Nohee Ko <noheek@broadcom.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 11:13:11 -07:00
Greg Kroah-Hartman
3e26416e2f
Staging: brcm80211: s/int32/s32/
...
Use the kernel types, don't invent your own.
Cc: Brett Rudley <brudley@broadcom.com >
Cc: Henry Ptasinski <henryp@broadcom.com >
Cc: Nohee Ko <noheek@broadcom.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 11:11:13 -07:00
Greg Kroah-Hartman
66cbd3ab35
Staging: brcm80211: s/uint32/u32/
...
Use the kernel types, don't invent your own.
Cc: Brett Rudley <brudley@broadcom.com >
Cc: Henry Ptasinski <henryp@broadcom.com >
Cc: Nohee Ko <noheek@broadcom.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 11:05:47 -07:00
Dan Carpenter
370adc7cb0
Staging: bcm: silence off by one warning
...
"status" is used as an index into the Adapter->PackInfo[] array, which
has NO_OF_QUEUES elements.
This code actually works OK. The SearchSfid() function always returns
a valid index or it returns NO_OF_QUEUES + 1. But it looks sloppy and
it makes the static checkers complain.
Signed-off-by: Dan Carpenter <error27@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:29:57 -07:00
Dan Carpenter
02339374cf
Staging: bcm: remove unneeded NULL check
...
The error handling here is wrong. If psIntfAdapter were NULL then we
would have a NULL dereference in the debug output on the error path.
But this function is only called from usbbcm_device_probe() when
psIntfAdapter is non-NULL.
Since the check isn't needed and I removed it instead of fixing it.
Signed-off-by: Dan Carpenter <error27@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:29:56 -07:00
Dan Carpenter
ef5d205645
Staging: bcm: return -EFAULT on copy_to_user() errors
...
bcm/InterfaceDld.c had a couple places which returned the number of
bytes remaining instead of -EFAULT.
Signed-off-by: Dan Carpenter <error27@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:29:56 -07:00
Dan Carpenter
acedadfae5
Staging: bcm: dereferencing before checking
...
I moved the check to see if "Adapter" was null in front of the
dereference.
Signed-off-by: Dan Carpenter <error27@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:29:55 -07:00
Dan Carpenter
055a1eda5f
Staging: bcm: mocro expansion bug
...
The WIMAX_MAX_MTU macro is used in drivers/staging/bcm/CmHost.c like
this:
if (Adapter->PackInfo[uiSearchRuleIndex].uiMaxBucketSize < WIMAX_MAX_MTU * 8)
The multiplication by eight has precedence over the addition so the
macro needs parenthesis to work.
Signed-off-by: Dan Carpenter <error27@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:29:55 -07:00
Dan Carpenter
785698e38d
Staging: bcm: make major and minor signed
...
We assume that major is signed in register_control_device_interface().
Signed-off-by: Dan Carpenter <error27@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:29:54 -07:00
Dan Carpenter
bf58bd66f6
Staging: bcm: return -EFAULT on copy_to_user() failures
...
There were a number of places in the bcm_char_ioctl() which returned the
number of bytes remaining to be copied instead of returning -EFAULT.
Signed-off-by: Dan Carpenter <error27@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:29:54 -07:00
Tracey Dent
a1823f2ec3
Staging: speakup: devsynth: file_operations should be const
...
Fixed file_operation struct, so that it is const.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:26:25 -07:00
Tracey Dent
1bd15cfd79
Staging: speakup: keyhelp: Coding style fix
...
Put { on previous line, on line 34. Checkpatch.pl caught this.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:26:24 -07:00
Tracey Dent
0c7023b2fb
Staging: speakup: Makefile: Makefile clean up
...
Replaced <modules>-objs with <modules>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:26:24 -07:00
Tracey Dent
8996ba139e
Staging: batman-adv: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y n Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:53 -07:00
Tracey Dent
9a837af5fb
Staging: bcm: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:52 -07:00
Tracey Dent
23d18860db
Staging: comedi: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:52 -07:00
Tracey Dent
1087020fb0
Staging: crystalhd: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:52 -07:00
Tracey Dent
88efaabced
Staging: cx25821: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:51 -07:00
Tracey Dent
77037b4915
Staging: easycap: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:51 -07:00
Tracey Dent
a4f131f07c
Staging: cxt1e1: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:50 -07:00
Tracey Dent
accca6c2f1
Staging: go7007: Makefile: makefile cleanup
...
Changed <module>-objs to <module>-y in Makefile. Also, Replace EXTRA_CFLAGS with ccflags-y
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:50 -07:00
Tracey Dent
bdc1b7bde2
Staging: ft1000:ft1000-pcmia: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:49 -07:00
Tracey Dent
735f48f57d
Staging: et131x: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:49 -07:00
Tracey Dent
23b57e4ae6
Staging: ft1000: ft1000-usb: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:48 -07:00
Tracey Dent
cf5901b3f1
Staging: hv: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:48 -07:00
Tracey Dent
659bd8c1d5
Staging: intel_sst: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:48 -07:00
Tracey Dent
1954cbf0bf
Staging: line6: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:47 -07:00
Tracey Dent
0c26876ea3
Staging: octeon: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:47 -07:00
Tracey Dent
b76d011db1
Staging: rt2870: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:46 -07:00
Tracey Dent
ad52860253
Staging: rt2860: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:46 -07:00
Tracey Dent
79ad8cbfb5
Staging: rtl8187se: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:45 -07:00
Tracey Dent
4580cd7ec2
Staging: rtl8712: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:45 -07:00
Tracey Dent
32a65d4e3b
Staging: sbe-2t3e3: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:45 -07:00
Tracey Dent
5066206242
Staging: smbfs: Makefile: Makefile clean up
...
Changed <module>-objs to <module>-y in Makefile.
Also Replace EXTRA_CFLAGS with ccflags-y.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:44 -07:00
Tracey Dent
a7b1ef250f
Staging: keucr: Makefile: Makefile clean up
...
Changed <module>-objs to <module>-y in Makefile.
Also, Replace EXTRA_CFLAGS with ccflags-y.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:44 -07:00
Tracey Dent
783098ea41
Staging: solo6x10: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:43 -07:00
Tracey Dent
ef3fdeea5d
Staging: wlan-ng: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:43 -07:00
Tracey Dent
aad6b18141
Staging: rtl8192u: Makefile: replace the use of <module>-objs with <module>-y
...
Changed <module>-objs to <module>-y in Makefile.
Signed-off-by: Tracey Dent <tdent48227@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-10-08 07:23:42 -07:00