Need to set dbi writable in the front of rk_pcie_host_config(),
otherwise the test settings couldn't be applied.
Fixes: c54772e75b ("PCI: rockchip: dw: Reorder and document steps of rk_pcie_really_probe()")
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Change-Id: Icb62ef01ab5c16b7a7dba9cb82c9b0cfae5c40d6
Before commit 7f84caccd0 ("PCI: dw: rockchip: Define IO and Host
initialization interfaces"), ret is getting from rk_pcie_disable_power()
which should never fail actually. Now the final ret is getting from
phy_validate() which could return -EOPNOTSUPP. But we didn't care about
it if phy_validate() isn't implemented. So we see:
[ 13.573777] rk-pcie fe150000.pcie: PM: dpm_run_callback(): genpd_suspend_noirq+0x0/0x60 returns -95
[ 13.573800] rk-pcie fe150000.pcie: PM: failed to suspend async: error -95
Fix it by return zero to restore the previous behaviour.
Fixes: 7f84caccd0 ("PCI: dw: rockchip: Define IO and Host initialization interfaces")
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Change-Id: I0c7c858937272f2b09ba4ae79c0a68c7a633ced0
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: Ib0076a2adfa3c85db1c7cb3478c48fc8c4d2bef0
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: Ide15fd8a063238dc0bcea2fee8591132a712ec78
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: I584d3291ed7c6dddfe7660b048ac8217ed8a92b2
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: I3c206728140bccf5ea0de76a16960aa8281d65b9
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: I191c63f514cbc40f5a1c5c3f9d658f452e189e8c
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: I9fa4cf14e900d96ef9ac525ecdc988b4db57bdfb
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: I816919f6d582ef8fb293a0a77a459fe9e6cbe58c
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: I7649b7f62944e89a17dd9c64e140f3578ad6f45e
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: Id0bd930e90dbb0acc848cf52180e54605eddb9c7
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: I833ba214f59006219502e000ad595edcc97a26da
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: Idee74d374e3a56bf7b2679529055e6e717466f4a
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: I1eeceb62c2fd2203649858216ea07c4b55bddba6
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: Ib8582ea151037c5ba0dfef0b3274287bf3c9106e
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: Ie282c8f27d23f49c4028ce3ebf4b5b98977a0c36
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: Ibbb3cfa92f731bf86b1f8e94365122396e419036
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: I0a496232e037563c181189f29ecd4dc818e1a9d4
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: I88965208e607397310b73352e42e965427c8214b
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: I7662058d9ca4fec8773d730c18e0bbb89e1d55a1
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: I28e921149bcf9d3cdd57297b66f9bb53e48fb0ac
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: I81b24c368c8a01b71c4449c470b676dedfaf06d6
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: I76b7d62ba67751707313cc0c6792783b80c1587b
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: I4609b12988d6f4386ee38000688d1ebe6093de29
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: Ib7b39dfc99410dd50c45744fe2b99b315b269c6e
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: Ie9a1839a4d1046f579f1c9786e143a7509155429
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: I0744c0fe06661c81b4eddf25d8ab09c72961a792
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: Ie63b5b477dc7183b6360763cb89e5639aaf07d4e
There are many cases in which the company name is misspelled.
The patch fixes these typos.
Signed-off-by: Tao Huang <huangtao@rock-chips.com>
Change-Id: Ia1da04dc12e6e63167447320b4f877e1f4353e12
With this patch, the error handling of clk_osc initialization
will be more reasonable. Otherwise, the "goto err_pclk" is
meaningless.
Fixes: 19b3f8d830 ("pwm: rockchip: add pwm clk_osc control for wave generator mode")
Change-Id: Ie23ea14eab59f1bb985f3e9d289fe1d0f74545e9
Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
Without this patch, the pclk may not be disabled if failed to
get biphasic counter result.
Fixes: 7a42db27aa ("pwm: rockchip: support for biphasic counter mode")
Change-Id: I5dd279fb1cbfc493531b95181464e2c7d3a4cea9
Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
DPTX may use tcphy0 or tcphy1. If hardware design support
both tcphy0 and tcphy1, then each phy port need a hpd line.
For example, tcphy0 port use GPIO1B5 and tcphy1 port use
GPIO1B6, it should config dts as follow:
&cdn_dp {
...
pinctrl-names = "default";
pinctrl-0 = <&cnd_dp_hpd>;
hpd-gpios = <&gpio1 RK_PB5 GPIO_ACTIVE_HIGH>,
<&gpio1 RK_PB6 GPIO_ACTIVE_HIGH>;
phys = <&tcphy0_dp>, <&tcphy1_dp>;
...
};
&pinctrl {
...
dp {
cdn_dp_hpd: cdn-dp-hpd {
rockchip,pins = <1 RK_PB5 RK_FUNC_GPIO &pcfg_pull_down>,
<1 RK_PB6 RK_FUNC_GPIO &pcfg_pull_down>;
};
};
...
};
If only 1 phy port can be used for DPTX, For example, using
tcphy0 and GPIO1B5 as hpd pin. It should config dts as follow:
&cdn_dp {
...
pinctrl-names = "default";
pinctrl-0 = <&cnd_dp_hpd>;
hpd-gpios = <&gpio1 RK_PB5 GPIO_ACTIVE_HIGH>;
phys = <&tcphy0_dp>;
...
};
&pinctrl {
...
dp {
cdn_dp_hpd: cdn-dp-hpd {
rockchip,pins = <1 RK_PB5 RK_FUNC_GPIO &pcfg_pull_down>;
};
};
...
};
Change-Id: Id1acc428431bb13d7074e9daaab2fcca2ac2782e
Signed-off-by: Zhang Yubing <yubing.zhang@rock-chips.com>
If request firmware in bind stage and the driver go into the
unbind process, it will spend some time to wait timeout. It's
better request firmware after all component bind then request
firmware.
Change-Id: Id76ddb89fb3478bf96e31513578aab3e6ad22781
Signed-off-by: Zhang Yubing <yubing.zhang@rock-chips.com>
The firmware fallback machanism will speed more time to wait
the firmware loading if the firmware is no ready. Ignore firmware
fallback mechanism will reduce some time in this case.
Change-Id: I54245832728c956ea67be9f82cf4abd2ed8fbded
Signed-off-by: Wyon Bi <bivvy.bi@rock-chips.com>
