Martin Kaiser
fe86c3a10c
staging: r8188eu: txirp_cnt is write-only
...
txirp_cnt in struct xmit_priv is initialised but never read. Remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Acked-by: Pavel Skripkin <paskripkin@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20230109212852.75612-9-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:35:25 +01:00
Martin Kaiser
069e3f9441
staging: r8188eu: remove unused hal_xmit_handler define
...
hal_xmit_handler is not used by the r8188eu driver. Remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Acked-by: Pavel Skripkin <paskripkin@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20230109212852.75612-8-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:35:25 +01:00
Martin Kaiser
f2355ab565
staging: r8188eu: dir_dev is unused
...
dir_dev in struct adapter is not used by the r8188eu driver. It can be
removed.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Acked-by: Pavel Skripkin <paskripkin@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20230109212852.75612-7-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:35:24 +01:00
Martin Kaiser
1511463d33
staging: r8188eu: replace switch with if
...
The switch statement in usb_write_port_complete has only one single case.
Replace it with an if statement.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Acked-by: Pavel Skripkin <paskripkin@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20230109212852.75612-6-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:35:24 +01:00
Martin Kaiser
e7b970cc37
staging: r8188eu: voq_cnt is write-only
...
voq_cnt in struct xmit_priv is initialised, incremented and decremented
but never read. Remove voq_cnt and resulting dead code.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Acked-by: Pavel Skripkin <paskripkin@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20230109212852.75612-5-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:35:24 +01:00
Martin Kaiser
763f3eff5e
staging: r8188eu: viq_cnt is write-only
...
viq_cnt in struct xmit_priv is initialised, incremented and decremented
but never read. Remove viq_cnt and resulting dead code.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Acked-by: Pavel Skripkin <paskripkin@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20230109212852.75612-4-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:35:24 +01:00
Martin Kaiser
b79601a0aa
staging: r8188eu: bkq_cnt is write-only
...
bkq_cnt in struct xmit_priv is initialised, incremented and decremented
but never read. Remove bkq_cnt and resulting dead code.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Acked-by: Pavel Skripkin <paskripkin@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20230109212852.75612-3-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:35:24 +01:00
Martin Kaiser
2b9c7fbc1c
staging: r8188eu: beq_cnt is write-only
...
beq_cnt in struct xmit_priv is initialised, incremented and decremented
but never read. Remove beq_cnt and resulting dead code.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Acked-by: Pavel Skripkin <paskripkin@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20230109212852.75612-2-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:35:24 +01:00
Michael Straube
1d0d77f4ec
staging: r8188eu: convert rtw_writeN() to common error logic
...
Convert the function rtw_writeN() away from returning _FAIL or
_SUCCESS which uses inverted error logic. Use the common error logic
instead. Return 0 for success and negative values for failure.
Signed-off-by: Michael Straube <straube.linux@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20230108123804.3754-1-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:35:22 +01:00
Martin Kaiser
5877852e9f
staging: r8188eu: rtw_init_hwxmits is not needed
...
The _rtw_init_xmit_priv function calls rtw_alloc_hwxmits to allocate
memory for pxmitpriv->hwxmits (this is an array of struct hw_xmit). This
allocation uses kzalloc, the allocated memory is initialised with 0.
After the allocation, _rtw_init_xmit_priv calls rtw_init_hwxmits to set an
element of each hw_xmit to 0. This is not necessary, we can remove the
rtw_init_hwxmits call and the now unused function rtw_init_hwxmits.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-20-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:23 +01:00
Martin Kaiser
1b757dfdab
staging: r8188eu: phwxmit parameter is unused
...
Remove the unused function parameter phwxmit from function
dequeue_one_xmitframe.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-19-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:23 +01:00
Martin Kaiser
51cbbb0efe
staging: r8188eu: remove unnecessary rtw_free_xmitframe call
...
There's no need to call rtw_free_xmitframe before we dequeue the first
frame. pxmitframe is always NULL at this point, rtw_free_xmitframe will do
nothing in this case.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-18-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:23 +01:00
Martin Kaiser
26cf6c2c22
staging: r8188eu: tx_retevt semaphore is not used
...
Remove tx_retevt from struct xmit_priv. This semaphore is initialised but
not used.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-17-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:23 +01:00
Martin Kaiser
38a9b8372e
staging: r8188eu: terminate_xmitthread_sema is not used
...
Remove terminate_xmitthread_sema from struct xmit_priv. This semaphore is
initialised but not used.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-16-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:22 +01:00
Martin Kaiser
fcef1518e6
staging: r8188eu: bm_pending is not used
...
The bm_pending queue in struct xmit_priv is initialised but not used. It
can be removed.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-15-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:22 +01:00
Martin Kaiser
61d6aec28c
staging: r8188eu: remove unused dma_transfer_addr
...
The dma_transfer_addr component in struct xmit_buf is initialised but not
used. Remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-14-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:22 +01:00
Martin Kaiser
3de5122ccf
staging: r8188eu: remove unused bpending array
...
The bpending array in struct xmit_buf is unused. Remove it.
(struct xmit_buf is not part of the interface between the kernel driver and
the device's firmware. It's safe to remove components from this struct.)
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-13-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:22 +01:00
Martin Kaiser
3d1edfe65d
staging: r8188eu: clean up qos_option setting
...
The qos_option variable in function rtw_make_wlanhdr should be a boolean
as it's set to true or false. We can directly set it to
pqospriv->qos_option instead of using a default value and if statements.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-12-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:22 +01:00
Martin Kaiser
a6b25e291f
staging: r8188eu: simplify rtw_make_wlanhdr's error handling
...
Simplify the error handling in rtw_make_wlanhdr. Exit immediately instead
of jumping to the end of the function. We don't have to do any clean-up.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-11-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:22 +01:00
Martin Kaiser
e263d79eb1
staging: r8188eu: simplify frame type check
...
Reorder the code in rtw_make_wlanhdr to make the function simpler.
There's a large if statement to check that we process only data frames.
Revert the condition and exit for non-data frames.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-10-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:22 +01:00
Martin Kaiser
6dd8420d4b
staging: r8188eu: remove duplicate psta check
...
We do not need the psta check in the while loop of rtw_xmitframe_coalesce.
psta is already checked near the start of the function and is not modified
afterwards.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-9-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:22 +01:00
Martin Kaiser
a8dce6b4ad
staging: r8188eu: remove rtl8188eu_init_xmit_priv
...
rtl8188eu_init_xmit_priv's only jobs is to initialise the xmit tasklet.
Remove rtl8188eu_init_xmit_priv and initialise the xmit tasklet in
_rtw_init_xmit_priv. Yet again, this makes the code a tiny bit smaller.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-8-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:22 +01:00
Martin Kaiser
9431a9370f
staging: r8188eu: simplify rtl8188eu_xmit_tasklet
...
Simplify the rtl8188eu_xmit_tasklet function. Remove an unnecessary
temporary variable and reformat the code.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-7-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:22 +01:00
Martin Kaiser
4126f99b9e
staging: r8188eu: remove unused parameter
...
All callers of rtl8188eu_xmitframe_complete set the pxmitbuf parameter to
NULL, in which case rtl8188eu_xmitframe_complete allocates another
xmit_buf internally.
Remove the pxmitbuf parameter and resulting dead code.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-6-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:22 +01:00
Martin Kaiser
c22afb2e5d
staging: r8188eu: return immediately if we're not meant to encrypt
...
In function xmitframe_swencrypt, we can return immediately if our packet
needs no encryption. This is simpler than wrapping all the code into a
large if statement.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-5-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:21 +01:00
Martin Kaiser
00df407396
staging: r8188eu: cmd_seq is write-only
...
The cmd_seq component of struct cmd_priv is set and incremented but never
read. It can be removed.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-4-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:21 +01:00
Martin Kaiser
55074f02b4
staging: r8188eu: remove some unused CAM defines
...
Remove some CAM-related defines which are not used in the r8188eu driver.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-3-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:21 +01:00
Martin Kaiser
75f697b361
staging: r8188eu: make xmitframe_swencrypt a void function
...
xmitframe_swencrypt always returns _SUCCESS and the caller does not check
the return value. We can remove the return value and make
xmitframe_swencrypt a void function.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230180646.91008-2-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:21 +01:00
Martin Kaiser
6803d6cdf2
staging: r8188eu: remove intermediate token variable
...
Remove the token variable in on_action_public and use frame_body[2] as
function parameter. This saves another few lines of code.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230175326.90617-5-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:11 +01:00
Martin Kaiser
0a663eafa1
staging: r8188eu: remove intermediate pframe pointer
...
The pframe pointer in on_action_public is used only in the definition of
frame_body, which points to the payload of an incoming action frame.
We can use mgmt to locate the action payload and remove the pframe
pointer.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230175326.90617-4-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:11 +01:00
Martin Kaiser
0c9adc24ea
staging: r8188eu: merge on_action_public_default into its only caller
...
Merge on_action_public_default into on_action_public, which is the only
caller. Yet again, this makes the code a tiny bit smaller.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230175326.90617-3-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:11 +01:00
Martin Kaiser
51413ad540
staging: r8188eu: merge on_action_public_vendor into its caller
...
Apart from declaring variables, on_action_public_vendor is only an if
statement. Merge this function into its only caller. This makes the code a
tiny bit smaller.
Signed-off-by: Martin Kaiser <martin@kaiser.cx >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Link: https://lore.kernel.org/r/20221230175326.90617-2-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:11 +01:00
Xu Panda
78dde77b22
staging: r8188eu: use strscpy() to instead of strncpy()
...
The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL-terminated strings.
Signed-off-by: Xu Panda <xu.panda@zte.com.cn >
Signed-off-by: Yang Yang <yang.yang29@zte.com >
Reviewed-by: Dan Carpenter <error27@gmail.com >
Link: https://lore.kernel.org/r/202212261905476729002@zte.com.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:08 +01:00
Kang Minchul
799468fb50
staging: r8188eu: Prefer kcalloc over kzalloc
...
Fixed following checkpatch.pl warning:
* WARNING: Prefer kcalloc over kzalloc with multiply
Instead of specifying (number of bytes) * (size) as arugment
in kzalloc, prefer kcalloc.
Signed-off-by: Kang Minchul <tegongkang@gmail.com >
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com > # Edimax N150
Reviewed-by: Martin Kaiser <martin@kaiser.cx >
Link: https://lore.kernel.org/r/20221216223942.334221-1-tegongkang@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:31:05 +01:00
Philipp Hortmann
1cd8fbfafd
staging: rtl8192e: Rename EEPROMTxPower.., AutoloadF.. and SilentReset..
...
Rename variable SilentResetRxSlotIndex to silent_reset_rx_slot_index,
IC_Cut to ic_cut and Rf_Mode to rf_mode to avoid CamelCase which is not
accepted by checkpatch.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/60c1fb2861143c8736f061cf85e737b78c210a09.1673812850.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:29:04 +01:00
Philipp Hortmann
69c382a5e0
staging: rtl8192e: Rename EEPROMTxPower.., AutoloadF.. and SilentReset..
...
Rename variable EEPROMTxPowerLevelCCK to eeprom_tx_pwr_level_cck,
AutoloadFailFlag to autoload_fail_flag and SilentResetRxStuckEvent to
silent_reset_rx_stuck_event to avoid CamelCase which is not accepted by
checkpatch.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/328bdd5fd16ba000d2083473e16e89ce2e2521ee.1673812850.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:29:04 +01:00
Philipp Hortmann
0f9d51975f
staging: rtl8192e: Rename EEPROMTherma.., EEPROMAntPw.. and EEPROMTxPow..
...
Rename variable EEPROMThermalMeter to eeprom_thermal_meter,
EEPROMAntPwDiff to eeprom_ant_pwr_diff and EEPROMTxPowerLevelOFDM24G to
eeprom_tx_pwr_level_ofdm24g to avoid CamelCase which is not accepted by
checkpatch.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/f708533cc24af1e08f34b681b9e8e8c01dc7b8f5.1673812850.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:29:04 +01:00
Philipp Hortmann
ca17bcc740
staging: rtl8192e: Rename CrystalCap, EEPROMLegacyHTT.. and EEPROMCrys..
...
Rename variable CrystalCap to crystal_cap, EEPROMLegacyHTTxPowerDiff to
eeprom_legacy_ht_tx_pwr_diff and EEPROMCrystalCap to eeprom_crystal_cap
to avoid CamelCase which is not accepted by checkpatch.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/16337153218e9d1e25f90ca17774d1246086f1a7.1673812849.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:29:04 +01:00
Philipp Hortmann
cc7c9cb659
staging: rtl8192e: Rename SetBWModeIn.., SwChnlInPro.. and ThermalMet..
...
Rename variable SetBWModeInProgress to set_bw_mode_in_progress,
SwChnlInProgress to sw_chnl_in_progress and ThermalMeter to thermal_meter
to avoid CamelCase which is not accepted by checkpatch.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/fc8bffbef60dba7aeb3bdfeab031c4e02e551c82.1673812849.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:29:03 +01:00
Philipp Hortmann
18651492d5
staging: rtl8192e: Rename bResetInPro.., framesyncMo.. and nCur40MhzPri..
...
Rename variable bResetInProgress to reset_in_progress, framesyncMonitor to
frame_sync_monitor and nCur40MhzPrimeSC to n_cur_40mhz_prime_sc to avoid
CamelCase which is not accepted by checkpatch.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/dc9a6353e2342f524d8cbf0de6a6340990dc913b.1673812849.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:29:03 +01:00
Philipp Hortmann
d7e065b3e2
staging: rtl8192e: Rename rateCountDi.., ContinueDif.. and TxCounter
...
Rename variable rateCountDiffRecord to rate_count_diff_rec,
ContinueDiffCount to continue_diff_count and TxCounter to tx_counter to
avoid CamelCase which is not accepted by checkpatch.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/c1e168e60a987ae64b64490c04ad79fd0f2f7583.1673812849.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:29:03 +01:00
Philipp Hortmann
a9b97927cc
staging: rtl8192e: Rename Record_CCK_2.., Record_CCK_4.. and DefaultIn..
...
Rename variable Record_CCK_20Mindex to rec_cck_20m_idx,
Record_CCK_40Mindex to rec_cck_40m_idx and DefaultInitialGain to
def_initial_gain to avoid CamelCase which is not accepted by checkpatch.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/2963e704afae2382bb7fded0453adbc4a8d48db3.1673812849.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:29:03 +01:00
Philipp Hortmann
a6ee5b0af1
staging: rtl8192e: Rename bLastDTPFlag_Low, OFDM_index and CCK_index
...
Rename variable bLastDTPFlag_Low to last_dtp_flag_low, OFDM_index to
ofdm_index and CCK_index to cck_index to avoid CamelCase which is not
accepted by checkpatch.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/1058b8be954b634f5c2cd9d4a46c33dbbe9459c5.1673812849.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:29:03 +01:00
Philipp Hortmann
5a64c4d626
staging: rtl8192e: Rename bDynamicTxHig.., bDynamicTxL.. and bLastDTPF..
...
Rename variable bDynamicTxHighPower to dynamic_tx_high_pwr,
bDynamicTxLowPower to dynamic_tx_low_pwr and bLastDTPFlag_High to
last_dtp_flag_high to avoid CamelCase which is not accepted by checkpatch.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/585a76cf4d2c805eada805c18c18ef207b9a4ea4.1673812849.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:29:03 +01:00
Philipp Hortmann
c34e856b7f
staging: rtl8192e: Rename SetRFPowerSta.., RfReg0Value and bTXPowerDa..
...
Rename variable SetRFPowerStateInProgress to set_rf_pwr_state_in_progress,
RfReg0Value to rf_reg_0value and bTXPowerDataReadFromEEPORM to
tx_pwr_data_read_from_eeprom to avoid CamelCase which is not accepted by
checkpatch.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/01ff54a2c135ba6e3d06255102679d496fd2aef1.1673290428.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:28:51 +01:00
Philipp Hortmann
b2779cbaee
staging: rtl8192e: Rename MCSTxPowerL.., LegacyHTTxPowe.. and AntennaTx..
...
Rename variable MCSTxPowerLevelOriginalOffset to
mcs_tx_pwr_level_org_offset, LegacyHTTxPowerDiff to legacy_ht_tx_pwr_diff
and AntennaTxPwDiff to antenna_tx_pwr_diff to avoid CamelCase which is not
accepted by checkpatch.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/271b3a9e1c23593e9ead925eb8415a584058fb56.1673290428.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:28:51 +01:00
Philipp Hortmann
b1465f9bcc
staging: rtl8192e: Rename TxPowerLevelOFDM24G...
...
Rename variable TxPowerLevelOFDM24G to tx_pwr_level_ofdm_24g,
TxPowerLevelOFDM24G_A to tx_pwr_level_ofdm_24g_a and TxPowerLevelOFDM24G_C
to tx_pwr_level_ofdm_24g_c to avoid CamelCase which is not accepted by
checkpatch.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/6bb354bd6f6387a26378de3b154d975b826a1a88.1673290428.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:28:50 +01:00
Philipp Hortmann
e941c9cefd
staging: rtl8192e: Rename TxPowerLevelCCK...
...
Rename variable TxPowerLevelCCK to tx_pwr_level_cck, TxPowerLevelCCK_A to
tx_pwr_level_cck_a and TxPowerLevelCCK_C to tx_pwr_level_cck_c to avoid
CamelCase which is not accepted by checkpatch.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/c18af327debcf85f3498be9c7a1492d501748669.1673290428.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:28:50 +01:00
Philipp Hortmann
6def63e4b4
staging: rtl8192e: Rename CCKPresentAtt...
...
Rename variable CCKPresentAttentuation_20Mdefault to
cck_present_attn_20m_def, CCKPresentAttentuation_40Mdefault to
cck_present_attn_40m_def and CCKPresentAttentuation_difference to
cck_present_attn_diff to avoid CamelCase which is not accepted by
checkpatch.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/1254f23aefd25075ef3e16719eed79b461f41e4c.1673290428.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:28:50 +01:00
Philipp Hortmann
48ca41d388
staging: rtl8192e: Rename TSSI_13dBm, Pwr_Track and NumTotalRFPath
...
Rename variable TSSI_13dBm to tssi_13dBm, Pwr_Track to pwr_track and
NumTotalRFPath to num_total_rf_path to avoid CamelCase which is not
accepted by checkpatch.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com >
Link: https://lore.kernel.org/r/d3bb45535b7babd1cb8df437ca238eb0ce93c9fe.1673290428.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2023-01-17 19:28:50 +01:00