Shakeel Butt
9abd7eae28
mm/list_lru.c: fix memory leak in __memcg_init_list_lru_node
commit 3510955b32 upstream.
Syzbot reported following memory leak:
ffffffffda RBX: 0000000000000003 RCX: 0000000000441f79
BUG: memory leak
unreferenced object 0xffff888114f26040 (size 32):
comm "syz-executor626", pid 7056, jiffies 4294948701 (age 39.410s)
hex dump (first 32 bytes):
40 60 f2 14 81 88 ff ff 40 60 f2 14 81 88 ff ff @`......@`......
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
slab_post_alloc_hook mm/slab.h:439 [inline]
slab_alloc mm/slab.c:3326 [inline]
kmem_cache_alloc_trace+0x13d/0x280 mm/slab.c:3553
kmalloc include/linux/slab.h:547 [inline]
__memcg_init_list_lru_node+0x58/0xf0 mm/list_lru.c:352
memcg_init_list_lru_node mm/list_lru.c:375 [inline]
memcg_init_list_lru mm/list_lru.c:459 [inline]
__list_lru_init+0x193/0x2a0 mm/list_lru.c:626
alloc_super+0x2e0/0x310 fs/super.c:269
sget_userns+0x94/0x2a0 fs/super.c:609
sget+0x8d/0xb0 fs/super.c:660
mount_nodev+0x31/0xb0 fs/super.c:1387
fuse_mount+0x2d/0x40 fs/fuse/inode.c:1236
legacy_get_tree+0x27/0x80 fs/fs_context.c:661
vfs_get_tree+0x2e/0x120 fs/super.c:1476
do_new_mount fs/namespace.c:2790 [inline]
do_mount+0x932/0xc50 fs/namespace.c:3110
ksys_mount+0xab/0x120 fs/namespace.c:3319
__do_sys_mount fs/namespace.c:3333 [inline]
__se_sys_mount fs/namespace.c:3330 [inline]
__x64_sys_mount+0x26/0x30 fs/namespace.c:3330
do_syscall_64+0x76/0x1a0 arch/x86/entry/common.c:301
entry_SYSCALL_64_after_hwframe+0x44/0xa9
This is a simple off by one bug on the error path.
Link: http://lkml.kernel.org/r/20190528043202.99980-1-shakeelb@google.com
Fixes: 60d3fd32a7 ("list_lru: introduce per-memcg lists")
Reported-by: syzbot+f90a420dfe2b1b03cb2c@syzkaller.appspotmail.com
Signed-off-by: Shakeel Butt <shakeelb@google.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: Kirill Tkhai <ktkhai@virtuozzo.com>
Cc: <stable@vger.kernel.org> [4.0+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-05-15 13:48:37 +09:00
..
2023-05-15 12:37:55 +09:00
2023-05-15 12:52:00 +09:00
2016-07-26 16:19:19 -07:00
2016-10-11 15:06:33 -07:00
2016-01-27 09:09:57 -05:00
2023-05-15 13:47:15 +09:00
2023-05-15 13:47:13 +09:00
2018-11-05 05:36:36 -07:00
2020-02-04 13:48:58 +09:00
2016-03-17 15:09:34 -07:00
2023-05-15 08:15:04 +09:00
2016-03-17 15:09:34 -07:00
2018-02-25 11:05:49 +01:00
2023-05-12 17:25:57 +09:00
2016-03-15 16:55:16 -07:00
2018-04-24 11:26:46 +02:00
2023-05-15 09:13:14 +09:00
2016-07-26 16:19:19 -07:00
2023-05-15 13:40:39 +09:00
2016-05-19 19:12:14 -07:00
2023-05-15 10:04:53 +09:00
2016-05-20 17:58:30 -07:00
2023-05-15 13:47:09 +09:00
2017-01-06 10:40:13 +01:00
2020-12-17 17:23:23 +09:00
2018-05-22 16:57:57 +02:00
2016-09-13 02:35:27 +02:00
2023-05-15 10:04:59 +09:00
2016-03-17 15:09:34 -07:00
2016-03-17 15:09:34 -07:00
2020-12-17 17:23:23 +09:00
2020-02-04 13:48:58 +09:00
2023-05-15 13:48:37 +09:00
2016-05-22 17:21:27 -07:00
2023-05-15 08:33:50 +09:00
2016-10-12 10:23:41 -07:00
2017-08-30 10:21:47 +02:00
2023-05-12 17:14:41 +09:00
2023-05-15 11:50:40 +09:00
2023-05-15 12:06:12 +09:00
2023-05-15 11:34:46 +09:00
2023-05-15 12:16:43 +09:00
2016-07-28 16:07:41 -07:00
2023-05-15 11:50:08 +09:00
2023-05-15 12:51:27 +09:00
2017-06-07 12:37:47 +02:00
2016-03-17 15:09:34 -07:00
2023-05-15 11:45:49 +09:00
2016-04-28 11:44:19 +02:00
2016-03-17 15:09:34 -07:00
2018-04-17 17:58:08 -08:00
2023-05-12 16:53:04 +09:00
2020-12-17 17:23:22 +09:00
2017-08-24 17:12:19 -07:00
2017-01-06 10:40:13 +01:00
2023-05-15 11:24:09 +09:00
2023-05-15 13:47:11 +09:00
2023-05-15 12:16:51 +09:00
2016-07-28 16:07:41 -07:00
2016-10-07 18:46:29 -07:00
2018-03-05 15:34:36 +08:00
2016-10-07 18:46:27 -07:00
2016-06-03 15:06:22 -07:00
2023-05-15 11:05:30 +09:00
2017-11-24 08:33:42 +01:00
2016-03-17 15:09:34 -07:00
2023-05-15 12:28:14 +09:00
2016-03-17 15:09:34 -07:00
2016-10-18 14:13:37 -07:00
2016-03-17 15:09:34 -07:00
2018-04-24 17:43:19 +08:00
2023-05-15 09:27:49 +09:00
2023-05-15 12:05:41 +09:00
2023-05-15 09:57:36 +09:00
2023-05-15 13:47:17 +09:00
2017-03-22 12:43:38 +01:00
2017-03-22 12:43:38 +01:00
2023-05-15 08:29:33 +09:00
2016-08-02 17:31:41 -04:00
2017-10-21 17:21:36 +02:00
2017-07-05 14:40:17 +02:00
2020-02-04 13:48:58 +09:00
2018-04-17 17:58:08 -08:00
2023-05-12 16:53:07 +09:00
2023-05-15 10:06:15 +09:00
2016-09-20 16:07:39 -07:00
2016-04-04 10:41:08 -07:00
2023-05-15 11:00:59 +09:00
2020-02-04 13:48:58 +09:00
2023-05-15 12:16:51 +09:00
2017-03-12 06:41:43 +01:00
2023-05-15 08:11:03 +09:00
2023-05-15 12:28:09 +09:00
2017-04-08 09:30:36 +02:00
2016-06-03 16:02:55 -07:00
2023-05-15 11:45:16 +09:00
2023-05-12 17:14:18 +09:00