mirror of
https://github.com/hardkernel/linux.git
synced 2026-06-07 11:26:02 +09:00
a3d49e9543
This patch switch pinctrl to idle state when runtime suspend.
At the moment, it's used for workaround for I2S0/2/3 (PD_AUDIO)
slave IO issue on RK3588 SoCs.
The issue acts like that when PD_AUDIO off, the BCLK/LRCK pin
will pull down the external clk to half-level.
The root cause is that when PD_AUDIO off, the BCLK/LRCK pin
are clamped as drive output low.
This patch also try to solve clk leak for master output mode.
OTOH, the ASoC framework set pinctrl state first and then do
runtime PM resume (enable PD). it's reasonable, but for the
current issue, a few half-level cycles leak after resume, so,
we split pinctrl-clk out to control it separately.
snd_pcm_open
for_each_rtd_components(rtd, i, component)
pinctrl_pm_select_default_state(component->dev);
ret = snd_soc_pcm_component_pm_runtime_get(rtd, substream);
e.g. pinctrl idle for i2s0
i2s0_gpio: i2s0-gpio {
rockchip,pins =
/* i2s0_lrck_gpio */
<1 RK_PC5 0 &pcfg_pull_none>,
/* i2s0_sclk_gpio */
<1 RK_PC3 0 &pcfg_pull_none>;
};
&i2s0_8ch {
pinctrl-names = "default", "idle", "clk";
pinctrl-1 = <&i2s0_gpio>;
pinctrl-2 = <&i2s0_lrck
&i2s0_sclk>;
};
cat /sys/kernel/debug/pinctrl/pinctrl-handles
device: fe470000.i2s current state: idle
state: default
type: MUX_GROUP controller rockchip-pinctrl group: i2s0-sdi0 (26) function: i2s0 (24)
type: CONFIGS_PIN controller rockchip-pinctrl pin gpio1-28 (60)config 00000001
type: MUX_GROUP controller rockchip-pinctrl group: i2s0-sdi1 (27) function: i2s0 (24)
type: CONFIGS_PIN controller rockchip-pinctrl pin gpio1-27 (59)config 00000001
type: MUX_GROUP controller rockchip-pinctrl group: i2s0-sdi2 (28) function: i2s0 (24)
type: CONFIGS_PIN controller rockchip-pinctrl pin gpio1-26 (58)config 00000001
type: MUX_GROUP controller rockchip-pinctrl group: i2s0-sdi3 (29) function: i2s0 (24)
type: CONFIGS_PIN controller rockchip-pinctrl pin gpio1-25 (57)config 00000001
type: MUX_GROUP controller rockchip-pinctrl group: i2s0-sdo0 (30) function: i2s0 (24)
type: CONFIGS_PIN controller rockchip-pinctrl pin gpio1-23 (55)config 00000001
type: MUX_GROUP controller rockchip-pinctrl group: i2s0-sdo1 (31) function: i2s0 (24)
type: CONFIGS_PIN controller rockchip-pinctrl pin gpio1-24 (56)config 00000001
state: idle
type: MUX_GROUP controller rockchip-pinctrl group: i2s0-idle (23) function: i2s0 (24)
type: CONFIGS_PIN controller rockchip-pinctrl pin gpio1-21 (53)config 00000001
type: CONFIGS_PIN controller rockchip-pinctrl pin gpio1-19 (51)config 00000001
state: clk
type: MUX_GROUP controller rockchip-pinctrl group: i2s0-lrck (24) function: i2s0 (24)
type: CONFIGS_PIN controller rockchip-pinctrl pin gpio1-21 (53)config 00000001
type: MUX_GROUP controller rockchip-pinctrl group: i2s0-sclk (25) function: i2s0 (24)
type: CONFIGS_PIN controller rockchip-pinctrl pin gpio1-19 (51)config 00000001
Fixes: 89e11e98f4 ("arm64: dts: rockchip: rk3588: Add pinctrl idle for I2S0/2/3")
Change-Id: I41dcdabd8e4015c7bd7285a03a24a3765a0b576f
Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>
Linux kernel
============
There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.
In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``. The formatted documentation can also be read online at:
https://www.kernel.org/doc/html/latest/
There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.
Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.