Files
linux/drivers
Vasilis Liaskovitis 3e7625d505 xen/blkfront: avoid NULL blkfront_info dereference on device removal
commit f92898e7f3 upstream.

If a block device is hot-added when we are out of grants,
gnttab_grant_foreign_access fails with -ENOSPC (log message "28
granting access to ring page") in this code path:

  talk_to_blkback ->
	setup_blkring ->
		xenbus_grant_ring ->
			gnttab_grant_foreign_access

and the failing path in talk_to_blkback sets the driver_data to NULL:

 destroy_blkring:
        blkif_free(info, 0);

        mutex_lock(&blkfront_mutex);
        free_info(info);
        mutex_unlock(&blkfront_mutex);

        dev_set_drvdata(&dev->dev, NULL);

This results in a NULL pointer BUG when blkfront_remove and blkif_free
try to access the failing device's NULL struct blkfront_info.

Cc: stable@vger.kernel.org # 4.5 and later
Signed-off-by: Vasilis Liaskovitis <vliaskovitis@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-05-15 09:20:29 +09:00
..
2023-05-12 16:27:16 +09:00
2023-05-12 16:28:00 +09:00
2018-07-03 18:27:19 +02:00
2018-05-30 13:19:56 +02:00
2023-05-12 16:57:29 +09:00
2023-05-15 09:20:11 +09:00
2018-05-25 17:06:35 +02:00
2023-05-15 09:20:07 +09:00
2023-05-12 17:05:02 +09:00
2023-05-15 09:15:17 +09:00
2023-05-15 08:28:33 +09:00
2023-05-15 09:15:03 +09:00
2018-07-03 18:27:19 +02:00