mirror of
https://github.com/hardkernel/linux.git
synced 2026-06-05 10:31:46 +09:00
c8de2ce6ad
If the property 'rockchip,plane-mask' exists but the
property 'rockchip,primary-plane' is not set in DTS, the
default &vop2_video_port.primary_plane_phy_id should be
ROCKCHIP_VOP2_PHY_ID_INVALID to avoid unexpected logs.
For RK3576 as example, if the plane_mask is configured as
follows:
&vp0 {
rockchip,plane-mask = <(1 << ROCKCHIP_VOP2_CLUSTER0 | 1 << ROCKCHIP_VOP2_ESMART0)>;
};
&vp1 {
rockchip,plane-mask = <(1 << ROCKCHIP_VOP2_CLUSTER1 | 1 << ROCKCHIP_VOP2_ESMART1)>;
};
&vp2 {
rockchip,plane-mask = <(1 << ROCKCHIP_VOP2_ESMART3 | 1 << ROCKCHIP_VOP2_ESMART2)>;
};
The unexpected logs may appear:
......
[ 2.457617][ T80] rockchip-vop2 27d00000.vop: [drm:vop2_bind] vp0 assign plane mask: Cluster0 | Esmart0[0x5], primary plane phy id: Cluster0[0]
[ 2.457652][ T80] rockchip-vop2 27d00000.vop: [drm:vop2_bind] vp1 assign plane mask: Cluster1 | Esmart1[0xa], primary plane phy id: Cluster0[0]
[ 2.457666][ T80] rockchip-vop2 27d00000.vop: [drm:vop2_bind] vp2 assign plane mask: Esmart2 | Esmart3[0x300], primary plane phy id: Cluster0[0]
......
It is better to be like:
[ 2.473158][ T80] rockchip-vop2 27d00000.vop: [drm:vop2_bind] vp0 assign plane mask: Cluster0 | Esmart0[0x5], primary plane phy id: INVALID[-1]
[ 2.473189][ T80] rockchip-vop2 27d00000.vop: [drm:vop2_bind] vp1 assign plane mask: Cluster1 | Esmart1[0xa], primary plane phy id: INVALID[-1]
[ 2.473204][ T80] rockchip-vop2 27d00000.vop: [drm:vop2_bind] vp2 assign plane mask: Esmart2 | Esmart3[0x300], primary plane phy id: INVALID[-1]
Change-Id: I28d221cce9baa6c1f73e6d73acdd030e92cc88bc
Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
Linux kernel
============
There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.
In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``. The formatted documentation can also be read online at:
https://www.kernel.org/doc/html/latest/
There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.
Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.