Files
linux/drivers
Denis Efremov ddd64dd895 floppy: fix out-of-bounds read in copy_buffer
[ Upstream commit da99466ac2 ]

This fixes a global out-of-bounds read access in the copy_buffer
function of the floppy driver.

The FDDEFPRM ioctl allows one to set the geometry of a disk.  The sect
and head fields (unsigned int) of the floppy_drive structure are used to
compute the max_sector (int) in the make_raw_rw_request function.  It is
possible to overflow the max_sector.  Next, max_sector is passed to the
copy_buffer function and used in one of the memcpy calls.

An unprivileged user could trigger the bug if the device is accessible,
but requires a floppy disk to be inserted.

The patch adds the check for the .sect * .head multiplication for not
overflowing in the set_geometry function.

The bug was found by syzkaller.

Signed-off-by: Denis Efremov <efremov@ispras.ru>
Tested-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-05-15 14:02:36 +09:00
..
2023-05-15 12:46:28 +09:00
2023-05-12 16:27:16 +09:00
2023-05-15 13:57:04 +09:00
2023-05-15 10:39:04 +09:00
2023-05-15 12:46:28 +09:00
2017-09-09 17:39:41 +02:00
2018-05-25 17:06:35 +02:00
2023-05-15 10:37:00 +09:00
2023-05-15 09:23:01 +09:00
2023-05-15 09:51:46 +09:00
2023-05-15 08:28:33 +09:00
2023-05-15 13:00:07 +09:00