shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-09 04:10:18 +09:00
Code Issues Packages Projects Releases Wiki Activity
Files
e7d0bd359f4cdf2b0eb99cd9659ec809e2646141
linux/fs
History
Trond Myklebust 181feb41f0 NFS: Fix a race when updating an existing write 
commit 76d2e3890fb169168c73f2e4f8375c7cc24a765e upstream.

After nfs_lock_and_join_requests() tests for whether the request is
still attached to the mapping, nothing prevents a call to
nfs_inode_remove_request() from succeeding until we actually lock the
page group.
The reason is that whoever called nfs_inode_remove_request() doesn't
necessarily have a lock on the page group head.

So in order to avoid races, let's take the page group lock earlier in
nfs_lock_and_join_requests(), and hold it across the removal of the
request in nfs_inode_remove_request().

Reported-by: Jeff Layton <jlayton@kernel.org>
Tested-by: Joe Quanaim <jdq@meta.com>
Tested-by: Andrew Steffen <aksteffen@meta.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Fixes: bd37d6fce1 ("NFSv4: Convert nfs_lock_and_join_requests() to use nfs_page_find_head_request()")
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2025-09-04 15:30:20 +02:00
..
9p
fs/9p: fix uninitialized values during inode evict
2024-11-22 15:38:37 +01:00
adfs
Merge tag 'for-6.6/block-2023-08-28' of git://git.kernel.dk/linux
2023-08-29 20:21:42 -07:00
affs
affs: don't write overlarge OFS data block size fields
2025-04-10 14:37:37 +02:00
afs
afs: Fix the server_list to unuse a displaced server rather than putting it
2025-03-07 16:45:38 +01:00
autofs
Merge tag 'v6.6-vfs.autofs' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs
2023-08-28 11:39:14 -07:00
befs
Merge tag 'for-6.6/block-2023-08-28' of git://git.kernel.dk/linux
2023-08-29 20:21:42 -07:00
bfs
Merge tag 'for-6.6/block-2023-08-28' of git://git.kernel.dk/linux
2023-08-29 20:21:42 -07:00
btrfs
btrfs: send: make fs_path_len() inline and constify its argument
2025-08-28 16:28:41 +02:00
cachefiles
cachefiles: Fix the incorrect return value in __cachefiles_write()
2025-07-24 08:53:16 +02:00
ceph
ceph: fix possible integer overflow in ceph_zero_objects()
2025-07-06 11:00:08 +02:00
coda
Merge tag 'v6.6-vfs.ctime' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs
2023-08-28 09:31:32 -07:00
configfs
configfs: Do not override creating attribute file failure in populate_attrs()
2025-06-27 11:08:42 +01:00
cramfs
fs: Convert to bdev_open_by_dev()
2024-08-19 06:04:25 +02:00
crypto
fscrypt: Don't use problematic non-inline crypto engines
2025-08-28 16:28:40 +02:00
debugfs
debugfs: fix automount d_fsdata usage
2024-01-20 11:51:37 +01:00
devpts
Merge tag 'v6.6-vfs.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs
2023-08-28 10:17:14 -07:00
dlm
dlm: make tcp still work in multi-link env
2025-06-04 14:41:57 +02:00
ecryptfs
fs: Create a generic is_dot_dotdot() utility
2024-10-04 16:29:48 +02:00
efivarfs
efivarfs: Fix error on non-existent file
2024-12-27 13:58:50 +01:00
efs
Merge tag 'for-6.6/block-2023-08-28' of git://git.kernel.dk/linux
2023-08-29 20:21:42 -07:00
erofs
erofs: fix atomic context detection when !CONFIG_DEBUG_LOCK_ALLOC
2025-09-04 15:30:19 +02:00
exfat
exfat: add cluster chain loop check for dir
2025-08-28 16:28:28 +02:00
exportfs
exportfs: remove kernel-doc warnings in exportfs
2023-08-29 17:45:22 -04:00
ext2
ext2: Handle fiemap on empty files to prevent EINVAL
2025-08-28 16:28:15 +02:00
ext4
ext4: preserve SB_I_VERSION on remount
2025-08-28 16:28:44 +02:00
f2fs
f2fs: fix to avoid out-of-boundary access in dnode page
2025-08-28 16:28:36 +02:00
fat
fat: fix uninitialized variable
2024-10-22 15:46:20 +02:00
freevxfs
Merge tag 'for-6.6/block-2023-08-28' of git://git.kernel.dk/linux
2023-08-29 20:21:42 -07:00
fscache
netfs/fscache: Add a memory barrier for FSCACHE_VOLUME_CREATING
2024-12-09 10:31:45 +01:00
fuse
fuse: fix race between concurrent setattrs from multiple nodes
2025-07-06 11:00:06 +02:00
gfs2
gfs2: Set .migrate_folio in gfs2_{rgrp,meta}_aops
2025-08-28 16:28:15 +02:00
hfs
hfs: fix not erasing deleted b-tree node issue
2025-08-28 16:28:15 +02:00
hfsplus
hfsplus: don't use BUG_ON() in hfsplus_create_attributes_file()
2025-08-28 16:28:14 +02:00
hostfs
um: hostfs: avoid issues on inode number reuse by host
2025-04-10 14:37:34 +02:00
hpfs
Merge tag 'for-6.6/block-2023-08-28' of git://git.kernel.dk/linux
2023-08-29 20:21:42 -07:00
hugetlbfs
mm: update memfd seal write check to include F_SEAL_WRITE
2025-08-28 16:28:39 +02:00
iomap
iomap: skip unnecessary ifs_block_is_uptodate check
2025-05-02 07:51:01 +02:00
isofs
isofs: Verify inode mode when loading from disk
2025-07-24 08:53:13 +02:00
jbd2
jbd2: prevent softlockup in jbd2_log_do_checkpoint()
2025-08-28 16:28:36 +02:00
jffs2
jffs2: check jffs2_prealloc_raw_node_refs() result in few other places
2025-06-27 11:08:58 +01:00
jfs
jfs: upper bound check of tree index in dbAllocAG
2025-08-28 16:28:26 +02:00
kernfs
kernfs: Relax constraint in draining guard
2025-06-19 15:28:16 +02:00
lockd
nfsd: stop setting ->pg_stats for unused stats
2024-08-19 06:04:23 +02:00
minix
Merge tag 'for-6.6/block-2023-08-28' of git://git.kernel.dk/linux
2023-08-29 20:21:42 -07:00
netfs
netfs: Only call folio_start_fscache() one time for each folio
2023-09-18 12:03:46 -07:00
nfs
NFS: Fix a race when updating an existing write
2025-09-04 15:30:20 +02:00
nfs_common
…
nfsd
NFSD: detect mismatch of file handle and delegation stateid in OPEN op
2025-08-28 16:28:11 +02:00
nilfs2
nilfs2: reject invalid file types when reading inodes
2025-08-01 09:47:30 +01:00
nls
nls: Hide new NLS_UCS2_UTILS
2023-08-31 12:07:34 -05:00
notify
fanotify: sanitize handle_type values when reporting fid
2025-08-15 12:08:52 +02:00
ntfs
Merge tag 'for-6.6/block-2023-08-28' of git://git.kernel.dk/linux
2023-08-29 20:21:42 -07:00
ntfs3
fs/ntfs3: correctly create symlink for relative path
2025-08-28 16:28:15 +02:00
ocfs2
ocfs2: fix possible memory leak in ocfs2_finish_quota_recovery
2025-06-19 15:28:23 +02:00
omfs
Merge tag 'for-6.6/block-2023-08-28' of git://git.kernel.dk/linux
2023-08-29 20:21:42 -07:00
openpromfs
openpromfs: finish conversion to the new mount API
2024-06-12 11:11:30 +02:00
orangefs
fs/orangefs: use snprintf() instead of sprintf()
2025-08-28 16:28:25 +02:00
overlayfs
ovl: Check for NULL d_inode() in ovl_dentry_upper()
2025-07-06 11:00:08 +02:00
proc
proc: use the same treatment to check proc_lseek as ones for proc_read_iter et.al
2025-08-15 12:08:54 +02:00
pstore
pstore: Change kmsg_bytes storage size to u32
2025-06-04 14:42:11 +02:00
qnx4
Merge tag 'for-6.6/block-2023-08-28' of git://git.kernel.dk/linux
2023-08-29 20:21:42 -07:00
qnx6
Merge tag 'for-6.6/block-2023-08-28' of git://git.kernel.dk/linux
2023-08-29 20:21:42 -07:00
quota
quota: flush quota_release_work upon quota writeback
2024-12-09 10:33:01 +01:00
ramfs
ramfs: convert to ctime accessor functions
2023-07-24 10:30:04 +02:00
reiserfs
reiserfs: fix uninit-value in comp_keys
2024-08-19 06:04:26 +02:00
romfs
fs: Convert to bdev_open_by_dev()
2024-08-19 06:04:25 +02:00
smb
smb: client: fix race with concurrent opens in rename(2)
2025-09-04 15:30:19 +02:00
squashfs
squashfs: fix memory leak in squashfs_fill_super
2025-08-28 16:28:43 +02:00
sysfs
fs: sysfs: Fix reference leak in sysfs_break_active_protection()
2024-04-27 17:11:41 +02:00
sysv
sysv: don't call sb_bread() with pointers_lock held
2024-04-13 13:07:34 +02:00
tracefs
tracefs: Add d_delete to remove negative dentries
2025-08-28 16:28:15 +02:00
ubifs
ubifs: skip dumping tnc tree when zroot is null
2025-02-08 09:52:28 +01:00
udf
udf: Verify partition map count
2025-08-28 16:28:15 +02:00
ufs
Merge tag 'for-6.6/block-2023-08-28' of git://git.kernel.dk/linux
2023-08-29 20:21:42 -07:00
unicode
Revert "unicode: Don't special case ignorable code points"
2024-12-14 20:00:20 +01:00
vboxsf
vboxsf: fix building with GCC 15
2025-03-22 12:50:41 -07:00
verity
fsverity: use register_sysctl_init() to avoid kmemleak warning
2024-06-16 13:47:33 +02:00
xfs
xfs: fully decouple XFS_IBULK* flags from XFS_IWALK* flags
2025-08-28 16:28:40 +02:00
zonefs
zonefs: Improve error handling
2024-02-23 09:25:13 +01:00
aio.c
fs/aio: Check IOCB_AIO_RW before the struct aio_kiocb conversion
2024-04-03 15:28:44 +02:00
anon_inodes.c
fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass
2025-07-10 16:03:18 +02:00
attr.c
Merge tag 'v6.6-vfs.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs
2023-08-28 10:17:14 -07:00
bad_inode.c
fs: drop the timespec64 argument from update_time
2023-08-11 09:04:57 +02:00
binfmt_elf_fdpic.c
fs: binfmt_elf_efpic: don't use missing interpreter's properties
2024-08-29 17:33:33 +02:00
binfmt_elf_test.c
…
binfmt_elf.c
binfmt_elf: Move brk for static PIE even if ASLR disabled
2025-05-22 14:12:12 +02:00
binfmt_flat.c
binfmt_flat: Fix integer overflow bug on 32 bit systems
2025-02-17 09:40:16 +01:00
binfmt_misc.c
binfmt_misc: cleanup on filesystem umount
2024-08-29 17:33:27 +02:00
binfmt_script.c
…
buffer.c
fs/buffer: fix use-after-free when call bh_read() helper
2025-08-28 16:28:44 +02:00
char_dev.c
…
compat_binfmt_elf.c
…
coredump.c
coredump: hand a pidfd to the usermode coredump helper
2025-06-04 14:42:24 +02:00
d_path.c
…
dax.c
fsdax: dax_unshare_iter needs to copy entire blocks
2024-11-08 16:28:19 +01:00
dcache.c
fs: better handle deep ancestor chains in is_subdir()
2024-07-25 09:50:54 +02:00
direct-io.c
Merge tag 'mm-stable-2023-06-24-19-15' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2023-06-28 10:28:11 -07:00
drop_caches.c
fs: drop_caches: draining pages before dropping caches
2023-08-18 10:12:11 -07:00
eventfd.c
eventfd: prevent underflow for eventfd semaphores
2023-07-11 11:41:34 +02:00
eventpoll.c
eventpoll: Fix semi-unbounded recursion
2025-08-28 16:28:12 +02:00
exec.c
exec: fix the racy usage of fs_struct->in_exec
2025-04-10 14:37:44 +02:00
fcntl.c
fs: Fix file_set_fowner LSM hook inconsistencies
2024-10-04 16:29:56 +02:00
fhandle.c
fs: Annotate struct file_handle with __counted_by() and use struct_size()
2024-08-19 06:04:28 +02:00
file_table.c
fs: fix proc_handler for sysctl_nr_open
2025-02-08 09:51:42 +01:00
file.c
alloc_fdtable(): change calling conventions.
2025-08-28 16:28:50 +02:00
filesystems.c
fs/filesystems: Fix potential unsigned integer underflow in fs_name()
2025-06-19 15:28:43 +02:00
fs_context.c
fs: factor out vfs_parse_monolithic_sep() helper
2023-10-12 18:53:36 +03:00
fs_parser.c
…
fs_pin.c
…
fs_struct.c
kill do_each_thread()
2023-08-21 13:46:25 -07:00
fs_types.c
…
fs-writeback.c
fs/writeback: bail out if there is no more inodes for IO and queued once
2024-06-27 13:49:00 +02:00
fsopen.c
fs: add FSCONFIG_CMD_CREATE_EXCL
2023-08-14 18:48:02 +02:00
init.c
…
inode.c
fs/inode: Prevent dump_mapping() accessing invalid dentry.d_name.name
2024-12-09 10:31:41 +01:00
internal.h
Merge tag 'for-6.6/block-2023-08-28' of git://git.kernel.dk/linux
2023-08-29 20:21:42 -07:00
ioctl.c
lsm: new security_file_ioctl_compat() hook
2024-01-31 16:18:54 -08:00
Kconfig
nfs: add missing selections of CONFIG_CRC32
2025-04-25 10:45:46 +02:00
Kconfig.binfmt
riscv: support the elf-fdpic binfmt loader
2023-08-23 14:17:43 -07:00
kernel_read_file.c
fs: Fix kernel-doc warnings
2023-08-19 12:12:12 +02:00
libfs.c
better lockdep annotations for simple_recursive_removal()
2025-08-28 16:28:15 +02:00
locks.c
filelock: Fix fcntl/close race recovery compat path
2024-07-27 11:34:10 +02:00
Makefile
fs: add CONFIG_BUFFER_HEAD
2023-08-02 09:13:09 -06:00
mbcache.c
…
mnt_idmapping.c
…
mount.h
…
mpage.c
…
namei.c
fuse: don't truncate cached, mutated symlink
2025-03-22 12:50:44 -07:00
namespace.c
use uniform permission checks for all mount propagation changes
2025-08-28 16:28:44 +02:00
nsfs.c
fs: convert to ctime accessor functions
2023-07-13 10:28:04 +02:00
open.c
openat2: explicitly return -E2BIG for (usize > PAGE_SIZE)
2024-11-01 01:58:32 +01:00
pipe.c
fs/pipe: Fix lockdep false-positive in watchqueue pipe_write()
2024-04-10 16:35:57 +02:00
pnode.c
…
pnode.h
…
posix_acl.c
fs: convert to ctime accessor functions
2023-07-13 10:28:04 +02:00
proc_namespace.c
…
read_write.c
fs: Fix one kernel-doc comment
2023-08-15 08:32:45 +02:00
readdir.c
vfs: get rid of old '->iterate' directory operation
2023-08-06 15:08:35 +02:00
remap_range.c
…
select.c
hrtimer: Use and report correct timerslack values for realtime tasks
2025-03-22 12:50:37 -07:00
seq_file.c
…
signalfd.c
…
splice.c
splice: remove duplicate noinline from pipe_clear_nowait
2025-05-02 07:50:45 +02:00
stack.c
fs: convert to ctime accessor functions
2023-07-13 10:28:04 +02:00
stat.c
fs: Pass AT_GETATTR_NOSEC flag to getattr interface function
2023-12-03 07:33:03 +01:00
statfs.c
…
super.c
fs: Convert to bdev_open_by_dev()
2024-08-19 06:04:25 +02:00
sync.c
…
sysctls.c
…
timerfd.c
…
userfaultfd.c
mm/userfaultfd: fix release hang over concurrent GUP
2025-04-25 10:45:31 +02:00
utimes.c
…
xattr.c
fs/xattr.c: fix simple_xattr_list()
2025-06-27 11:08:57 +01:00