shinys000114/linux
1
0
Fork 0
mirror of https://github.com/hardkernel/linux.git synced 2026-06-08 11:50:43 +09:00
Code Issues Packages Projects Releases Wiki Activity

drm/rockchip: vop2: Fix some compile warning

Browse Source 
Fix warning:

drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:542: warning: Function
parameter or member 'phys_id' not described in
'vop2_find_win_by_phys_id'
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:542: warning: Function
parameter or member 'vop2' not described in 'vop2_find_win_by_phys_id'

drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:3503
vop2_plane_create_name_property() warn: should '1 << (win->win_id)' be a
64 bit type?
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:3509
vop2_plane_create_name_property() warn: should '1 << (win->win_id)' be a
64 bit type?

Fixes: efe0578ec8 ("drm/rockchip: Add support for vop2")
Change-Id: Ia52eac3fcf2ddeff825b5fdaa26adcf26c71a7af
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
This commit is contained in:
Andy Yan
2020-11-06 10:11:43 +08:00
committed by Tao Huang
parent 9c6de47581
commit 924cd5bb04
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
View File

@@ -533,7 +533,7 @@ static inline uint32_t vop2_get_intr_type(struct vop2 *vop2, const struct vop_in
return ret;
}
/**
/*
* phys_id is used to identify a main window(Cluster Win/Smart Win, not
* include the sub win of a cluster or the multi area) that can do
* overlay in main overlay stage.
@@ -3496,17 +3496,18 @@ static int vop2_plane_create_name_property(struct vop2 *vop2, struct vop2_win *w
{
struct drm_prop_enum_list *props = vop2->plane_name_list;
struct drm_property *prop;
uint64_t bits = BIT(win->win_id);
prop = drm_property_create_bitmask(vop2->drm_dev,
DRM_MODE_PROP_IMMUTABLE, "NAME",
props, vop2->registered_num_wins,
BIT(win->win_id));
bits);
if (!prop) {
DRM_DEV_ERROR(vop2->dev, "create Name prop for %s failed\n", win->name);
return -ENOMEM;
}
win->name_prop = prop;
drm_object_attach_property(&win->base.base, win->name_prop, BIT(win->win_id));
drm_object_attach_property(&win->base.base, win->name_prop, bits);
return 0;
}
@@ -3693,7 +3694,7 @@ static int vop2_create_crtc(struct vop2 *vop2)
drm_object_attach_property(&crtc->base, vop2->vp_id_prop, vp->id);
}
/**
/*
* change the unused primary window to overlay window
*/
for (; j < vop2->registered_num_wins; j++) {