mirror of
https://github.com/hardkernel/linux.git
synced 2026-06-06 02:50:49 +09:00
c3239eb297
Test on RK3588S Tablet, set the power supply of logic on and set the power supply of usb2 phy off during deep sleep, then the id falling edge interrupt will be triggered after system resume, and kernel panic with the following log: SError Interrupt on CPU0, code 0xbe000011 -- SError CPU: 0 PID: 1946 Comm: kworker/0:0 Not tainted 5.10.110 #600 Hardware name: Rockchip RK3588S TABLET RK806 SINGLE Board (DT) Workqueue: events rockchip_usb2phy_otg_sm_work pstate: 20c00009 (nzCv daif +PAN +UAO -TCO BTYPE=--) pc : _raw_spin_unlock_irqrestore+0x28/0x60 lr : regmap_unlock_spinlock+0x18/0x28 ...... Kernel panic - not syncing: Asynchronous SError Interrupt CPU: 0 PID: 1946 Comm: kworker/0:0 Not tainted 5.10.110 #600 Hardware name: Rockchip RK3588S TABLET RK806 SINGLE Board (DT) Workqueue: events rockchip_usb2phy_otg_sm_work Call trace: dump_backtrace+0x0/0x1c8 show_stack+0x1c/0x2c dump_stack_lvl+0xdc/0x12c dump_stack+0x1c/0x64 panic+0x150/0x3a4 test_taint+0x0/0x30 arm64_serror_panic+0x78/0x84 do_serror+0xe0/0x100 el1_error+0x94/0x118 _raw_spin_unlock_irqrestore+0x28/0x60 regmap_unlock_spinlock+0x18/0x28 regmap_write+0x68/0x84 rockchip_usb2phy_power_on+0x128/0x1f0 rockchip_usb2phy_otg_sm_work+0x1d0/0x454 process_one_work+0x1f4/0x490 worker_thread+0x278/0x4dc kthread+0x13c/0x344 ret_from_fork+0x10/0x30 In fact, there are two issues here. 1. The power of phy id belongs to the usb2 phy power supply. And the id is pulled up to high level by default. So if we power off usb2 phy supply during deep sleep, the id status will fall to low level and trigger the falling edge interrupt. In the id irq handler rockchip_usb2phy_id_irq(), it send Host notification only depends the id falling edge irq status, it's not enough in this case, it needs to check the iddig status to make sure that the id status is indeed in low level. 2. For RK3588S, the pipe phystatus select register from the usb grf, and the power domain of usb grf belongs to PD_USB. So we must make sure the PD_USB is on when operate the pipe phystatus select register. Originally, we operated the pipe phystatus register in the phy ops of power_on, because we expected that the phy ops of power_on called from the dwc3 controller pm runtime resume process which can power on the PD_USB. However, in this test case, if the id falling edge interrupt after system resume, the phy ops of power_on can be called when PD_USB is off. The call stack: rockchip_usb2phy_id_irq() -> send Host notification -> rockchip_otg_event() -> receive notification and schedule otg_sm_work -> rockchip_usb2phy_otg_sm_work() -> detect EXTCON_USB_HOST is set and call phy power_on ops rockchip_usb2phy_power_on() -> set the pipe phystatus select register Change-Id: Ib7e5bc095ab1df2ca4c983d58a9f15720f0cccb9 Signed-off-by: William Wu <william.wu@rock-chips.com>
How do I submit patches to Android Common Kernels
-
BEST: Make all of your changes to upstream Linux. If appropriate, backport to the stable releases. These patches will be merged automatically in the corresponding common kernels. If the patch is already in upstream Linux, post a backport of the patch that conforms to the patch requirements below.
- Do not send patches upstream that contain only symbol exports. To be considered for upstream Linux,
additions of
EXPORT_SYMBOL_GPL()require an in-tree modular driver that uses the symbol -- so include the new driver or changes to an existing driver in the same patchset as the export. - When sending patches upstream, the commit message must contain a clear case for why the patch is needed and beneficial to the community. Enabling out-of-tree drivers or functionality is not not a persuasive case.
- Do not send patches upstream that contain only symbol exports. To be considered for upstream Linux,
additions of
-
LESS GOOD: Develop your patches out-of-tree (from an upstream Linux point-of-view). Unless these are fixing an Android-specific bug, these are very unlikely to be accepted unless they have been coordinated with kernel-team@android.com. If you want to proceed, post a patch that conforms to the patch requirements below.
Common Kernel patch requirements
- All patches must conform to the Linux kernel coding standards and pass
script/checkpatch.pl - Patches shall not break gki_defconfig or allmodconfig builds for arm, arm64, x86, x86_64 architectures (see https://source.android.com/setup/build/building-kernels)
- If the patch is not merged from an upstream branch, the subject must be tagged with the type of patch:
UPSTREAM:,BACKPORT:,FROMGIT:,FROMLIST:, orANDROID:. - All patches must have a
Change-Id:tag (see https://gerrit-review.googlesource.com/Documentation/user-changeid.html) - If an Android bug has been assigned, there must be a
Bug:tag. - All patches must have a
Signed-off-by:tag by the author and the submitter
Additional requirements are listed below based on patch type
Requirements for backports from mainline Linux: UPSTREAM:, BACKPORT:
- If the patch is a cherry-pick from Linux mainline with no changes at all
- tag the patch subject with
UPSTREAM:. - add upstream commit information with a
(cherry picked from commit ...)line - Example:
- if the upstream commit message is
- tag the patch subject with
important patch from upstream
This is the detailed description of the important patch
Signed-off-by: Fred Jones <fred.jones@foo.org>
- then Joe Smith would upload the patch for the common kernel as
UPSTREAM: important patch from upstream
This is the detailed description of the important patch
Signed-off-by: Fred Jones <fred.jones@foo.org>
Bug: 135791357
Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01
(cherry picked from commit c31e73121f4c1ec41143423ac6ce3ce6dafdcec1)
Signed-off-by: Joe Smith <joe.smith@foo.org>
- If the patch requires any changes from the upstream version, tag the patch with
BACKPORT:instead ofUPSTREAM:.- use the same tags as
UPSTREAM: - add comments about the changes under the
(cherry picked from commit ...)line - Example:
- use the same tags as
BACKPORT: important patch from upstream
This is the detailed description of the important patch
Signed-off-by: Fred Jones <fred.jones@foo.org>
Bug: 135791357
Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01
(cherry picked from commit c31e73121f4c1ec41143423ac6ce3ce6dafdcec1)
[joe: Resolved minor conflict in drivers/foo/bar.c ]
Signed-off-by: Joe Smith <joe.smith@foo.org>
Requirements for other backports: FROMGIT:, FROMLIST:,
- If the patch has been merged into an upstream maintainer tree, but has not yet
been merged into Linux mainline
- tag the patch subject with
FROMGIT: - add info on where the patch came from as
(cherry picked from commit <sha1> <repo> <branch>). This must be a stable maintainer branch (not rebased, so don't uselinux-nextfor example). - if changes were required, use
BACKPORT: FROMGIT: - Example:
- if the commit message in the maintainer tree is
- tag the patch subject with
important patch from upstream
This is the detailed description of the important patch
Signed-off-by: Fred Jones <fred.jones@foo.org>
- then Joe Smith would upload the patch for the common kernel as
FROMGIT: important patch from upstream
This is the detailed description of the important patch
Signed-off-by: Fred Jones <fred.jones@foo.org>
Bug: 135791357
(cherry picked from commit 878a2fd9de10b03d11d2f622250285c7e63deace
https://git.kernel.org/pub/scm/linux/kernel/git/foo/bar.git test-branch)
Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01
Signed-off-by: Joe Smith <joe.smith@foo.org>
- If the patch has been submitted to LKML, but not accepted into any maintainer tree
- tag the patch subject with
FROMLIST: - add a
Link:tag with a link to the submittal on lore.kernel.org - add a
Bug:tag with the Android bug (required for patches not accepted into a maintainer tree) - if changes were required, use
BACKPORT: FROMLIST: - Example:
- tag the patch subject with
FROMLIST: important patch from upstream
This is the detailed description of the important patch
Signed-off-by: Fred Jones <fred.jones@foo.org>
Bug: 135791357
Link: https://lore.kernel.org/lkml/20190619171517.GA17557@someone.com/
Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01
Signed-off-by: Joe Smith <joe.smith@foo.org>
Requirements for Android-specific patches: ANDROID:
- If the patch is fixing a bug to Android-specific code
- tag the patch subject with
ANDROID: - add a
Fixes:tag that cites the patch with the bug - Example:
- tag the patch subject with
ANDROID: fix android-specific bug in foobar.c
This is the detailed description of the important fix
Fixes: 1234abcd2468 ("foobar: add cool feature")
Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01
Signed-off-by: Joe Smith <joe.smith@foo.org>
- If the patch is a new feature
- tag the patch subject with
ANDROID: - add a
Bug:tag with the Android bug (required for android-specific features)
- tag the patch subject with