Files
linux/include/linux
Grant Grundler f0ded73267 net: usb: cdc_ncm: don't spew notifications
[ Upstream commit de658a195e ]

RTL8156 sends notifications about every 32ms.
Only display/log notifications when something changes.

This issue has been reported by others:
	https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1832472
	https://lkml.org/lkml/2020/8/27/1083

...
[785962.779840] usb 1-1: new high-speed USB device number 5 using xhci_hcd
[785962.929944] usb 1-1: New USB device found, idVendor=0bda, idProduct=8156, bcdDevice=30.00
[785962.929949] usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=6
[785962.929952] usb 1-1: Product: USB 10/100/1G/2.5G LAN
[785962.929954] usb 1-1: Manufacturer: Realtek
[785962.929956] usb 1-1: SerialNumber: 000000001
[785962.991755] usbcore: registered new interface driver cdc_ether
[785963.017068] cdc_ncm 1-1:2.0: MAC-Address: 00:24:27:88:08:15
[785963.017072] cdc_ncm 1-1:2.0: setting rx_max = 16384
[785963.017169] cdc_ncm 1-1:2.0: setting tx_max = 16384
[785963.017682] cdc_ncm 1-1:2.0 usb0: register 'cdc_ncm' at usb-0000:00:14.0-1, CDC NCM, 00:24:27:88:08:15
[785963.019211] usbcore: registered new interface driver cdc_ncm
[785963.023856] usbcore: registered new interface driver cdc_wdm
[785963.025461] usbcore: registered new interface driver cdc_mbim
[785963.038824] cdc_ncm 1-1:2.0 enx002427880815: renamed from usb0
[785963.089586] cdc_ncm 1-1:2.0 enx002427880815: network connection: disconnected
[785963.121673] cdc_ncm 1-1:2.0 enx002427880815: network connection: disconnected
[785963.153682] cdc_ncm 1-1:2.0 enx002427880815: network connection: disconnected
...

This is about 2KB per second and will overwrite all contents of a 1MB
dmesg buffer in under 10 minutes rendering them useless for debugging
many kernel problems.

This is also an extra 180 MB/day in /var/logs (or 1GB per week) rendering
the majority of those logs useless too.

When the link is up (expected state), spew amount is >2x higher:
...
[786139.600992] cdc_ncm 2-1:2.0 enx002427880815: network connection: connected
[786139.632997] cdc_ncm 2-1:2.0 enx002427880815: 2500 mbit/s downlink 2500 mbit/s uplink
[786139.665097] cdc_ncm 2-1:2.0 enx002427880815: network connection: connected
[786139.697100] cdc_ncm 2-1:2.0 enx002427880815: 2500 mbit/s downlink 2500 mbit/s uplink
[786139.729094] cdc_ncm 2-1:2.0 enx002427880815: network connection: connected
[786139.761108] cdc_ncm 2-1:2.0 enx002427880815: 2500 mbit/s downlink 2500 mbit/s uplink
...

Chrome OS cannot support RTL8156 until this is fixed.

Signed-off-by: Grant Grundler <grundler@chromium.org>
Reviewed-by: Hayes Wang <hayeswang@realtek.com>
Link: https://lore.kernel.org/r/20210120011208.3768105-1-grundler@chromium.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-05-16 11:11:37 +09:00
..
2023-04-21 13:52:38 +09:00
2015-10-07 18:08:15 +01:00
2016-07-08 16:23:11 +02:00
2023-05-15 17:28:23 +09:00
2016-08-25 11:26:48 -04:00
2017-10-08 10:26:06 +02:00
2018-04-12 09:54:41 -07:00
2018-02-28 10:18:33 +01:00
2018-05-30 13:19:56 +02:00
2016-06-07 13:41:38 -06:00
2023-05-16 10:34:10 +09:00
2016-05-17 15:48:12 -04:00
2018-04-12 09:54:41 -07:00
2023-05-15 15:11:10 +09:00
2017-07-12 15:01:02 +02:00
2017-12-10 17:13:13 +01:00
2023-05-16 08:57:37 +09:00
2018-04-12 09:54:41 -07:00
2023-05-16 10:33:18 +09:00
2018-03-14 20:21:31 -08:00
2016-07-22 09:07:02 +02:00
2016-09-24 10:48:18 +02:00
2023-05-16 10:49:16 +09:00
2016-02-11 09:59:22 -05:00
2018-04-09 11:39:17 -07:00
2016-10-20 15:51:28 +11:00
2016-09-16 09:34:15 +01:00
2016-09-14 09:18:09 -06:00
2016-05-11 22:37:54 +02:00
2015-06-25 12:06:45 +02:00
2016-01-28 14:19:12 -08:00
2023-05-15 08:33:22 +09:00
2016-08-10 11:23:44 -04:00
2017-10-30 09:27:09 +01:00
2016-03-22 15:36:02 -07:00
2015-07-28 08:50:42 +01:00
2016-01-15 17:56:32 -08:00
2016-09-15 16:49:39 +02:00
2016-09-27 12:33:47 +02:00
2017-08-24 17:12:19 -07:00
2018-04-17 17:58:08 -08:00
2015-07-21 10:39:05 -07:00
2016-04-25 15:09:11 -04:00
2016-02-16 13:04:58 -05:00
2016-10-19 11:36:22 -06:00
2016-05-02 09:00:56 -05:00
2018-03-22 09:54:47 +01:00
2023-05-16 09:47:52 +09:00
2016-02-11 18:35:48 -08:00
2016-03-14 15:43:11 -04:00
2023-05-15 17:09:21 +09:00
2017-08-24 17:12:21 -07:00
2016-10-14 11:36:59 -07:00
2016-07-12 19:25:38 -07:00
2016-09-27 21:52:00 -04:00
2016-09-08 15:01:10 -07:00
2016-03-17 15:09:34 -07:00
2016-07-06 10:51:14 +01:00
2016-03-22 15:36:02 -07:00
2016-07-26 16:19:19 -07:00
2016-09-08 22:15:25 -07:00
2023-05-16 10:33:18 +09:00
2023-05-15 17:12:28 +09:00
2017-08-30 10:21:40 +02:00
2016-08-28 23:44:55 -04:00
2016-10-05 18:23:36 -04:00
2018-05-30 13:19:56 +02:00
2023-05-15 09:23:01 +09:00
2017-03-17 13:14:32 +08:00
2015-10-01 09:57:59 -07:00
2016-07-19 17:43:38 +03:00
2023-05-16 09:51:27 +09:00
2016-05-23 17:04:14 -07:00
2016-04-07 16:53:29 -04:00
2017-04-21 09:31:21 +02:00
2015-11-23 09:44:58 +01:00
2016-07-26 16:19:19 -07:00
2016-05-20 17:58:30 -07:00
2018-04-03 17:37:41 -08:00
2023-05-15 17:12:32 +09:00
2016-09-30 10:54:03 +02:00
2015-12-03 07:24:29 -08:00
2023-05-15 10:05:34 +09:00
2015-09-08 15:35:28 -07:00