Files
linux/include/linux
Song Liu ed82a31d39 perf/core: Fix bad use of igrab()
commit 9511bce9fe upstream

As Miklos reported and suggested:

 "This pattern repeats two times in trace_uprobe.c and in
  kernel/events/core.c as well:

      ret = kern_path(filename, LOOKUP_FOLLOW, &path);
      if (ret)
          goto fail_address_parse;

      inode = igrab(d_inode(path.dentry));
      path_put(&path);

  And it's wrong.  You can only hold a reference to the inode if you
  have an active ref to the superblock as well (which is normally
  through path.mnt) or holding s_umount.

  This way unmounting the containing filesystem while the tracepoint is
  active will give you the "VFS: Busy inodes after unmount..." message
  and a crash when the inode is finally put.

  Solution: store path instead of inode."

This patch fixes the issue in kernel/event/core.c.

Reviewed-and-tested-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Reported-by: Miklos Szeredi <miklos@szeredi.hu>
Signed-off-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: <kernel-team@fb.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Fixes: 375637bc52 ("perf/core: Introduce address range filtering")
Link: http://lkml.kernel.org/r/20180418062907.3210386-2-songliubraving@fb.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
[sudip: Backported to 4.9: use file_inode()]
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-05-16 09:47:52 +09:00
..
2023-04-21 13:52:38 +09:00
2015-10-07 18:08:15 +01:00
2016-07-08 16:23:11 +02:00
2023-05-15 17:28:23 +09:00
2016-08-25 11:26:48 -04:00
2017-10-08 10:26:06 +02:00
2018-04-24 09:34:18 +02:00
2018-04-12 09:54:41 -07:00
2018-02-28 10:18:33 +01:00
2018-05-30 13:19:56 +02:00
2016-06-07 13:41:38 -06:00
2016-05-17 15:48:12 -04:00
2018-04-12 09:54:41 -07:00
2023-05-15 15:11:10 +09:00
2017-07-12 15:01:02 +02:00
2017-12-10 17:13:13 +01:00
2023-05-16 08:57:37 +09:00
2018-04-12 09:54:41 -07:00
2023-05-15 17:11:10 +09:00
2018-03-14 20:21:31 -08:00
2016-07-22 09:07:02 +02:00
2016-09-24 10:48:18 +02:00
2015-11-25 09:22:00 -07:00
2016-02-11 09:59:22 -05:00
2018-04-09 11:39:17 -07:00
2016-10-20 15:51:28 +11:00
2016-09-16 09:34:15 +01:00
2016-09-14 09:18:09 -06:00
2018-01-02 20:45:15 +01:00
2016-05-11 22:37:54 +02:00
2015-06-25 12:06:45 +02:00
2016-01-28 14:19:12 -08:00
2023-05-15 08:33:22 +09:00
2016-08-10 11:23:44 -04:00
2017-10-30 09:27:09 +01:00
2016-03-22 15:36:02 -07:00
2015-07-28 08:50:42 +01:00
2023-05-15 17:12:36 +09:00
2016-01-15 17:56:32 -08:00
2016-09-15 16:49:39 +02:00
2016-09-27 12:33:47 +02:00
2017-08-24 17:12:19 -07:00
2018-04-17 17:58:08 -08:00
2015-06-24 17:49:41 -07:00
2015-07-21 10:39:05 -07:00
2016-04-25 15:09:11 -04:00
2016-02-16 13:04:58 -05:00
2016-10-19 11:36:22 -06:00
2016-05-02 09:00:56 -05:00
2018-03-22 09:54:47 +01:00
2023-05-16 09:47:52 +09:00
2016-02-11 18:35:48 -08:00
2016-03-14 15:43:11 -04:00
2023-05-15 17:09:21 +09:00
2017-08-24 17:12:21 -07:00
2016-10-14 11:36:59 -07:00
2016-07-12 19:25:38 -07:00
2016-09-27 21:52:00 -04:00
2016-09-08 15:01:10 -07:00
2016-03-17 15:09:34 -07:00
2016-07-06 10:51:14 +01:00
2016-03-22 15:36:02 -07:00
2016-07-26 16:19:19 -07:00
2016-09-08 22:15:25 -07:00
2023-05-15 17:14:27 +09:00
2023-05-15 17:12:28 +09:00
2017-08-30 10:21:40 +02:00
2016-08-28 23:44:55 -04:00
2016-10-05 18:23:36 -04:00
2023-05-15 12:21:56 +09:00
2018-05-30 13:19:56 +02:00
2023-05-15 09:23:01 +09:00
2017-03-17 13:14:32 +08:00
2015-10-01 09:57:59 -07:00
2016-07-19 17:43:38 +03:00
2023-05-15 17:27:48 +09:00
2016-05-23 17:04:14 -07:00
2016-04-07 16:53:29 -04:00
2017-04-21 09:31:21 +02:00
2015-11-23 09:44:58 +01:00
2016-07-26 16:19:19 -07:00
2016-05-20 17:58:30 -07:00
2017-12-25 14:23:37 +01:00
2018-04-03 17:37:41 -08:00
2023-05-15 17:12:32 +09:00
2016-09-30 10:54:03 +02:00
2015-12-03 07:24:29 -08:00
2023-05-15 10:05:34 +09:00
2015-09-08 15:35:28 -07:00